test(cli): pin RepairArgs flag surface (download-mode=file, gc alias)#75
Closed
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Closed
test(cli): pin RepairArgs flag surface (download-mode=file, gc alias)#75Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Conversation
Sets up the foundation for a comprehensive unit-test campaign on the
socket-patch CLI. No behavior change to the binary.
Two changes:
1. Expose the clap parser as a library so integration tests can verify
the public CLI contract without spawning the binary:
- new crates/socket-patch-cli/src/lib.rs hosting Cli, Commands,
looks_like_uuid, and parse_with_uuid_fallback (extracted from main.rs)
- Cargo.toml gains [lib] entry alongside the existing [[bin]]
- main.rs is now a thin wrapper that delegates to the lib
2. De-duplicate the manifest-path resolution block that was copy-pasted
into 5 commands (apply, rollback, list, remove, repair). New helper
socket_patch_core::manifest::operations::resolve_manifest_path
handles the absolute-vs-relative join in one place, with 3 unit tests.
3. New CLI_CONTRACT.md next to the crate documenting every subcommand,
flag, default, alias, JSON shape, and exit code as semver-significant
surface. Adds a comment block above pub enum Commands pointing to it
so anyone editing the parser sees the contract reminder.
Verified: cargo build/clippy/test --workspace --all-features all clean
(415 unit tests pass, including 3 new resolve_manifest_path tests).
Foundation for follow-up PRs that add the per-command parser snapshot
tests and helper unit tests.
Assisted-by: Claude Code:claude-opus-4-7
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-contract-foundation
branch
from
0bd4f50 to
6cb84b8
Compare
Add a parser-level integration test that locks in the public clap contract for the `repair` subcommand. The key assertion is that `--download-mode` defaults to `"file"` — diverging from every other command's `"diff"` default. `repair` restores legacy per-file blobs needed to apply any patch, so a silent flip to `"diff"` would break that path with no parser-level signal. The `gc` visible alias is also exercised (both bare and with a flag) so a refactor that drops it is caught immediately. Covers every flag in the repair row of CLI_CONTRACT.md plus an unknown-flag failure case that pins the clap error kind. Assisted-by: Claude Code:claude-opus-4-7
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-parse-repair
branch
from
2053747 to
7607110
Compare
Mikola Lysenko (mikolalysenko)
force-pushed
the
tests/cli-contract-foundation
branch
from
6cb84b8 to
ef0deac
Compare
Contributor
Author
|
Squashed into #68. All tests from this PR are now part of the single combined commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds parser-level integration tests for the
repairsubcommand to lock in its public clap contract. The key invariant guarded here is that--download-modedefaults to"file"forrepair— diverging from every other command's"diff"default.repairrestores legacy per-file blobs needed to apply any patch, so a silent flip to"diff"would break that path with no parser-level signal.The
gcvisible alias is also exercised (both bare and with a flag) so a refactor that drops it is caught immediately. Every flag in the repair row ofCLI_CONTRACT.mdis now covered.This PR is stacked on
tests/cli-contract-foundation(#67).Coverage
cwd,manifest-path,dry-run,offline,download-only,json, and the divergentdownload-mode = "file".--dry-run/-dand--manifest-path/-m.--download-modevalues:file,diff,package.gcalias defaults matchrepairdefaults exactly.gcalias accepts flags (--dry-run).clap::error::ErrorKind::UnknownArgument.Test plan
cargo build --workspace --all-featurescargo test --workspace --all-features --lib --tests— 15 new tests pass, no regressionscargo clippy --all-features --test cli_parse_repair -- -D warningsclean on the new fileAssisted-by: Claude Code:claude-opus-4-7