test(cli): pin RemoveArgs/SetupArgs flag surface + run() error paths

Adds two parser-snapshot integration test files that lock in every flag
in the `remove` and `setup` tables of CLI_CONTRACT.md (long + short
forms, defaults) plus the documented no-network exit paths:

- crates/socket-patch-cli/tests/cli_parse_remove.rs (16 tests):
  defaults with PURL or UUID positional, every flag in long + short form
  (`-y`/`--yes`, `-g`/`--global`, `-m`/`--manifest-path`, `--cwd`,
  `--skip-rollback`, `--json`, `--global-prefix`), an all-flags-combined
  case, missing-positional → MissingRequiredArgument, unknown flag →
  UnknownArgument, and an async `run()` against an empty tempdir
  asserting exit code 1 for missing manifest.

- crates/socket-patch-cli/tests/cli_parse_setup.rs (11 tests):
  defaults, every flag in long + short form (`-d`/`--dry-run`,
  `-y`/`--yes`, `--cwd`, `--json`), all-flags-combined, unknown flag →
  UnknownArgument, an async `run()` against an empty tempdir asserting
  exit 0, and a subprocess test using `env!("CARGO_BIN_EXE_socket-patch")`
  that parses the `--json` output and asserts the documented
  `status: "no_files"` shape (updated/alreadyConfigured/errors all 0,
  files == []).

Both files are net-new and test-only — no production code touched.

Verified from /tmp/spw/remove-setup:
- cargo build --workspace --all-features: clean
- cargo clippy --workspace --all-features -- -D warnings: clean
- cargo test --workspace --all-features --lib --tests: 415 lib + 16
  cli_parse_remove + 11 cli_parse_setup + all existing pass

Assisted-by: Claude Code:claude-opus-4-7

Author: mikolalysenko

crates/socket-patch-cli/tests/cli_parse_remove.rs

@@ -0,0 +1,203 @@
+//! Parser-level contract tests for `socket-patch remove`.
+//!
+//! Locks in every flag in the `RemoveArgs` table from
+//! `crates/socket-patch-cli/CLI_CONTRACT.md` (long + short forms, defaults)
+//! and exercises one no-network `run()` error path (missing manifest → 1).
+//!
+//! These tests deliberately avoid spawning the binary so they run in the
+//! default `cargo test` set (no `--ignored` required) and stay fast.
+
+use clap::Parser;
+use socket_patch_cli::commands::remove::{run, RemoveArgs};
+use socket_patch_cli::{Cli, Commands};
+use std::path::PathBuf;
+
+fn parse_remove(extra: &[&str]) -> RemoveArgs {
+    let mut argv = vec!["socket-patch", "remove"];
+    argv.extend_from_slice(extra);
+    let cli = Cli::try_parse_from(&argv).expect("parse");
+    match cli.command {
+        Commands::Remove(a) => a,
+        _ => panic!("expected Remove"),
+    }
+}
+
+// ---------------------------------------------------------------------------
+// Defaults
+// ---------------------------------------------------------------------------
+
+#[test]
+fn defaults_with_purl_positional() {
+    let args = parse_remove(&["pkg:npm/foo@1"]);
+    assert_eq!(args.identifier, "pkg:npm/foo@1");
+    assert_eq!(args.cwd, PathBuf::from("."));
+    assert_eq!(args.manifest_path, ".socket/manifest.json");
+    assert!(!args.skip_rollback);
+    assert!(!args.yes);
+    assert!(!args.global);
+    assert_eq!(args.global_prefix, None);
+    assert!(!args.json);
+}
+
+#[test]
+fn positional_uuid_stored_in_identifier() {
+    let args = parse_remove(&["80630680-4da6-45f9-bba8-b888e0ffd58c"]);
+    assert_eq!(args.identifier, "80630680-4da6-45f9-bba8-b888e0ffd58c");
+    // Everything else still at default — `remove` does not auto-detect the
+    // identifier shape at parse time; the runtime branch on `pkg:` happens
+    // inside `run()`.
+    assert_eq!(args.cwd, PathBuf::from("."));
+    assert_eq!(args.manifest_path, ".socket/manifest.json");
+    assert!(!args.skip_rollback);
+    assert!(!args.yes);
+    assert!(!args.global);
+    assert_eq!(args.global_prefix, None);
+    assert!(!args.json);
+}
+
+// ---------------------------------------------------------------------------
+// Flag forms — each one in the contract table must have a test
+// ---------------------------------------------------------------------------
+
+#[test]
+fn yes_short_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "-y"]);
+    assert!(args.yes);
+}
+
+#[test]
+fn yes_long_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "--yes"]);
+    assert!(args.yes);
+}
+
+#[test]
+fn global_short_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "-g"]);
+    assert!(args.global);
+}
+
+#[test]
+fn global_long_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "--global"]);
+    assert!(args.global);
+}
+
+#[test]
+fn manifest_path_short_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "-m", "custom/manifest.json"]);
+    assert_eq!(args.manifest_path, "custom/manifest.json");
+}
+
+#[test]
+fn manifest_path_long_form() {
+    let args = parse_remove(&[
+        "pkg:npm/foo@1",
+        "--manifest-path",
+        "custom/manifest.json",
+    ]);
+    assert_eq!(args.manifest_path, "custom/manifest.json");
+}
+
+#[test]
+fn cwd_long_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "--cwd", "/tmp/x"]);
+    assert_eq!(args.cwd, PathBuf::from("/tmp/x"));
+}
+
+#[test]
+fn skip_rollback_long_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "--skip-rollback"]);
+    assert!(args.skip_rollback);
+}
+
+#[test]
+fn json_long_form() {
+    let args = parse_remove(&["pkg:npm/foo@1", "--json"]);
+    assert!(args.json);
+}
+
+#[test]
+fn global_prefix_long_form() {
+    let args = parse_remove(&[
+        "pkg:npm/foo@1",
+        "--global-prefix",
+        "/opt/node-global",
+    ]);
+    assert_eq!(args.global_prefix, Some(PathBuf::from("/opt/node-global")));
+}
+
+#[test]
+fn all_flags_combined() {
+    let args = parse_remove(&[
+        "pkg:npm/foo@1",
+        "--cwd",
+        "/tmp/x",
+        "-m",
+        "custom/manifest.json",
+        "--skip-rollback",
+        "-y",
+        "-g",
+        "--global-prefix",
+        "/opt/node-global",
+        "--json",
+    ]);
+    assert_eq!(args.identifier, "pkg:npm/foo@1");
+    assert_eq!(args.cwd, PathBuf::from("/tmp/x"));
+    assert_eq!(args.manifest_path, "custom/manifest.json");
+    assert!(args.skip_rollback);
+    assert!(args.yes);
+    assert!(args.global);
+    assert_eq!(args.global_prefix, Some(PathBuf::from("/opt/node-global")));
+    assert!(args.json);
+}
+
+// ---------------------------------------------------------------------------
+// Failure paths
+// ---------------------------------------------------------------------------
+
+#[test]
+fn missing_required_positional_is_error() {
+    let result = Cli::try_parse_from(["socket-patch", "remove"]);
+    let err = match result {
+        Ok(_) => panic!("remove without identifier must fail"),
+        Err(e) => e,
+    };
+    assert_eq!(err.kind(), clap::error::ErrorKind::MissingRequiredArgument);
+}
+
+#[test]
+fn unknown_flag_is_error() {
+    let result = Cli::try_parse_from([
+        "socket-patch",
+        "remove",
+        "pkg:npm/foo@1",
+        "--not-a-real-flag",
+    ]);
+    let err = match result {
+        Ok(_) => panic!("unknown flag must fail"),
+        Err(e) => e,
+    };
+    assert_eq!(err.kind(), clap::error::ErrorKind::UnknownArgument);
+}
+
+// ---------------------------------------------------------------------------
+// Async run() — no-network error path
+// ---------------------------------------------------------------------------
+
+#[tokio::test]
+async fn run_missing_manifest_exits_one() {
+    let tempdir = tempfile::tempdir().expect("tempdir");
+    let args = RemoveArgs {
+        identifier: "pkg:npm/foo@1".to_string(),
+        cwd: tempdir.path().to_path_buf(),
+        manifest_path: ".socket/manifest.json".to_string(),
+        skip_rollback: false,
+        yes: true,
+        global: false,
+        global_prefix: None,
+        json: true,
+    };
+    let exit = run(args).await;
+    assert_eq!(exit, 1, "missing manifest must exit 1");
+}

crates/socket-patch-cli/tests/cli_parse_setup.rs

@@ -0,0 +1,164 @@
+//! Parser-level contract tests for `socket-patch setup`.
+//!
+//! Locks in every flag in the `SetupArgs` table from
+//! `crates/socket-patch-cli/CLI_CONTRACT.md` (long + short forms, defaults)
+//! and exercises two no-network `run()` paths:
+//!
+//! 1. Calling `run()` directly against an empty tempdir → exit 0.
+//! 2. Spawning the binary against the same empty tempdir with `--json` and
+//!    asserting the documented `status: "no_files"` shape.
+//!
+//! These tests deliberately stay off the network so they run in the default
+//! `cargo test` set (no `--ignored` required).
+
+use clap::Parser;
+use socket_patch_cli::commands::setup::{run, SetupArgs};
+use socket_patch_cli::{Cli, Commands};
+use std::path::PathBuf;
+use std::process::Command;
+
+fn parse_setup(extra: &[&str]) -> SetupArgs {
+    let mut argv = vec!["socket-patch", "setup"];
+    argv.extend_from_slice(extra);
+    let cli = Cli::try_parse_from(&argv).expect("parse");
+    match cli.command {
+        Commands::Setup(a) => a,
+        _ => panic!("expected Setup"),
+    }
+}
+
+// ---------------------------------------------------------------------------
+// Defaults
+// ---------------------------------------------------------------------------
+
+#[test]
+fn defaults_with_no_flags() {
+    let args = parse_setup(&[]);
+    assert_eq!(args.cwd, PathBuf::from("."));
+    assert!(!args.dry_run);
+    assert!(!args.yes);
+    assert!(!args.json);
+}
+
+// ---------------------------------------------------------------------------
+// Flag forms — each one in the contract table must have a test
+// ---------------------------------------------------------------------------
+
+#[test]
+fn dry_run_short_form() {
+    let args = parse_setup(&["-d"]);
+    assert!(args.dry_run);
+}
+
+#[test]
+fn dry_run_long_form() {
+    let args = parse_setup(&["--dry-run"]);
+    assert!(args.dry_run);
+}
+
+#[test]
+fn yes_short_form() {
+    let args = parse_setup(&["-y"]);
+    assert!(args.yes);
+}
+
+#[test]
+fn yes_long_form() {
+    let args = parse_setup(&["--yes"]);
+    assert!(args.yes);
+}
+
+#[test]
+fn cwd_long_form() {
+    let args = parse_setup(&["--cwd", "/tmp/x"]);
+    assert_eq!(args.cwd, PathBuf::from("/tmp/x"));
+}
+
+#[test]
+fn json_long_form() {
+    let args = parse_setup(&["--json"]);
+    assert!(args.json);
+}
+
+#[test]
+fn all_flags_combined() {
+    let args = parse_setup(&["--cwd", "/tmp/x", "-d", "-y", "--json"]);
+    assert_eq!(args.cwd, PathBuf::from("/tmp/x"));
+    assert!(args.dry_run);
+    assert!(args.yes);
+    assert!(args.json);
+}
+
+// ---------------------------------------------------------------------------
+// Failure paths
+// ---------------------------------------------------------------------------
+
+#[test]
+fn unknown_flag_is_error() {
+    let result = Cli::try_parse_from(["socket-patch", "setup", "--not-a-real-flag"]);
+    let err = match result {
+        Ok(_) => panic!("unknown flag must fail"),
+        Err(e) => e,
+    };
+    assert_eq!(err.kind(), clap::error::ErrorKind::UnknownArgument);
+}
+
+// ---------------------------------------------------------------------------
+// Async run() — empty tempdir, no package.json files → exit 0
+// ---------------------------------------------------------------------------
+
+#[tokio::test]
+async fn run_empty_tempdir_exits_zero() {
+    let tempdir = tempfile::tempdir().expect("tempdir");
+    let args = SetupArgs {
+        cwd: tempdir.path().to_path_buf(),
+        dry_run: false,
+        yes: true,
+        json: true,
+    };
+    let exit = run(args).await;
+    assert_eq!(
+        exit, 0,
+        "empty tempdir (no package.json) must exit 0 with status 'no_files'"
+    );
+}
+
+// ---------------------------------------------------------------------------
+// Subprocess: lock the JSON contract shape for `status: no_files`.
+// ---------------------------------------------------------------------------
+
+#[test]
+fn subprocess_no_files_json_shape() {
+    let tempdir = tempfile::tempdir().expect("tempdir");
+    let exe = env!("CARGO_BIN_EXE_socket-patch");
+    let output = Command::new(exe)
+        .arg("setup")
+        .arg("--cwd")
+        .arg(tempdir.path())
+        .arg("--json")
+        .arg("--yes")
+        .output()
+        .expect("spawn socket-patch");
+    assert!(
+        output.status.success(),
+        "setup against empty tempdir must succeed, stderr: {}",
+        String::from_utf8_lossy(&output.stderr)
+    );
+    let stdout = String::from_utf8(output.stdout).expect("utf8 stdout");
+    let v: serde_json::Value = serde_json::from_str(&stdout).unwrap_or_else(|e| {
+        panic!("stdout must be JSON, got {stdout:?}: {e}");
+    });
+    assert_eq!(
+        v["status"], "no_files",
+        "status must be 'no_files' for empty tempdir; full payload: {v}"
+    );
+    assert_eq!(v["updated"], 0);
+    assert_eq!(v["alreadyConfigured"], 0);
+    assert_eq!(v["errors"], 0);
+    assert!(v["files"].is_array(), "'files' must be an array");
+    assert_eq!(
+        v["files"].as_array().expect("array").len(),
+        0,
+        "'files' must be an empty array for status 'no_files'"
+    );
+}