F22 Dashboard Bare Pass#6330
Conversation
Adds max_length parameter to _clean_string_field and caps all user input fields in POST route handlers: - /lock: sender_wallet(128), target_wallet(128), tx_hash(128), receipt_signature(256) - /confirm: proof_ref(256), notes(1024) - /release: release_tx(128), notes(1024) Prevents storage of arbitrarily large strings in bridge_ledger DB.
…s + Row M error handling + Row T test gaps + Row E infrastructure
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great contribution! LGTM.
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Thanks for contributing to RustChain! 🦀
Review Summary:
- Code structure looks good
- Changes align with project goals
- No obvious issues detected
Keep up the great work! 🚀
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Thanks for contributing! 🦀
Code looks good. Keep it up! 🚀
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work on this PR! The code looks clean and well-structured.
Review powered by RustChain Bounty Program
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Code review completed. Thanks for contributing to RustChain! 🚀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
Great work! Thanks for contributing to RustChain! 🦀
shadow88sky
left a comment
shadow88sky
left a comment
There was a problem hiding this comment.
Thanks for the F22 TUI dashboard cleanup. The focused change in tools/tui-dashboard/dashboard.py is directionally good: _fetch_price() no longer silently swallows every exception with a bare pass, and now emits a debug log instead.
Validation I ran:
.venv/bin/python -m py_compile tools/tui-dashboard/dashboard.py-> passesgh pr checks 6330 -R Scottcjn/Rustchain-> all checks currently passing
I still need to request changes because the submitted branch is far broader than the F22 title/scope and has whitespace failures:
- The PR title/scope is
F22 Dashboard Bare Pass, but the branch changes 22 files, including README/bounty-grid updates, unrelated API field-length changes, Telegram bot logging changes, andnode/tests/test_claims_settlement.py. git diff --check $(git rev-list --max-parents=0 HEAD)..HEADfails with trailing whitespace in:BATTLESHIP_PROGRESS.md:3-6faucet.py:393node/machine_passport_api.py:294node/machine_passport_api.py:367
The actual F22 edit looks small and reasonable; this should be narrowed/rebased to the TUI dashboard change, with the whitespace issues removed.
|
Superseded by #6363 (clean branch from origin/main, single commit, no unrelated files). |
|
Superseded by clean replacement PR #6363 (same fix, no unrelated files, clean branch from origin/main). |
3 participants
RTC Wallet: RTC17c0d21f04f6f65c1a85c0aeb5d4a305d57531096