Replies: 1 comment 1 reply
-
|
The 72 character limit comes from git commit message conventions, but it's not a standard in lua. The most popular lua formatter StyLua, and EmmyLuaCodeStyle both default to 120 characters (uosc already uses EmmyLua in its Might be worth introducing an .editorconfig to define consistent formatting rules across editors. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Recently I've been going through the entire code bit by bit to reduce redundancy.
The one thing I noticed that there are long lines, really long. Should we follow the 72 chars limit per line rule:
https://dev.to/noelworden/improving-your-commit-message-with-the-50-72-rule-3g79
This is one of the oldest rules (since punch cards).
There are no performance benefits, just makes code more readable, for example, in commit logs or terminals.
I won't do this now. There is a lot to clean up in ModernZ's code base. After I've reached a satisfactory stage, I might consider.
The only downside, if it can be called that, the lines count will increase significantly.
Beta Was this translation helpful? Give feedback.
All reactions