Merge pull request #6 from SafeMemoryZone/fix/remove-idt-testing

Fix/remove idt testing

Author: SafeMemoryZone

include/cpu/idt.h

@@ -1,8 +1,6 @@
 #ifndef IDT_H
 #define IDT_H
-#include <stdbool.h>
 
 void init_idt();
-bool test_exceptions();
 
 #endif  // IDT_H

src/cpu/idt.c

@@ -144,120 +144,3 @@ void init_idt() {
 	struct idt_ptr idtr = make_idtr();
 	load_idt(&idtr);
 }
-
-// === DEBUG ===
-
-static int last_vector;
-
-static void testing_exception_handler(struct interrupt_frame* frame) {
-	last_vector = frame->vector;
-}
-
-// Only tests IDT vector #0-#31
-bool test_exceptions() {
-	// Install test exception handler
-	active_exception_handler = testing_exception_handler;
-
-#define ASSERT_LAST_IDT_VECTOR_NUM(num) \
-	if (last_vector != num) return false
-
-// For vectors without error codes: use int N directly
-#define TRIGGER_INTERRUPT(n) asm volatile("int %0" : : "i"(n))
-
-// For vectors with error codes: int N never pushes an error code, but isr_err stubs
-// expect one. We build a fake interrupt frame with a dummy error code on the stack and
-// jump directly to the ISR stub
-#define _STR(x) #x
-#define STR(x) _STR(x)
-#define KERNEL_SS 0x10
-#define TRIGGER_INTERRUPT_ERR(n) \
-	asm volatile(     \
-    "movq %%rsp, %%rdx\n\t"                        \
-    "pushq $" STR(KERNEL_SS) "\n\t"  /* fake SS */  \
-    "pushq %%rdx\n\t"               /* fake RSP */  \
-    "pushfq\n\t"                     /* RFLAGS */    \
-    "pushq $" STR(KERNEL_CS) "\n\t"  /* fake CS */   \
-    "leaq 1f(%%rip), %%rax\n\t"                      \
-    "pushq %%rax\n\t"               /* fake RIP */   \
-    "pushq $0\n\t"              /* dummy error code */\
-    "jmp isr_stub_" #n "\n\t"                         \
-    "1:\n\t"                                           \
-    : : : "rax", "rdx", "memory")
-
-	TRIGGER_INTERRUPT(0);
-	ASSERT_LAST_IDT_VECTOR_NUM(0);
-	TRIGGER_INTERRUPT(1);
-	ASSERT_LAST_IDT_VECTOR_NUM(1);
-	TRIGGER_INTERRUPT(2);
-	ASSERT_LAST_IDT_VECTOR_NUM(2);
-	TRIGGER_INTERRUPT(3);
-	ASSERT_LAST_IDT_VECTOR_NUM(3);
-	TRIGGER_INTERRUPT(4);
-	ASSERT_LAST_IDT_VECTOR_NUM(4);
-	TRIGGER_INTERRUPT(5);
-	ASSERT_LAST_IDT_VECTOR_NUM(5);
-	TRIGGER_INTERRUPT(6);
-	ASSERT_LAST_IDT_VECTOR_NUM(6);
-	TRIGGER_INTERRUPT(7);
-	ASSERT_LAST_IDT_VECTOR_NUM(7);
-	TRIGGER_INTERRUPT_ERR(8);
-	ASSERT_LAST_IDT_VECTOR_NUM(8);
-	TRIGGER_INTERRUPT(9);
-	ASSERT_LAST_IDT_VECTOR_NUM(9);
-	TRIGGER_INTERRUPT_ERR(10);
-	ASSERT_LAST_IDT_VECTOR_NUM(10);
-	TRIGGER_INTERRUPT_ERR(11);
-	ASSERT_LAST_IDT_VECTOR_NUM(11);
-	TRIGGER_INTERRUPT_ERR(12);
-	ASSERT_LAST_IDT_VECTOR_NUM(12);
-	TRIGGER_INTERRUPT_ERR(13);
-	ASSERT_LAST_IDT_VECTOR_NUM(13);
-	TRIGGER_INTERRUPT_ERR(14);
-	ASSERT_LAST_IDT_VECTOR_NUM(14);
-	TRIGGER_INTERRUPT(15);
-	ASSERT_LAST_IDT_VECTOR_NUM(15);
-	TRIGGER_INTERRUPT(16);
-	ASSERT_LAST_IDT_VECTOR_NUM(16);
-	TRIGGER_INTERRUPT_ERR(17);
-	ASSERT_LAST_IDT_VECTOR_NUM(17);
-	TRIGGER_INTERRUPT(18);
-	ASSERT_LAST_IDT_VECTOR_NUM(18);
-	TRIGGER_INTERRUPT(19);
-	ASSERT_LAST_IDT_VECTOR_NUM(19);
-	TRIGGER_INTERRUPT(20);
-	ASSERT_LAST_IDT_VECTOR_NUM(20);
-	TRIGGER_INTERRUPT_ERR(21);
-	ASSERT_LAST_IDT_VECTOR_NUM(21);
-	TRIGGER_INTERRUPT(22);
-	ASSERT_LAST_IDT_VECTOR_NUM(22);
-	TRIGGER_INTERRUPT(23);
-	ASSERT_LAST_IDT_VECTOR_NUM(23);
-	TRIGGER_INTERRUPT(24);
-	ASSERT_LAST_IDT_VECTOR_NUM(24);
-	TRIGGER_INTERRUPT(25);
-	ASSERT_LAST_IDT_VECTOR_NUM(25);
-	TRIGGER_INTERRUPT(26);
-	ASSERT_LAST_IDT_VECTOR_NUM(26);
-	TRIGGER_INTERRUPT(27);
-	ASSERT_LAST_IDT_VECTOR_NUM(27);
-	TRIGGER_INTERRUPT(28);
-	ASSERT_LAST_IDT_VECTOR_NUM(28);
-	TRIGGER_INTERRUPT(29);
-	ASSERT_LAST_IDT_VECTOR_NUM(29);
-	TRIGGER_INTERRUPT(30);
-	ASSERT_LAST_IDT_VECTOR_NUM(30);
-	TRIGGER_INTERRUPT(31);
-	ASSERT_LAST_IDT_VECTOR_NUM(31);
-
-#undef ASSERT_LAST_IDT_VECTOR_NUM
-#undef TRIGGER_INTERRUPT
-#undef TRIGGER_INTERRUPT_ERR
-#undef _STR
-#undef STR
-#undef KERNEL_SS
-
-	// Remove test exception handler (and install default one)
-	active_exception_handler = exception_handler;
-
-	return true;
-}

src/kernel.c

@@ -26,14 +26,8 @@ void kmain(void) {
 	log(LL_INFO, "Initilized GDT");
 	init_idt();
 	log(LL_INFO, "Initilized IDT");
-	if (!test_exceptions()) {
-		log(LL_ERR, "IDT tests failed");
-		goto stop;
-	}
-	log(LL_INFO, "IDT tests passed");
-	log(LL_INFO, "Kernel initilization success");
+	log(LL_INFO, "Kernel initilization succeeded");
 
 	// Stop execution
-stop:
 	hcf();
 }