From 7631db709cd98e422a8cc390c47a8e57f08a6a24 Mon Sep 17 00:00:00 2001
From: Adam Alston <aalston9@gmail.com>
Date: Tue, 31 Mar 2026 21:05:16 -0400
Subject: [PATCH] fix: stop greedy processing instruction matching

---
 packages/parser/lib/lexer.js              |  2 +-
 packages/parser/test/parser-smoke-spec.js | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/packages/parser/lib/lexer.js b/packages/parser/lib/lexer.js
index e7e0686e..b792c770 100644
--- a/packages/parser/lib/lexer.js
+++ b/packages/parser/lib/lexer.js
@@ -103,7 +103,7 @@ const INVALID_SLASH_OPEN = createToken({
 
 const PROCESSING_INSTRUCTION = createToken({
   name: "PROCESSING_INSTRUCTION",
-  pattern: makePattern`<\\?${f.Name}.*\\?>`,
+  pattern: makePattern`<\\?${f.Name}.*?\\?>`,
 });
 
 const OPEN = createToken({ name: "OPEN", pattern: /</, push_mode: "INSIDE" });
diff --git a/packages/parser/test/parser-smoke-spec.js b/packages/parser/test/parser-smoke-spec.js
index 4e28b236..374906a7 100644
--- a/packages/parser/test/parser-smoke-spec.js
+++ b/packages/parser/test/parser-smoke-spec.js
@@ -129,4 +129,26 @@ describe("The XML Parser", () => {
     const lexAndParseResult = parse(inputText);
     expect(lexAndParseResult.parseErrors).to.be.empty;
   });
+
+  it("should tokenize processing instructions in sibling elements separately", () => {
+    const inputText =
+      '<list><value id="all"><label>All</label></value><value id="one-one"><?group one?><label>One</label></value><value id="one-two"><?group one?><label>Two</label></value><value id="two-one"><?group two?><label>One</label></value><value id="two-two"><?group two?><label>Two</label></value></list>';
+    const { lexErrors, parseErrors, tokenVector } = parse(inputText);
+    const processingInstructionImages = tokenVector.reduce(
+      (images, token) =>
+        token.tokenType.name === "PROCESSING_INSTRUCTION"
+          ? [...images, token.image]
+          : images,
+      []
+    );
+
+    expect(lexErrors).to.be.empty;
+    expect(parseErrors).to.be.empty;
+    expect(processingInstructionImages).to.deep.equal([
+      "<?group one?>",
+      "<?group one?>",
+      "<?group two?>",
+      "<?group two?>",
+    ]);
+  });
 });