Skip to content

Tests, Scripts, GET impl#117

Merged
jesselanger2 merged 6 commits into
mainfrom
116-write-test-scripts
May 19, 2026
Merged

Tests, Scripts, GET impl#117
jesselanger2 merged 6 commits into
mainfrom
116-write-test-scripts

Conversation

@jesselanger2
Copy link
Copy Markdown
Collaborator

@jesselanger2 jesselanger2 commented May 18, 2026 •
edited
Loading

  • GET impl from single-node to multi-node
  • Nodes now have their own Redis instances
  • More unit tests
  • Test scripts
  • Demo script (with .md file in /docs)

@jesselanger2 jesselanger2 self-assigned this May 18, 2026
@jesselanger2 jesselanger2 linked an issue May 18, 2026 that may be closed by this pull request
Write test scripts #116
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026 •
edited
Loading

Test And Coverage Report

Job status: ✅ success

Test Status

Metric Value Status
Total tests 184 -
Passed 184 ✅
Failed 0 ✅
Errors 0 ✅
Skipped 0 ✅
Total test duration (s) 18.74 -

Coverage Status

Metric Value Status
Instruction coverage 76.62% 🟡
Branch coverage 65.08% ❌
Line coverage 76.80% 🟡

Coverage thresholds: ✅ >= 85%, 🟡 70% to 84.99%, ❌ < 70%

@jesselanger2 jesselanger2 requested a review from a team May 18, 2026 22:55
@jesselanger2 jesselanger2 marked this pull request as ready for review May 18, 2026 22:56
MaxFdev
MaxFdev approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@MaxFdev MaxFdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.
If possible, the new doc could be a bit shorter.

Comment thread docs/demo-cluster-lifecycle.md
Copy link
Copy Markdown
Collaborator

@MaxFdev MaxFdev May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc feels too long. If it can be condensed, that would be great.

@akrakauer akrakauer linked an issue May 19, 2026 that may be closed by this pull request
Change all the files that assume single node functionality to multi node functionality #105
Closed
Base automatically changed from removed-postgres to main May 19, 2026 01:00
akrakauer
akrakauer requested changes May 19, 2026
View reviewed changes
Comment thread src/main/java/edu/yu/capstone/DistributedSecretsVault/service/secret/SecretService.java Outdated
Copy link
Copy Markdown
Collaborator

@akrakauer akrakauer May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were supposed to get rid of this file and move the functionality to the individual crud service files

akrakauer
akrakauer approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@akrakauer akrakauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging. I would've thought that internal crud was just for individual shards, and the service/secret folder would have been doing the reconstruction, but functionality is the same and that's how it was already done for post, put, and delete so we'll keep it like this.

@jesselanger2 jesselanger2 merged commit dabae07 into main May 19, 2026
2 checks passed
@jesselanger2 jesselanger2 deleted the 116-write-test-scripts branch May 19, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxFdev MaxFdev MaxFdev approved these changes

@akrakauer akrakauer akrakauer approved these changes

Assignees

@jesselanger2 jesselanger2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write test scripts Change all the files that assume single node functionality to multi node functionality

3 participants

@jesselanger2 @MaxFdev @akrakauer