style(core): Fixing failing static analysis

Author: TheCelavi

src/RunOpenCode/Bundle/QueryResourcesLoader/Cache/CacheMiddleware.php

@@ -49,7 +49,7 @@ public function __invoke(string $query, Parameters $parameters, Options $options
         $identity = $options->cache instanceof CacheIdentifiableInterface ?
             $options->cache->getCacheIdentity()
             : $options->cache;
-        
+
 
         // ensure TTL is set
         $identity = $identity->withTtl($identity->getTtl() ?? $this->defaultTtl);

src/RunOpenCode/Bundle/QueryResourcesLoader/DependencyInjection/CompilerPass/ConfigureCacheMiddleware.php

@@ -25,7 +25,7 @@ public function process(ContainerBuilder $container): void
         $pool = $container->getParameter(Extension::CACHE_POOL);
         /** @var int|null $ttl */
         $ttl = $container->getParameter(Extension::CACHE_DEFAULT_TTL);
-        
+
         // nothing to reconfigure.
         if (null === $pool && null === $ttl) {
             return;

src/RunOpenCode/Bundle/QueryResourcesLoader/Executor/Dbal/ResultProxy.php

@@ -192,7 +192,7 @@ public function __serialize(): array
         for ($index = 0; $index < $this->columnCount(); ++$index) {
             $columnNames[] = $this->result->getColumnName($index);
         }
-        
+
         // Replace result with array result so this resultset can be reused.
         $this->result = new ArrayResult($columnNames, $rows);
 

tests/Cache/CacheIntegrationTest.php

@@ -4,6 +4,7 @@
 
 namespace RunOpenCode\Bundle\QueryResourcesLoader\Tests\Cache;
 
+use Doctrine\DBAL\Driver\Result;
 use RunOpenCode\Bundle\QueryResourcesLoader\Cache\CacheIdentity;
 use RunOpenCode\Bundle\QueryResourcesLoader\Contract\QueryResourcesLoaderInterface;
 use RunOpenCode\Bundle\QueryResourcesLoader\Model\Options;
@@ -15,8 +16,10 @@ public function testCacheIntegration(): void
     {
         $this->createFixtures();
 
+        /** @var QueryResourcesLoaderInterface $loader */
         $loader = $this->getContainer()->get(QueryResourcesLoaderInterface::class);
-        $data   = $loader->execute('SELECT id, title FROM bar ORDER BY id', null, Options::cached(new CacheIdentity(
+        /** @var Result $resultSet */
+        $resultSet = $loader->execute('SELECT id, title FROM bar ORDER BY id', null, Options::cached(new CacheIdentity(
             'foo',
         )));
 
@@ -26,13 +29,15 @@ public function testCacheIntegration(): void
             ['id' => 3, 'title' => 'Bar title 3'],
             ['id' => 4, 'title' => 'Bar title 4'],
             ['id' => 5, 'title' => 'Bar title 5'],
-        ], $data->fetchAllAssociative());
-        
+        ], $resultSet->fetchAllAssociative());
+
         $this->ensureKernelShutdown();
         $this->bootKernel();
-        
+
+        /** @var QueryResourcesLoaderInterface $loader */
         $loader = $this->getContainer()->get(QueryResourcesLoaderInterface::class);
-        $data   = $loader->execute('SELECT * FROM bar', null, Options::cached(new CacheIdentity(
+        /** @var Result $resultSet */
+        $resultSet = $loader->execute('SELECT * FROM bar', null, Options::cached(new CacheIdentity(
             'foo',
         )));
 
@@ -42,6 +47,6 @@ public function testCacheIntegration(): void
             ['id' => 3, 'title' => 'Bar title 3'],
             ['id' => 4, 'title' => 'Bar title 4'],
             ['id' => 5, 'title' => 'Bar title 5'],
-        ], $data->fetchAllAssociative());
+        ], $resultSet->fetchAllAssociative());
     }
 }

tests/KernelTestCase.php

@@ -30,14 +30,14 @@ protected static function getKernelClass(): string
     {
         return TestKernel::class;
     }
-    
-    protected final function createFixtures(): void
+
+    final protected function createFixtures(): void
     {
         $this->getContainer()->get(Fixtures::class)->execute(); // @phpstan-ignore-line
         $this->clearLoggedQueryStatements();
     }
 
-    protected final function clearLoggedQueryStatements(): void
+    final protected function clearLoggedQueryStatements(): void
     {
         /** @var Configuration $configuration */
         $configuration = $this->getContainer()->get(Connection::class)->getConfiguration(); // @phpstan-ignore-line
@@ -53,7 +53,7 @@ protected final function clearLoggedQueryStatements(): void
     /**
      * @return array<string, string[]>
      */
-    protected final function getLoggedQueryStatements(): array
+    final protected function getLoggedQueryStatements(): array
     {
         /** @var Configuration $configuration */
         $configuration = $this->getContainer()->get(Connection::class)->getConfiguration(); // @phpstan-ignore-line
@@ -80,7 +80,7 @@ protected final function getLoggedQueryStatements(): array
     /**
      * Clear cache for the current test.
      */
-    protected final function clearCache(): void
+    final protected function clearCache(): void
     {
         $booted = self::$booted;
 

tests/Resources/App/TestKernel.php

@@ -14,6 +14,7 @@
 use Symfony\Bundle\MonologBundle\MonologBundle;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symfony\Component\HttpKernel\Kernel;
+
 use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
 
 final class TestKernel extends Kernel
@@ -81,7 +82,7 @@ public function configureContainer(ContainerConfigurator $container): void
                 ],
             ],
         ]);
-        
+
         $container->extension('runopencode_query_resources_loader', [
             'cache' => [
                 'pool' => 'app.roc_test_cache',