Spelling language missing

[gu1ll0me]

My Setup

• My OS name and version: ArchLinux
• My current app version: 1.3.1

fr_FR is missing in the spelling languages menu. So every word I type is underlined in red.

Thanks.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[pyrignis]

I'm also affected, with Ubuntu 16.04. Simply adding the fr_FR.dic & fr_FR.aff in /resources/dictionaries/ is not enough.

[xenithorb]

After you added those dictionaries did you also try LANG=fr_FR.UTF-8 or the equivalent proper environment variable? This could be a clue that it's not actually looking there for the dicts.

[pyrignis]

starting rocket.chat.electron with the following command does not help:
$ ./rocketchat --LANG=fr_FR.UTF-8

[xenithorb]

If anything it would be

export LANG=fr_FR.UTF-8
rocketchat

or

LANG=fr_FR.UTF-8 rocketchat

[pyrignis]

it does not work either. And the command line output only complains about the certificate.json file that I have deleted earlier.

[chkal]

Unfortunately just adding the dictionary files won't work. This is caused by this part of the code:

Rocket.Chat.Electron/app/scripts/preload.js

Lines 197 to 208 in e0a426a

	checker = require('spellchecker');
	availableDictionaries = checker.getAvailableDictionaries();
	if (availableDictionaries.length === 0) {
	dictionariesPath = path.join(remote.app.getAppPath(), '../dictionaries');
	availableDictionaries = [
	'en_US',
	'es_ES',
	'pt_BR'
	];
	}

I did some research and this seems to happen in the code:

• node-spellchecker is loaded via require()
• Then getAvailableDictionaries() is called which will always return an empty array on Linux (see getAvailableDictionaries() returns empty array in ubuntu atom/node-spellchecker#54 and Check system-wide locations for hunspell atom/node-spellchecker#51)
• Now the client falls back to the three dictonaries which are included in the distribution. But the three locales are hard coded in the client (see code linked above)

I see the following ways to fix this:

1. Wait for the upstream issues to get fixed ;-)
2. Remove the hard coded locales and check the contents of the dictionaries folder to determine the locales. This way users can add dictionaries more easily.
3. The same as mentioned in (2) but also check /usr/share/hunspell for dictionaries.

Any thoughts?

Upstream issues:

• getAvailableDictionaries() returns empty array in ubuntu atom/node-spellchecker#54
• Check system-wide locations for hunspell atom/node-spellchecker#51

[xenithorb]

Hmm, a possible clue as to why I can't get spellchecking to work in Fedora:

$ rpm -ql hunspell-en-US
/usr/share/doc/hunspell-en-US
/usr/share/doc/hunspell-en-US/README_en_US.txt
/usr/share/myspell/en_US.aff
/usr/share/myspell/en_US.dic

I don't have a deep understanding of how the spellchecking works, but I am eager to get it working on Fedora for my package. Thanks for the input!

[DemonTPx]

I've fixed this in node-spellchecker, but the PR is still open.

See: atom/node-spellchecker#69

It that is merged, the spellchecker will search for dictionaries installed globally on the system.

[chkal]

That's awesome. Thank you so much.

[idl0r]

Any news on this issue?

[etopit]

+1

[xucong-zhang]

+1