This repository was archived by the owner on Jun 6, 2023. It is now read-only.
Applied some recommendations from official documentation#33
Open
valentim wants to merge 1 commit into
Open
Conversation
…uch as comments above the exported methods and the defer statement to close client connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much! I learned through your source code.
This PR is a simple one done only to improve the source code with some official suggestion that I had learnt from documentation.
Technically I did minor changes:
1 - I included the defer inside the Send method to ensure that the connection be closed
2 - I included some short comments above the exported methods