Skip to content

Thoughts about this library #2

@HansKindberg

Description

@HansKindberg

Have tried to create a new version of this library, 0.4.0-alpha, with a NuGet-reference update to RegionOrebroLan.Web.Authentication 0.8.0-alpha. But I cant do it.

RegionOrebroLan.Web.Authentication 0.8.0-alpha references ActiveLogin.Identity.Swedish 3.0.0 which has a major change. ActiveLogin.Identity.Swedish 3.0.0 has a type rename, SwedishPersonalIdentityNumber to PersonalIdentityNumber.

In this library we reference:

  • ActiveLogin.Authentication.BankId.AspNetCore 4.0.0
  • ActiveLogin.Authentication.BankId.AspNetCore.QRCoder 4.0.0
  • ActiveLogin.Authentication.GrandId.AspNetCore 4.0.0

and they reference

  • ActiveLogin.Identity.Swedish 2.0.2

So when we run the sample in this repository after updating the RegionOrebroLan.Web.Authentication reference to 0.8.0-alpha the ActiveLogin BankId/GrandId packages throws an exception because the type "SwedishPersonalIdentityNumber" can not be found.

System.Reflection.ReflectionTypeLoadException: 'Unable to load one or more of the requested types. Could not load type 'ActiveLogin.Identity.Swedish.SwedishPersonalIdentityNumber' from assembly 'ActiveLogin.Identity.Swedish, Version=3.0.0.0, Culture=neutral, PublicKeyToken=318133f575cb57dc'.'

This library is a multi-target library,

<TargetFrameworksnet>6.0;net5.0;netcoreapp3.1</TargetFrameworks>

And we would like to keep it that way. We can not update the ActiveLogin library references because then we have to remove the support for netcoreapp3.1. The ActiveLogin libraries are not multi-targeted.

For us it would have been nice if the ActiveLogin libraries also would have been multi-target libraries. But that is not up to us to decide.

So the "conclusion" is:
Maybe we should "leave" this library. It has not "super" much functionality. When we need the functionality in an application maybe we have to implement it directly in it. Keeping this repository as an example.

Metadata

Metadata

Assignees

Labels

questionFurther information is requested

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions