fix(hip): support TheRock ROCm 7.x in compatibility matrix#238
Merged
demandal25 merged 4 commits intoMay 20, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Updates ROCm/HIP version detection and the ROCm-arch compatibility mapping so import flashinfer works on TheRock ROCm 7.11–7.13 nightly builds, where hipconfig reports 7.13.x-style versions.
Changes:
- Relax hipconfig version parsing to accept
major.minorormajor.minor.patch. - Document why TheRock uses hipconfig (HIP runtime version) over
.info/version(SDK version). - Extend the ROCm compatibility matrix keys to include
7.11,7.12,7.13.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Debasis Mandal <Debasis.Mandal@amd.com>
demandal25
approved these changes
May 20, 2026
Collaborator
demandal25
left a comment
demandal25
left a comment
There was a problem hiding this comment.
Thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Fix
import flashinferfailure on TheRock ROCm 7.13 nightly builds:RuntimeError: ROCm version 7.13.26183 is not recognized in the ROCm compatibility matrix.TheRock nightly builds report HIP version
7.13.xvia hipconfig. The_ROCM_ARCH_GROUPSmatrix only covered7.0–7.3, so the key"7.13"returned empty and triggered the hard error.Changes to
flashinfer/hip_utils.py:"7.11","7.12","7.13"to_ROCM_ARCH_GROUPS. Arch list verified across TheRock git tagstherock-7.11,therock-7.12,therock-7.13.(\d+\.\d+(?:\.\d+)?)— handles potentialmajor.minor-only output.get_system_rocm_versiondocstring: document why hipconfig is preferred over.info/versionfor TheRock. hipconfig reports the HIP runtime version (consistent withtorch.version.hip);.info/versionreports the TheRock SDK version, which differs (e.g. TheRock 7.12 has SDK 7.12 but HIP 7.3).🔍 Related Issues
N/A
🚀 Pull Request Checklist
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --files flashinfer/hip_utils.pyand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Verified on a TheRock ROCm 7.13 nightly container:
import flashinfersucceeds after the fix. No new tests added — the fix is in version detection logic with no kernel changes.