Workaround custom_all_reduce issue (By Chengzhe Fan @zx3xyy)#3290
Open
zjing14 wants to merge 1 commit into
Open
Workaround custom_all_reduce issue (By Chengzhe Fan @zx3xyy)#3290zjing14 wants to merge 1 commit into
zjing14 wants to merge 1 commit into
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the issue is identified and the fix is implemented by Chengzhe Fan @zx3xyy
Issue: Crash with custom all-reduce + CUDA graph enabled (ROCm / Aiter)
Root Cause Hypothesis: In Aiter's ROCm registered-input CUDA graph custom all-reduce path, a GPU can signal "ready" and peers begin reading the output buffer before the producer kernel's memory writes are globally visible across the PCIe/xGMI fabric.
Workaround: Insert a system-scope memory fence (e.g.,
__threadfence_system()or equivalent ROCm barrier) before the readiness signal, ensuring all prior stores from producer kernels within the CUDA graph are visible to peer GPUs before any consumer on another GPU reads the buffer.