Fix flaky dropout tests#3289
Open
micmelesse wants to merge 1 commit into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate flakiness in dropout-related FlashAttention backward paths by removing tl.where usage in dropout masking (reported to miscompile) and replacing it with equivalent mask-multiply logic in Triton kernels.
Changes:
- Replaced
tl.where(dropout_mask, x, 0.0) * dropout_scalewithx * dropout_mask.to(x.dtype) * dropout_scalein multiple backward inner loops. - Applied the change consistently across split-k and atomic variants of the backward kernels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
f4f7379 to
22928ce
Compare
22928ce to
a915762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pr fixes a few flaky tests that have been failing on main due to mis-compilation of
tl.where. Thetl.wherecalls are replaced with semantically equivalent code.Technical Details
Test Plan
I tested locally on an MI350 machine.
Test Result
Submission Checklist