add error info to indicate no sliding window for triton backward pass#3158
add error info to indicate no sliding window for triton backward pass#3158scxiao wants to merge 1 commit into
Conversation
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
brunomazzottiamd
left a comment
There was a problem hiding this comment.
LGTM!
The failures in tests/test_flash_attn_triton_amd.py::test_flash_attn_varlen_output test, that's part of Flash Attention - Triton / MI35X (1 GPU) test job, were addressed in #2695. IMHO it isn't a blocker for merging.
|
Let us wait for #2695 to get merged and then we can merge this |
|
@scxiao Can you rebase this pr? |
19c9a86 to
a3face4
Compare
Thanks. Done. |
|
@micmelesse, we have a Flash Attention Integration UT failure in this PR (on MI350): It's an assertion error on |
|
@brunomazzottiamd I saw that. I am retrying the job. I am also working on this pr that should address these flaky dropout tests #3289 |
Motivation
We tried to run flash attention sliding window case, triton implementation does not support that, but no error info is reported, which generate incorrect results. The sliding window input is ignored.
Technical Details
Added an error message to tell users for that.
Test Plan
There are existing tests
Test Result
passes
Submission Checklist