Skip to content

Commit 4e39b32

Browse files
committed
fix: return flightinfo for all alter commands
1 parent f9f4055 commit 4e39b32

1 file changed

Lines changed: 66 additions & 22 deletions

File tree

src/query_farm_server_base/server.py

Lines changed: 66 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,25 @@ def __init__(
140140
False,
141141
),
142142
ActionType.ADD_CONSTRAINT: ActionHandlerSpec(
143-
self.action_add_constraint, action_decoders.add_constraint
143+
self.action_add_constraint,
144+
action_decoders.add_constraint,
145+
lambda x: x.serialize(),
146+
False,
147+
False,
144148
),
145149
ActionType.ADD_FIELD: ActionHandlerSpec(
146-
self.action_add_field, action_decoders.add_field
150+
self.action_add_field,
151+
action_decoders.add_field,
152+
lambda x: x.serialize(),
153+
False,
154+
False,
147155
),
148156
ActionType.CHANGE_COLUMN_TYPE: ActionHandlerSpec(
149-
self.action_change_column_type, action_decoders.change_column_type
157+
self.action_change_column_type,
158+
action_decoders.change_column_type,
159+
lambda x: x.serialize(),
160+
False,
161+
False,
150162
),
151163
ActionType.CREATE_SCHEMA: ActionHandlerSpec(
152164
self.action_create_schema,
@@ -155,7 +167,11 @@ def __init__(
155167
False,
156168
),
157169
ActionType.DROP_NOT_NULL: ActionHandlerSpec(
158-
self.action_drop_not_null, action_decoders.drop_not_null
170+
self.action_drop_not_null,
171+
action_decoders.drop_not_null,
172+
lambda x: x.serialize(),
173+
False,
174+
False,
159175
),
160176
ActionType.DROP_TABLE: ActionHandlerSpec(
161177
self.action_drop_table, action_decoders.drop_table
@@ -164,25 +180,53 @@ def __init__(
164180
self.action_drop_schema, action_decoders.drop_schema
165181
),
166182
ActionType.REMOVE_COLUMN: ActionHandlerSpec(
167-
self.action_remove_column, action_decoders.remove_column
183+
self.action_remove_column,
184+
action_decoders.remove_column,
185+
lambda x: x.serialize(),
186+
False,
187+
False,
168188
),
169189
ActionType.REMOVE_FIELD: ActionHandlerSpec(
170-
self.action_remove_field, action_decoders.remove_field
190+
self.action_remove_field,
191+
action_decoders.remove_field,
192+
lambda x: x.serialize(),
193+
False,
194+
False,
171195
),
172196
ActionType.RENAME_COLUMN: ActionHandlerSpec(
173-
self.action_rename_column, action_decoders.rename_column
197+
self.action_rename_column,
198+
action_decoders.rename_column,
199+
lambda x: x.serialize(),
200+
False,
201+
False,
174202
),
175203
ActionType.RENAME_FIELD: ActionHandlerSpec(
176-
self.action_rename_field, action_decoders.rename_field
204+
self.action_rename_field,
205+
action_decoders.rename_field,
206+
lambda x: x.serialize(),
207+
False,
208+
False,
177209
),
178210
ActionType.RENAME_TABLE: ActionHandlerSpec(
179-
self.action_rename_table, action_decoders.rename_table
211+
self.action_rename_table,
212+
action_decoders.rename_table,
213+
lambda x: x.serialize(),
214+
False,
215+
False,
180216
),
181217
ActionType.SET_DEFAULT: ActionHandlerSpec(
182-
self.action_set_default, action_decoders.set_default
218+
self.action_set_default,
219+
action_decoders.set_default,
220+
lambda x: x.serialize(),
221+
False,
222+
False,
183223
),
184224
ActionType.SET_NOT_NULL: ActionHandlerSpec(
185-
self.action_set_not_null, action_decoders.set_not_null
225+
self.action_set_not_null,
226+
action_decoders.set_not_null,
227+
lambda x: x.serialize(),
228+
False,
229+
False,
186230
),
187231
ActionType.COLUMN_STATISTICS: ActionHandlerSpec(
188232
self.action_column_statistics, action_decoders.column_statistics, None, False
@@ -354,23 +398,23 @@ def action_add_constraint(
354398
*,
355399
context: CallContext[AccountType, TokenType],
356400
parameters: action_decoders.AddConstraintParameters,
357-
) -> None:
401+
) -> flight.FlightInfo:
358402
self._unimplemented_action(ActionType.ADD_CONSTRAINT)
359403

360404
def action_add_field(
361405
self,
362406
*,
363407
context: CallContext[AccountType, TokenType],
364408
parameters: action_decoders.AddFieldParameters,
365-
) -> None:
409+
) -> flight.FlightInfo:
366410
self._unimplemented_action(ActionType.ADD_FIELD)
367411

368412
def action_change_column_type(
369413
self,
370414
*,
371415
context: CallContext[AccountType, TokenType],
372416
parameters: action_decoders.ChangeColumnTypeParameters,
373-
) -> None:
417+
) -> flight.FlightInfo:
374418
self._unimplemented_action(ActionType.CHANGE_COLUMN_TYPE)
375419

376420
# FIXME: build a type for the column statistics, or switch over
@@ -389,7 +433,7 @@ def action_drop_not_null(
389433
*,
390434
context: CallContext[AccountType, TokenType],
391435
parameters: action_decoders.DropNotNullParameters,
392-
) -> None:
436+
) -> flight.FlightInfo:
393437
self._unimplemented_action(ActionType.DROP_NOT_NULL)
394438

395439
def action_drop_table(
@@ -421,55 +465,55 @@ def action_remove_column(
421465
*,
422466
context: CallContext[AccountType, TokenType],
423467
parameters: action_decoders.RemoveColumnParameters,
424-
) -> None:
468+
) -> flight.FlightInfo:
425469
self._unimplemented_action(ActionType.REMOVE_COLUMN)
426470

427471
def action_remove_field(
428472
self,
429473
*,
430474
context: CallContext[AccountType, TokenType],
431475
parameters: action_decoders.RemoveFieldParameters,
432-
) -> None:
476+
) -> flight.FlightInfo:
433477
self._unimplemented_action(ActionType.REMOVE_FIELD)
434478

435479
def action_rename_column(
436480
self,
437481
*,
438482
context: CallContext[AccountType, TokenType],
439483
parameters: action_decoders.RenameColumnParameters,
440-
) -> None:
484+
) -> flight.FlightInfo:
441485
self._unimplemented_action(ActionType.RENAME_COLUMN)
442486

443487
def action_rename_field(
444488
self,
445489
*,
446490
context: CallContext[AccountType, TokenType],
447491
parameters: action_decoders.RenameFieldParameters,
448-
) -> None:
492+
) -> flight.FlightInfo:
449493
self._unimplemented_action(ActionType.RENAME_FIELD)
450494

451495
def action_rename_table(
452496
self,
453497
*,
454498
context: CallContext[AccountType, TokenType],
455499
parameters: action_decoders.RenameTableParameters,
456-
) -> None:
500+
) -> flight.FlightInfo:
457501
self._unimplemented_action(ActionType.RENAME_TABLE)
458502

459503
def action_set_default(
460504
self,
461505
*,
462506
context: CallContext[AccountType, TokenType],
463507
parameters: action_decoders.SetDefaultParameters,
464-
) -> None:
508+
) -> flight.FlightInfo:
465509
self._unimplemented_action(ActionType.SET_DEFAULT)
466510

467511
def action_set_not_null(
468512
self,
469513
*,
470514
context: CallContext[AccountType, TokenType],
471515
parameters: action_decoders.SetNotNullParameters,
472-
) -> None:
516+
) -> flight.FlightInfo:
473517
self._unimplemented_action(ActionType.SET_NOT_NULL)
474518

475519
def action_table_function_flight_info(

0 commit comments

Comments
 (0)