Skip to content

Commit 66fcb83

Browse files
lboueLuliguclaude
authored
fix: use YXCleanType for Q10Status.clean_mode instead of YXDeviceWorkMode (#810)
* fix: use YXCleanType for Q10Status.clean_mode instead of YXDeviceWorkMode DPS 137 (CLEAN_MODE) reports clean type values (1=vac+mop, 2=vacuum, 3=mop) which map to YXCleanType, not YXDeviceWorkMode. * test: assert clean_mode maps DPS 137 to YXCleanType in status refresh test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Ludovic BOUÉ <132135057+lboue@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent e1f3cb8 commit 66fcb83

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

roborock/data/b01_q10/b01_q10_containers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
from .b01_q10_code_mappings import (
1313
B01_Q10_DP,
1414
YXBackType,
15+
YXCleanType,
1516
YXDeviceCleanTask,
1617
YXDeviceState,
17-
YXDeviceWorkMode,
1818
YXFanLevel,
1919
YXWaterLevel,
2020
)
@@ -103,7 +103,7 @@ class Q10Status(RoborockBase):
103103
side_brush_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.SIDE_BRUSH_LIFE})
104104
filter_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.FILTER_LIFE})
105105
sensor_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.SENSOR_LIFE})
106-
clean_mode: YXDeviceWorkMode | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_MODE})
106+
clean_mode: YXCleanType | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_MODE})
107107
clean_task_type: YXDeviceCleanTask | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_TASK_TYPE})
108108
back_type: YXBackType | None = field(default=None, metadata={"dps": B01_Q10_DP.BACK_TYPE})
109109
cleaning_progress: int | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_PROGRESS})

tests/devices/traits/b01/q10/test_status.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
from roborock.data.b01_q10.b01_q10_code_mappings import (
1313
B01_Q10_DP,
14+
YXCleanType,
1415
YXDeviceCleanTask,
1516
YXDeviceState,
1617
YXFanLevel,
@@ -153,6 +154,7 @@ async def test_status_trait_refresh(
153154
assert q10_api.status.sensor_life == 0
154155
assert q10_api.status.cleaning_progress == 100
155156
assert q10_api.status.fault == 0
157+
assert q10_api.status.clean_mode == YXCleanType.VAC_AND_MOP
156158

157159

158160
def test_status_trait_update_listener(q10_api: Q10PropertiesApi) -> None:

0 commit comments

Comments
 (0)