Skip to content

CL block names should be symbols not arbitrary sexps #873

@monnier

Description

@monnier

The syntax looks like (cl-block foo ...).
The patch below fixes one place where the author seems to have confused it with the catch/throw where the argument is evaluated.

diff --git a/generic/pg-pbrpm.el b/generic/pg-pbrpm.el
index 6ec57266dc..b80a1827e5 100644
--- a/generic/pg-pbrpm.el
+++ b/generic/pg-pbrpm.el
@@ -422,14 +422,14 @@ If no match found, return the empty string."
   (save-excursion
     (let ((pos (point)))
       (beginning-of-line)
-      (cl-block 'loop
+      (cl-block loop
 	(while (< (point) pos)
 	  (unless (search-forward-regexp pg-pbrpm-auto-select-regexp nil t)
-	    (cl-return-from 'loop ""))
+	    (cl-return-from loop ""))
 	  (if (and (<= (match-beginning 0) pos)
 		   (<= pos (match-end 0)))
-	      (cl-return-from 'loop (match-string 0))))
-	(cl-return-from 'loop "")))))
+	      (cl-return-from loop (match-string 0))))
+	(cl-return-from loop "")))))
 
 (defun pg-pbrpm-translate-position (buffer pos)
   "If BUFFER is goals-buffer, return POS, otherwise the point in the goal buffer."

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions