TTS Evaluation: TTS Results signed URLs (#666)

Author: AkhileshNegi

backend/app/api/routes/stt_evaluations/dataset.py

@@ -10,9 +10,9 @@
 from app.crud.file import get_files_by_ids
 from app.crud.language import get_language_by_id
 from app.crud.stt_evaluations import (
+    get_samples_by_dataset_id,
     get_stt_dataset_by_id,
     list_stt_datasets,
-    get_samples_by_dataset_id,
 )
 from app.models.stt_evaluation import (
     STTDatasetCreate,
@@ -168,15 +168,10 @@ def get_dataset(
         samples = []
         for s in sample_records:
             signed_url = None
-            if include_signed_url and storage and s.file_id in file_map:
-                try:
-                    signed_url = storage.get_signed_url(
-                        file_map.get(s.file_id).object_store_url
-                    )
-                except Exception as e:
-                    logger.warning(
-                        f"[get_dataset] Failed to generate signed URL for file_id {s.file_id}: {e}"
-                    )
+            if storage and s.file_id in file_map:
+                signed_url = storage.get_signed_url(
+                    file_map[s.file_id].object_store_url
+                )
 
             samples.append(
                 STTSamplePublic(

backend/app/api/routes/tts_evaluations/evaluation.py

@@ -8,6 +8,7 @@
 from app.api.deps import AuthContextDep, SessionDep
 from app.api.permissions import Permission, require_permission
 from app.celery.utils import start_low_priority_job
+from app.core.cloud import get_cloud_storage
 from app.crud.tts_evaluations import (
     create_tts_run,
     get_results_by_run_id,
@@ -169,6 +170,9 @@ def get_tts_evaluation_run(
     auth_context: AuthContextDep,
     run_id: int,
     include_results: bool = Query(True, description="Include results in response"),
+    include_signed_url: bool = Query(
+        False, description="Include signed URLs for generated audio files"
+    ),
 ) -> APIResponse[TTSEvaluationRunWithResults]:
     """Get a TTS evaluation run with results."""
     run = get_tts_run_by_id(
@@ -185,11 +189,18 @@ def get_tts_evaluation_run(
     results_total = 0
 
     if include_results:
+        storage = None
+        if include_signed_url:
+            storage = get_cloud_storage(
+                session=session, project_id=auth_context.project_.id
+            )
+
         results, results_total = get_results_by_run_id(
             session=session,
             run_id=run_id,
             org_id=auth_context.organization_.id,
             project_id=auth_context.project_.id,
+            storage=storage,
         )
 
     return APIResponse.success_response(

backend/app/api/routes/tts_evaluations/result.py

@@ -2,10 +2,11 @@
 
 import logging
 
-from fastapi import APIRouter, Body, Depends, HTTPException
+from fastapi import APIRouter, Body, Depends, HTTPException, Query
 
 from app.api.deps import AuthContextDep, SessionDep
 from app.api.permissions import Permission, require_permission
+from app.core.cloud import get_cloud_storage
 from app.crud.tts_evaluations import (
     get_tts_result_by_id,
     update_tts_human_feedback,
@@ -92,6 +93,9 @@ def get_result(
     session: SessionDep,
     auth_context: AuthContextDep,
     result_id: int,
+    include_signed_url: bool = Query(
+        False, description="Include signed URL for generated audio file"
+    ),
 ) -> APIResponse[TTSResultPublic]:
     """Get a TTS result by ID."""
     result = get_tts_result_by_id(
@@ -104,4 +108,13 @@ def get_result(
     if not result:
         raise HTTPException(status_code=404, detail="Result not found")
 
-    return APIResponse.success_response(data=TTSResultPublic.from_model(result))
+    signed_url = None
+    if include_signed_url and result.object_store_url is not None:
+        storage = get_cloud_storage(
+            session=session, project_id=auth_context.project_.id
+        )
+        signed_url = storage.get_signed_url(result.object_store_url)
+
+    return APIResponse.success_response(
+        data=TTSResultPublic.from_model(result, signed_url=signed_url)
+    )

backend/app/crud/stt_evaluations/result.py

@@ -2,17 +2,17 @@
 
 import logging
 
-from sqlmodel import Session, select, func
+from sqlmodel import Session, func, select
 
+from app.core.cloud.storage import CloudStorage
 from app.core.exception_handlers import HTTPException
 from app.core.util import now
 from app.models.file import File
-from app.core.cloud.storage import CloudStorage
 from app.models.stt_evaluation import (
     STTResult,
+    STTResultWithSample,
     STTSample,
     STTSamplePublic,
-    STTResultWithSample,
 )
 
 logger = logging.getLogger(__name__)
@@ -103,14 +103,7 @@ def get_results_by_run_id(
     # Convert to response models
     results = []
     for result, sample, file in rows:
-        signed_url = None
-        if storage:
-            try:
-                signed_url = storage.get_signed_url(file.object_store_url)
-            except Exception as e:
-                logger.warning(
-                    f"[get_results_by_run_id] Failed to generate signed URL: {e}"
-                )
+        signed_url = storage.get_signed_url(file.object_store_url) if storage else None
 
         sample_public = STTSamplePublic(
             id=sample.id,
@@ -226,4 +219,4 @@ def count_results_by_status(
 
     rows = session.exec(statement).all()
 
-    return {status: count for status, count in rows}
+    return dict(rows)

backend/app/crud/tts_evaluations/cron.py

@@ -13,8 +13,6 @@
 
 from sqlmodel import Session
 
-from app.models.batch_job import BatchJobType
-
 from app.celery.utils import start_low_priority_job
 from app.core.batch import GeminiBatchProvider
 from app.crud.evaluations.cron_utils import (
@@ -29,7 +27,7 @@
 )
 from app.crud.tts_evaluations.run import update_tts_run
 from app.models import EvaluationRun
-from app.models.batch_job import BatchJob
+from app.models.batch_job import BatchJob, BatchJobType
 from app.models.job import JobStatus
 from app.models.stt_evaluation import EvaluationType
 
@@ -151,7 +149,9 @@ async def _on_batch_succeeded(batch_job: BatchJob, provider_name: str) -> bool:
         return True
 
     async def _on_already_succeeded(batch_job: BatchJob, provider_name: str) -> bool:
-        pending = get_pending_results_for_run(session, run.id, provider_name)
+        pending = get_pending_results_for_run(
+            session=session, run_id=run.id, provider=provider_name
+        )
         if pending:
             logger.info(
                 f"{log_prefix} Dispatching reprocessing for "

backend/app/crud/tts_evaluations/result.py

@@ -5,6 +5,7 @@
 
 from sqlmodel import Session, func, select
 
+from app.core.cloud.storage import CloudStorage
 from app.core.exception_handlers import HTTPException
 from app.core.util import now
 from app.models.job import JobStatus
@@ -104,6 +105,7 @@ def get_results_by_run_id(
     run_id: int,
     org_id: int,
     project_id: int,
+    storage: CloudStorage | None = None,
 ) -> tuple[list[TTSResultPublic], int]:
     """Get all results for an evaluation run.
 
@@ -112,6 +114,7 @@ def get_results_by_run_id(
         run_id: Run ID
         org_id: Organization ID
         project_id: Project ID
+        storage: Optional cloud storage instance for generating signed URLs
 
     Returns:
         tuple[list[TTSResultPublic], int]: Results and total count
@@ -127,7 +130,12 @@ def get_results_by_run_id(
     rows = session.exec(statement).all()
     total = len(rows)
 
-    results = [TTSResultPublic.from_model(result) for result in rows]
+    results = []
+    for result in rows:
+        signed_url = (
+            storage.get_signed_url(result.object_store_url) if storage else None
+        )
+        results.append(TTSResultPublic.from_model(result, signed_url=signed_url))
 
     return results, total
 
@@ -294,4 +302,4 @@ def count_results_by_status(
 
     rows = session.exec(statement).all()
 
-    return {status: count for status, count in rows}
+    return dict(rows)

backend/app/models/tts_evaluation.py

@@ -209,6 +209,7 @@ class TTSResultPublic(BaseModel):
     id: int
     sample_text: str
     object_store_url: str | None
+    signed_url: str | None = None
     duration_seconds: float | None = None
     size_bytes: int | None = None
     provider: str
@@ -224,12 +225,18 @@ class TTSResultPublic(BaseModel):
     updated_at: datetime
 
     @classmethod
-    def from_model(cls, result: TTSResult) -> TTSResultPublic:
+    def from_model(
+        cls,
+        result: TTSResult,
+        *,
+        signed_url: str | None = None,
+    ) -> TTSResultPublic:
         """Create from a TTSResult model instance."""
         return cls(
             id=result.id,
             sample_text=result.sample_text,
             object_store_url=result.object_store_url,
+            signed_url=signed_url,
             duration_seconds=(result.metadata_ or {}).get("duration_seconds"),
             size_bytes=(result.metadata_ or {}).get("size_bytes"),
             provider=result.provider,

backend/app/tests/api/routes/test_stt_evaluation.py

@@ -1,14 +1,14 @@
-import pytest
 from unittest.mock import MagicMock, patch
 
+import pytest
 from fastapi.testclient import TestClient
 from sqlmodel import Session
 
-from app.models import EvaluationDataset, EvaluationRun, File, FileType
-from app.models.stt_evaluation import STTSample, STTResult, EvaluationType
+from app.core.util import now
 from app.crud.language import get_language_by_locale
+from app.models import EvaluationDataset, EvaluationRun, File, FileType
+from app.models.stt_evaluation import EvaluationType, STTResult, STTSample
 from app.tests.utils.auth import TestAuthContext
-from app.core.util import now
 
 
 # Helper functions
@@ -741,9 +741,7 @@ def test_get_stt_dataset_signed_url_failure(
         """Test getting an STT dataset when signed URL generation fails."""
         # Mock cloud storage to raise an exception
         mock_storage = MagicMock()
-        mock_storage.get_signed_url.side_effect = Exception(
-            "Failed to generate signed URL"
-        )
+        mock_storage.get_signed_url.return_value = None
         mock_get_cloud_storage.return_value = mock_storage
 
         dataset = create_test_stt_dataset(
@@ -1076,9 +1074,7 @@ def test_get_stt_run_signed_url_failure(
         """Test getting an STT run when signed URL generation fails."""
         # Mock cloud storage to raise an exception
         mock_storage = MagicMock()
-        mock_storage.get_signed_url.side_effect = Exception(
-            "Failed to generate signed URL"
-        )
+        mock_storage.get_signed_url.return_value = None
         mock_get_cloud_storage.return_value = mock_storage
 
         # Create dataset, sample, run, and result
@@ -1278,7 +1274,7 @@ def test_list_audio_files_with_signed_urls(
         mock_get_cloud_storage.return_value = mock_storage
 
         # Create test file
-        file = create_test_file(
+        _file = create_test_file(
             db=db,
             organization_id=user_api_key.organization_id,
             project_id=user_api_key.project_id,
@@ -1314,7 +1310,7 @@ def test_list_audio_files_without_signed_urls(
     ) -> None:
         """Test listing audio files without signed URLs."""
         # Create test file
-        file = create_test_file(
+        _file = create_test_file(
             db=db,
             organization_id=user_api_key.organization_id,
             project_id=user_api_key.project_id,
@@ -1345,7 +1341,7 @@ def test_list_audio_files_project_isolation(
     ) -> None:
         """Test that audio files are isolated by project."""
         # Create file in user's project
-        user_file = create_test_file(
+        _user_file = create_test_file(
             db=db,
             organization_id=user_api_key.organization_id,
             project_id=user_api_key.project_id,