feat: add /good, /bad, and /feedback slash commands (#896)

Author: andrewm4894

apps/twig/src/renderer/features/message-editor/suggestions/getSuggestions.ts

@@ -5,6 +5,24 @@ import Fuse, { type IFuseOptions } from "fuse.js";
 import { useDraftStore } from "../stores/draftStore";
 import type { CommandSuggestionItem, FileSuggestionItem } from "../types";
 
+const TWIG_COMMANDS: AvailableCommand[] = [
+  {
+    name: "good",
+    description: "Capture positive feedback",
+    input: { hint: "optional comment" },
+  },
+  {
+    name: "bad",
+    description: "Capture negative feedback",
+    input: { hint: "optional comment" },
+  },
+  {
+    name: "feedback",
+    description: "Capture general feedback",
+    input: { hint: "optional comment" },
+  },
+];
+
 const COMMAND_LIMIT = 5;
 
 const COMMAND_FUSE_OPTIONS: IFuseOptions<AvailableCommand> = {
@@ -67,7 +85,7 @@ export function getCommandSuggestions(
   query: string,
 ): CommandSuggestionItem[] {
   const taskId = useDraftStore.getState().contexts[sessionId]?.taskId;
-  const commands = getAvailableCommandsForTask(taskId);
+  const commands = [...TWIG_COMMANDS, ...getAvailableCommandsForTask(taskId)];
   const filtered = searchCommands(commands, query);
 
   return filtered.map((cmd) => ({

apps/twig/src/renderer/features/task-detail/components/TaskLogsPanel.tsx

@@ -13,12 +13,14 @@ import { useDeleteTask } from "@features/tasks/hooks/useTasks";
 import { useWorkspaceStore } from "@features/workspace/stores/workspaceStore";
 import { useConnectivity } from "@hooks/useConnectivity";
 import { Box } from "@radix-ui/themes";
+import { track } from "@renderer/lib/analytics";
 import { logger } from "@renderer/lib/logger";
 import { useNavigationStore } from "@renderer/stores/navigationStore";
 import { trpcVanilla } from "@renderer/trpc/client";
 import type { Task } from "@shared/types";
 import { toast } from "@utils/toast";
 import { useCallback, useEffect, useRef } from "react";
+import { ANALYTICS_EVENTS, type FeedbackType } from "@/types/analytics";
 
 const log = logger.scope("task-logs-panel");
 
@@ -108,6 +110,30 @@ export function TaskLogsPanel({ taskId, task }: TaskLogsPanelProps) {
 
   const handleSendPrompt = useCallback(
     async (text: string) => {
+      const feedbackMatch = text.match(/^\/(good|bad|feedback)(?:\s+(.*))?$/);
+      if (feedbackMatch) {
+        const rawType = feedbackMatch[1];
+        const feedbackType: FeedbackType =
+          rawType === "feedback" ? "general" : (rawType as FeedbackType);
+        const comment = feedbackMatch[2]?.trim() || undefined;
+        track(ANALYTICS_EVENTS.TASK_FEEDBACK, {
+          task_id: taskId,
+          task_run_id: session?.taskRunId ?? task.latest_run?.id,
+          log_url: session?.logUrl ?? task.latest_run?.log_url,
+          event_count: events.length,
+          feedback_type: feedbackType,
+          feedback_comment: comment,
+        });
+        const label =
+          feedbackType === "good"
+            ? "Positive"
+            : feedbackType === "bad"
+              ? "Negative"
+              : "General";
+        toast.success(`${label} feedback captured`);
+        return;
+      }
+
       try {
         markAsViewed(taskId);
 
@@ -129,7 +155,16 @@ export function TaskLogsPanel({ taskId, task }: TaskLogsPanelProps) {
         log.error("Failed to send prompt", error);
       }
     },
-    [taskId, markActivity, markAsViewed],
+    [
+      taskId,
+      markActivity,
+      markAsViewed,
+      events.length,
+      session?.logUrl,
+      session?.taskRunId,
+      task.latest_run?.id,
+      task.latest_run?.log_url,
+    ],
   );
 
   const handleCancelPrompt = useCallback(async () => {

apps/twig/src/types/analytics.ts

@@ -11,6 +11,7 @@ export type GitActionType =
   | "publish"
   | "commit-push"
   | "create-pr";
+export type FeedbackType = "good" | "bad" | "general";
 export type FileOpenSource = "sidebar" | "agent-suggestion" | "search" | "diff";
 export type FileChangeType = "added" | "modified" | "deleted";
 export type StopReason = "user_cancelled" | "completed" | "error" | "timeout";
@@ -157,6 +158,16 @@ export interface FirstTaskCompletedProperties {
   duration_seconds: number;
 }
 
+// Feedback events
+export interface TaskFeedbackProperties {
+  task_id: string;
+  task_run_id?: string;
+  log_url?: string;
+  event_count: number;
+  feedback_type: FeedbackType;
+  feedback_comment?: string;
+}
+
 // Event names as constants
 export const ANALYTICS_EVENTS = {
   // App lifecycle
@@ -201,6 +212,9 @@ export const ANALYTICS_EVENTS = {
   // Settings events
   SETTING_CHANGED: "Setting changed",
 
+  // Feedback events
+  TASK_FEEDBACK: "Task feedback",
+
   // Error events
   TASK_CREATION_FAILED: "Task creation failed",
   AGENT_SESSION_ERROR: "Agent session error",
@@ -246,6 +260,9 @@ export type EventPropertyMap = {
   // Settings events
   [ANALYTICS_EVENTS.SETTING_CHANGED]: SettingChangedProperties;
 
+  // Feedback events
+  [ANALYTICS_EVENTS.TASK_FEEDBACK]: TaskFeedbackProperties;
+
   // Error events
   [ANALYTICS_EVENTS.TASK_CREATION_FAILED]: TaskCreationFailedProperties;
   [ANALYTICS_EVENTS.AGENT_SESSION_ERROR]: AgentSessionErrorProperties;