Remove dev-only timing instrumentation

Author: charlesvien

apps/twig/src/main/lib/timing.ts

@@ -45,8 +45,6 @@ export const startSessionInput = z.object({
   runMode: z.enum(["local", "cloud"]).optional(),
   adapter: z.enum(["claude", "codex"]).optional(),
   additionalDirectories: z.array(z.string()).optional(),
-  /** Dev-only: timestamp from renderer when user submitted the task */
-  submittedAt: z.number().optional(),
 });
 
 export type StartSessionInput = z.infer<typeof startSessionInput>;

apps/twig/src/main/services/agent/schemas.ts

@@ -25,7 +25,6 @@ import { app } from "electron";
 import { inject, injectable, preDestroy } from "inversify";
 import { MAIN_TOKENS } from "../../di/tokens.js";
 import { logger } from "../../lib/logger.js";
-import { createMainTimingCollector } from "../../lib/timing.js";
 import { TypedEventEmitter } from "../../lib/typed-event-emitter.js";
 import type { FsService } from "../fs/service.js";
 import type { ProcessTrackingService } from "../process-tracking/service.js";
@@ -178,8 +177,6 @@ interface SessionConfig {
   additionalDirectories?: string[];
   /** Permission mode to use for the session */
   permissionMode?: string;
-  /** Dev-only: timestamp from renderer when user submitted the task */
-  submittedAt?: number;
 }
 
 interface ManagedSession {
@@ -420,8 +417,6 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
     isReconnect: boolean,
     isRetry = false,
   ): Promise<ManagedSession | null> {
-    const tc = createMainTimingCollector(log);
-
     const {
       taskId,
       taskRunId,
@@ -431,13 +426,8 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       adapter,
       additionalDirectories,
       permissionMode,
-      submittedAt,
     } = config;
 
-    if (submittedAt) {
-      tc.record("ipcTransit", Date.now() - submittedAt);
-    }
-
     // Preview sessions don't need a real repo — use a temp directory
     const repoPath = taskId === "__preview__" ? tmpdir() : rawRepoPath;
 
@@ -448,21 +438,15 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       }
 
       // Kill any lingering processes from previous runs of this task
-      tc.timeSync("killProcesses", () =>
-        this.processTracking.killByTaskId(taskId),
-      );
+      this.processTracking.killByTaskId(taskId);
 
       // Clean up any prior session for this taskRunId before creating a new one
-      await tc.time("cleanup", () => this.cleanupSession(taskRunId));
+      await this.cleanupSession(taskRunId);
     }
 
     const channel = `agent-event:${taskRunId}`;
-    const mockNodeDir = tc.timeSync("mockNode", () =>
-      this.setupMockNodeEnvironment(taskRunId),
-    );
-    tc.timeSync("setupEnv", () =>
-      this.setupEnvironment(credentials, mockNodeDir),
-    );
+    const mockNodeDir = this.setupMockNodeEnvironment(taskRunId);
+    this.setupEnvironment(credentials, mockNodeDir);
 
     // Preview sessions don't persist logs — no real task exists
     const isPreview = taskId === "__preview__";
@@ -479,74 +463,69 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
     });
 
     try {
-      const acpConnection = await tc.time("agentRun", () =>
-        agent.run(taskId, taskRunId, {
-          adapter,
-          codexBinaryPath:
-            adapter === "codex" ? getCodexBinaryPath() : undefined,
-          processCallbacks: {
-            onProcessSpawned: (info) => {
-              this.processTracking.register(
-                info.pid,
-                "agent",
-                `agent:${taskRunId}`,
-                {
-                  taskRunId,
-                  taskId,
-                  command: info.command,
-                },
+      const acpConnection = await agent.run(taskId, taskRunId, {
+        adapter,
+        codexBinaryPath: adapter === "codex" ? getCodexBinaryPath() : undefined,
+        processCallbacks: {
+          onProcessSpawned: (info) => {
+            this.processTracking.register(
+              info.pid,
+              "agent",
+              `agent:${taskRunId}`,
+              {
+                taskRunId,
                 taskId,
-              );
-            },
-            onProcessExited: (pid) => {
-              this.processTracking.unregister(pid, "agent-exited");
-            },
+                command: info.command,
+              },
+              taskId,
+            );
           },
-        }),
-      );
+          onProcessExited: (pid) => {
+            this.processTracking.unregister(pid, "agent-exited");
+          },
+        },
+      });
       const { clientStreams } = acpConnection;
 
-      const connection = tc.timeSync("clientConnection", () =>
-        this.createClientConnection(taskRunId, channel, clientStreams),
+      const connection = this.createClientConnection(
+        taskRunId,
+        channel,
+        clientStreams,
       );
 
-      await tc.time("initialize", () =>
-        connection.initialize({
-          protocolVersion: PROTOCOL_VERSION,
-          clientCapabilities: {
-            fs: {
-              readTextFile: true,
-              writeTextFile: true,
-            },
-            terminal: true,
+      await connection.initialize({
+        protocolVersion: PROTOCOL_VERSION,
+        clientCapabilities: {
+          fs: {
+            readTextFile: true,
+            writeTextFile: true,
           },
-        }),
-      );
+          terminal: true,
+        },
+      });
 
-      const mcpServers = tc.timeSync("buildMcp", () =>
-        adapter === "codex" ? [] : this.buildMcpServers(credentials),
-      );
+      const mcpServers =
+        adapter === "codex" ? [] : this.buildMcpServers(credentials);
 
       let configOptions: SessionConfigOption[] | undefined;
       let agentSessionId: string;
 
       if (isReconnect && adapter === "codex" && config.sessionId) {
-        const loadResponse = await tc.time("loadSession", () =>
-          connection.loadSession({
-            sessionId: config.sessionId!,
-            cwd: repoPath,
-            mcpServers,
-          }),
-        );
+        const loadResponse = await connection.loadSession({
+          sessionId: config.sessionId!,
+          cwd: repoPath,
+          mcpServers,
+        });
         configOptions = loadResponse.configOptions ?? undefined;
         agentSessionId = config.sessionId;
       } else if (isReconnect && adapter !== "codex") {
         if (!config.sessionId) {
           throw new Error("Cannot resume session without sessionId");
         }
         const systemPrompt = this.buildPostHogSystemPrompt(credentials);
-        const resumeResponse = await tc.time("resumeSession", () =>
-          connection.extMethod("_posthog/session/resume", {
+        const resumeResponse = await connection.extMethod(
+          "_posthog/session/resume",
+          {
             sessionId: config.sessionId!,
             cwd: repoPath,
             mcpServers,
@@ -564,7 +543,7 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
                 },
               }),
             },
-          }),
+          },
         );
         const resumeMeta = resumeResponse?._meta as
           | {
@@ -575,31 +554,26 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
         agentSessionId = config.sessionId;
       } else {
         const systemPrompt = this.buildPostHogSystemPrompt(credentials);
-        const newSessionResponse = await tc.time("newSession", () =>
-          connection.newSession({
-            cwd: repoPath,
-            mcpServers,
-            _meta: {
-              taskRunId,
-              systemPrompt,
-              ...(permissionMode && { permissionMode }),
-              ...(additionalDirectories?.length && {
-                claudeCode: {
-                  options: { additionalDirectories },
-                },
-              }),
-            },
-          }),
-        );
+        const newSessionResponse = await connection.newSession({
+          cwd: repoPath,
+          mcpServers,
+          _meta: {
+            taskRunId,
+            systemPrompt,
+            ...(permissionMode && { permissionMode }),
+            ...(additionalDirectories?.length && {
+              claudeCode: {
+                options: { additionalDirectories },
+              },
+            }),
+          },
+        });
         configOptions = newSessionResponse.configOptions ?? undefined;
         agentSessionId = newSessionResponse.sessionId;
       }
 
       config.sessionId = agentSessionId;
 
-      const sessionType = isReconnect ? "reconnect" : "create";
-      tc.summarize(`getOrCreateSession(${sessionType})`);
-
       const session: ManagedSession = {
         taskRunId,
         taskId,
@@ -1293,7 +1267,6 @@ For git operations while detached:
           : undefined,
       permissionMode:
         "permissionMode" in params ? params.permissionMode : undefined,
-      submittedAt: "submittedAt" in params ? params.submittedAt : undefined,
     };
   }
 

apps/twig/src/main/services/agent/service.ts

@@ -451,7 +451,6 @@ export const WithPendingPrompt: Story = {
       return events;
     })(),
     isPromptPending: true,
-    promptStartedAt: Date.now() - 5000,
     repoPath: "/Users/jonathan/dev/twig",
   },
 };

apps/twig/src/renderer/features/sessions/components/ConversationView.stories.tsx

@@ -60,7 +60,6 @@ type VirtualizedItem = ConversationItem | QueuedItem;
 interface ConversationViewProps {
   events: AcpMessage[];
   isPromptPending: boolean;
-  promptStartedAt?: number | null;
   repoPath?: string | null;
   taskId?: string;
 }
@@ -71,7 +70,6 @@ const ESTIMATE_SIZE = 200;
 export function ConversationView({
   events,
   isPromptPending,
-  promptStartedAt,
   repoPath,
   taskId,
 }: ConversationViewProps) {
@@ -209,7 +207,6 @@ export function ConversationView({
           <div className="pb-16">
             <SessionFooter
               isPromptPending={isPromptPending}
-              promptStartedAt={promptStartedAt}
               lastGenerationDuration={
                 lastTurn?.isComplete ? lastTurn.durationMs : null
               }

apps/twig/src/renderer/features/sessions/components/ConversationView.tsx

@@ -5,7 +5,6 @@ import { formatDuration, GeneratingIndicator } from "./GeneratingIndicator";
 
 interface SessionFooterProps {
   isPromptPending: boolean;
-  promptStartedAt?: number | null;
   lastGenerationDuration: number | null;
   lastStopReason?: string;
   queuedCount?: number;
@@ -14,7 +13,6 @@ interface SessionFooterProps {
 
 export function SessionFooter({
   isPromptPending,
-  promptStartedAt,
   lastGenerationDuration,
   lastStopReason,
   queuedCount = 0,
@@ -41,7 +39,7 @@ export function SessionFooter({
     return (
       <Box className="pt-3 pb-1">
         <Flex align="center" gap="2">
-          <GeneratingIndicator startedAt={promptStartedAt} />
+          <GeneratingIndicator />
           {queuedCount > 0 && (
             <Text size="1" color="gray">
               ({queuedCount} queued)

apps/twig/src/renderer/features/sessions/components/SessionFooter.tsx

@@ -37,7 +37,6 @@ interface SessionViewProps {
   taskId?: string;
   isRunning: boolean;
   isPromptPending?: boolean;
-  promptStartedAt?: number | null;
   onSendPrompt: (text: string) => void;
   onBashCommand?: (command: string) => void;
   onCancelPrompt: () => void;
@@ -58,7 +57,6 @@ export function SessionView({
   taskId,
   isRunning,
   isPromptPending = false,
-  promptStartedAt,
   onSendPrompt,
   onBashCommand,
   onCancelPrompt,
@@ -366,7 +364,6 @@ export function SessionView({
                 <ConversationView
                   events={events}
                   isPromptPending={isPromptPending}
-                  promptStartedAt={promptStartedAt}
                   repoPath={repoPath}
                   taskId={taskId}
                 />

apps/twig/src/renderer/features/sessions/components/SessionView.tsx

@@ -182,7 +182,6 @@ const createMockSession = (
   startedAt: Date.now(),
   status: "connected",
   isPromptPending: false,
-  promptStartedAt: null,
   pendingPermissions: new Map(),
   messageQueue: [],
   ...overrides,