fix: Remove unused task execution settings (#578)

charlesvien · web-flow · commit b2124088b9ff · 2026-01-23T12:41:25.000+01:00
Am I crazy? Neither of these settings are used / have any effect when they are turned on or off?
diff --git a/apps/twig/src/main/services/agent/schemas.ts b/apps/twig/src/main/services/agent/schemas.ts
@@ -43,7 +43,6 @@ export const startSessionInput = z.object({
   model: z.string().optional(),
   executionMode: z.enum(["plan", "acceptEdits", "default"]).optional(),
   runMode: z.enum(["local", "cloud"]).optional(),
-  createPR: z.boolean().optional(),
   /** Additional directories Claude can access beyond cwd (for worktree support) */
   additionalDirectories: z.array(z.string()).optional(),
 });
diff --git a/apps/twig/src/renderer/features/settings/components/SettingsView.tsx b/apps/twig/src/renderer/features/settings/components/SettingsView.tsx
@@ -55,14 +55,10 @@ export function SettingsView() {
   const isDarkMode = useThemeStore((state) => state.isDarkMode);
   const toggleDarkMode = useThemeStore((state) => state.toggleDarkMode);
   const {
-    autoRunTasks,
-    createPR,
     cursorGlow,
     desktopNotifications,
     autoConvertLongText,
     sendMessagesWith,
-    setAutoRunTasks,
-    setCreatePR,
     setCursorGlow,
     setDesktopNotifications,
     setAutoConvertLongText,
@@ -106,30 +102,6 @@ export function SettingsView() {
   }, [worktreeLocation]);
 
   // Tracked settings handlers
-  const handleAutoRunChange = useCallback(
-    (checked: boolean) => {
-      track(ANALYTICS_EVENTS.SETTING_CHANGED, {
-        setting_name: "auto_run_tasks",
-        new_value: checked,
-        old_value: autoRunTasks,
-      });
-      setAutoRunTasks(checked);
-    },
-    [autoRunTasks, setAutoRunTasks],
-  );
-
-  const handleCreatePRChange = useCallback(
-    (checked: boolean) => {
-      track(ANALYTICS_EVENTS.SETTING_CHANGED, {
-        setting_name: "create_pr",
-        new_value: checked,
-        old_value: createPR,
-      });
-      setCreatePR(checked);
-    },
-    [createPR, setCreatePR],
-  );
-
   const handleDarkModeChange = useCallback(() => {
     track(ANALYTICS_EVENTS.SETTING_CHANGED, {
       setting_name: "dark_mode",
@@ -437,49 +409,6 @@ export function SettingsView() {
 
           <Box className="border-gray-6 border-t" />
 
-          {/* Task Execution Section */}
-          <Flex direction="column" gap="3">
-            <Heading size="3">Task execution</Heading>
-            <Card>
-              <Flex direction="column" gap="4">
-                <Flex align="center" justify="between">
-                  <Flex direction="column" gap="1">
-                    <Text size="1" weight="medium">
-                      Auto-run new tasks
-                    </Text>
-                    <Text size="1" color="gray">
-                      Automatically start tasks after creation
-                    </Text>
-                  </Flex>
-                  <Switch
-                    checked={autoRunTasks}
-                    onCheckedChange={handleAutoRunChange}
-                    size="1"
-                  />
-                </Flex>
-
-                <Flex align="center" justify="between">
-                  <Flex direction="column" gap="1">
-                    <Text size="1" weight="medium">
-                      Create PR for local runs
-                    </Text>
-                    <Text size="1" color="gray">
-                      Automatically create a pull request when local tasks
-                      complete
-                    </Text>
-                  </Flex>
-                  <Switch
-                    checked={createPR}
-                    onCheckedChange={handleCreatePRChange}
-                    size="1"
-                  />
-                </Flex>
-              </Flex>
-            </Card>
-          </Flex>
-
-          <Box className="border-gray-6 border-t" />
-
           {/* Workspace Storage Section */}
           <Flex direction="column" gap="3">
             <Heading size="3">Workspace storage</Heading>
diff --git a/apps/twig/src/renderer/features/settings/stores/settingsStore.ts b/apps/twig/src/renderer/features/settings/stores/settingsStore.ts
@@ -8,24 +8,20 @@ export type LocalWorkspaceMode = "worktree" | "local";
 export type SendMessagesWith = "enter" | "cmd+enter";
 
 interface SettingsStore {
-  autoRunTasks: boolean;
   defaultRunMode: DefaultRunMode;
   lastUsedRunMode: "local" | "cloud";
   lastUsedLocalWorkspaceMode: LocalWorkspaceMode;
   lastUsedWorkspaceMode: WorkspaceMode;
-  createPR: boolean;
   defaultModel: string;
   desktopNotifications: boolean;
   cursorGlow: boolean;
   autoConvertLongText: boolean;
   sendMessagesWith: SendMessagesWith;
 
-  setAutoRunTasks: (autoRun: boolean) => void;
   setDefaultRunMode: (mode: DefaultRunMode) => void;
   setLastUsedRunMode: (mode: "local" | "cloud") => void;
   setLastUsedLocalWorkspaceMode: (mode: LocalWorkspaceMode) => void;
   setLastUsedWorkspaceMode: (mode: WorkspaceMode) => void;
-  setCreatePR: (createPR: boolean) => void;
   setDefaultModel: (model: string) => void;
   setDesktopNotifications: (enabled: boolean) => void;
   setCursorGlow: (enabled: boolean) => void;
@@ -36,25 +32,21 @@ interface SettingsStore {
 export const useSettingsStore = create<SettingsStore>()(
   persist(
     (set) => ({
-      autoRunTasks: true,
       defaultRunMode: "last_used",
       lastUsedRunMode: "local",
       lastUsedLocalWorkspaceMode: "worktree",
       lastUsedWorkspaceMode: "worktree",
-      createPR: true,
       defaultModel: DEFAULT_MODEL,
       desktopNotifications: true,
       cursorGlow: false,
       autoConvertLongText: true,
       sendMessagesWith: "enter",
 
-      setAutoRunTasks: (autoRun) => set({ autoRunTasks: autoRun }),
       setDefaultRunMode: (mode) => set({ defaultRunMode: mode }),
       setLastUsedRunMode: (mode) => set({ lastUsedRunMode: mode }),
       setLastUsedLocalWorkspaceMode: (mode) =>
         set({ lastUsedLocalWorkspaceMode: mode }),
       setLastUsedWorkspaceMode: (mode) => set({ lastUsedWorkspaceMode: mode }),
-      setCreatePR: (createPR) => set({ createPR }),
       setDefaultModel: (model) => set({ defaultModel: model }),
       setDesktopNotifications: (enabled) =>
         set({ desktopNotifications: enabled }),
diff --git a/apps/twig/src/renderer/features/task-detail/components/WorkspaceModeSelect.tsx b/apps/twig/src/renderer/features/task-detail/components/WorkspaceModeSelect.tsx
@@ -17,13 +17,13 @@ const MODE_CONFIG: Record<
 > = {
   local: {
     label: "Local",
-    description: "Runs on your machine",
-    icon: <Laptop size={14} weight="regular" />,
+    description: "Edits your repo directly on current branch",
+    icon: <Laptop size={16} weight="regular" />,
   },
   worktree: {
     label: "Workspace",
-    description: "Runs in a separate working copy",
-    icon: <GitBranch size={14} weight="regular" />,
+    description: "Edits a copy so your work stays isolated",
+    icon: <GitBranch size={16} weight="regular" />,
   },
 };
 
@@ -49,13 +49,39 @@ export function WorkspaceModeSelect({
       </DropdownMenu.Trigger>
 
       <DropdownMenu.Content align="start" size="1">
-        <DropdownMenu.Item onSelect={() => onChange("worktree")}>
-          <GitBranch size={14} />
-          Workspace
+        <DropdownMenu.Item
+          onSelect={() => onChange("worktree")}
+          style={{ padding: "6px 8px", height: "auto" }}
+        >
+          <div style={{ display: "flex", gap: 6, alignItems: "flex-start" }}>
+            <GitBranch
+              size={12}
+              style={{ marginTop: 2, flexShrink: 0, color: "var(--gray-11)" }}
+            />
+            <div>
+              <Text size="1">{MODE_CONFIG.worktree.label}</Text>
+              <Text size="1" color="gray" style={{ display: "block" }}>
+                {MODE_CONFIG.worktree.description}
+              </Text>
+            </div>
+          </div>
         </DropdownMenu.Item>
-        <DropdownMenu.Item onSelect={() => onChange("local")}>
-          <Laptop size={14} />
-          Local
+        <DropdownMenu.Item
+          onSelect={() => onChange("local")}
+          style={{ padding: "6px 8px", height: "auto" }}
+        >
+          <div style={{ display: "flex", gap: 6, alignItems: "flex-start" }}>
+            <Laptop
+              size={12}
+              style={{ marginTop: 2, flexShrink: 0, color: "var(--gray-11)" }}
+            />
+            <div>
+              <Text size="1">{MODE_CONFIG.local.label}</Text>
+              <Text size="1" color="gray" style={{ display: "block" }}>
+                {MODE_CONFIG.local.description}
+              </Text>
+            </div>
+          </div>
         </DropdownMenu.Item>
       </DropdownMenu.Content>
     </DropdownMenu.Root>
diff --git a/apps/twig/src/renderer/features/task-detail/hooks/useTaskCreation.ts b/apps/twig/src/renderer/features/task-detail/hooks/useTaskCreation.ts
@@ -1,7 +1,6 @@
 import { useAuthStore } from "@features/auth/stores/authStore";
 import type { MessageEditorHandle } from "@features/message-editor/components/MessageEditor";
 import type { EditorContent } from "@features/message-editor/utils/content";
-import { useSettingsStore } from "@features/settings/stores/settingsStore";
 import { useCreateTask } from "@features/tasks/hooks/useTasks";
 import { useConnectivity } from "@hooks/useConnectivity";
 import { get } from "@renderer/di/container";
@@ -80,7 +79,6 @@ function prepareTaskInput(
     githubIntegrationId?: number;
     workspaceMode: WorkspaceMode;
     branch?: string | null;
-    autoRun: boolean;
     executionMode?: "plan" | "acceptEdits";
   },
 ): TaskCreationInput {
@@ -92,7 +90,6 @@ function prepareTaskInput(
     githubIntegrationId: options.githubIntegrationId,
     workspaceMode: options.workspaceMode,
     branch: options.branch,
-    autoRun: options.autoRun,
     executionMode: options.executionMode,
   };
 }
@@ -122,7 +119,6 @@ export function useTaskCreation({
   const [isCreatingTask, setIsCreatingTask] = useState(false);
   const { navigateToTask } = useNavigationStore();
   const { isAuthenticated } = useAuthStore();
-  const { autoRunTasks } = useSettingsStore();
   const { invalidateTasks } = useCreateTask();
   const { isOnline } = useConnectivity();
 
@@ -152,7 +148,6 @@ export function useTaskCreation({
         githubIntegrationId,
         workspaceMode,
         branch,
-        autoRun: autoRunTasks,
         executionMode,
       });
 
@@ -195,7 +190,6 @@ export function useTaskCreation({
     githubIntegrationId,
     workspaceMode,
     branch,
-    autoRunTasks,
     executionMode,
     invalidateTasks,
     navigateToTask,
diff --git a/apps/twig/src/renderer/features/tasks/hooks/useTasks.ts b/apps/twig/src/renderer/features/tasks/hooks/useTasks.ts
@@ -64,7 +64,6 @@ export function useCreateTask() {
         description: string;
         repository?: string;
         github_integration?: number;
-        autoRun?: boolean;
         createdFrom?: "cli" | "command-menu";
       },
     ) =>
@@ -76,7 +75,7 @@ export function useCreateTask() {
     {
       onSuccess: (_task, variables) => {
         track(ANALYTICS_EVENTS.TASK_CREATED, {
-          auto_run: variables.autoRun || false,
+          auto_run: false,
           created_from: variables.createdFrom || "cli",
           repository_provider: variables.repository ? "github" : "none",
         });
diff --git a/apps/twig/src/renderer/sagas/task/task-creation.ts b/apps/twig/src/renderer/sagas/task/task-creation.ts
@@ -30,7 +30,6 @@ export interface TaskCreationInput {
   workspaceMode?: WorkspaceMode;
   branch?: string | null;
   githubIntegrationId?: number;
-  autoRun?: boolean;
   // Execution mode: "plan" starts in plan mode (read-only), "acceptEdits" auto-approves edits, undefined starts in default mode
   executionMode?: "plan" | "acceptEdits";
 }
@@ -172,11 +171,11 @@ export class TaskCreationSaga extends Saga<
     const shouldConnect =
       !!input.taskId || // Open: always connect to load chat history
       workspaceMode === "cloud" || // Cloud create: always connect
-      (agentCwd && input.autoRun); // Local create: only if autoRun
+      !!agentCwd; // Local create: always connect if we have a cwd
 
     if (shouldConnect) {
       const initialPrompt =
-        !input.taskId && input.autoRun && input.content
+        !input.taskId && input.content
           ? await this.readOnlyStep("build_prompt_blocks", () =>
               buildPromptBlocks(
                 input.content!,
diff --git a/apps/twig/src/renderer/services/task/service.ts b/apps/twig/src/renderer/services/task/service.ts
@@ -119,7 +119,7 @@ export class TaskService {
 
     // No existing workspace - run full saga to set it up
     const saga = new TaskCreationSaga({ posthogClient });
-    const result = await saga.run({ taskId, autoRun: true });
+    const result = await saga.run({ taskId });
 
     if (result.success) {
       this.updateStoresOnSuccess(result.data);
