Skip to content

Commit b1a0b34

Browse files
committed
fix: remove unused extra param from ErrorTrackingSignalCard
Per review feedback, removed the extra parameter entirely instead of renaming to _ since it is no longer used by this component. Signed-off-by: reverb256 <reverb256@users.noreply.github.com>
1 parent 69e1cb1 commit b1a0b34

File tree

5 files changed

+2218
-38
lines changed

5 files changed

+2218
-38
lines changed

apps/code/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"@storybook/addon-a11y": "10.2.0",
5757
"@storybook/addon-docs": "10.2.0",
5858
"@storybook/react-vite": "10.2.0",
59+
"@storybook/test-runner": "^0.24.3",
5960
"@testing-library/jest-dom": "^6.9.1",
6061
"@testing-library/react": "^16.3.0",
6162
"@testing-library/user-event": "^14.6.1",
@@ -74,6 +75,7 @@
7475
"jsdom": "^26.0.0",
7576
"lint-staged": "^15.5.2",
7677
"memfs": "^4.56.10",
78+
"playwright": "^1.59.1",
7779
"postcss": "^8.4.33",
7880
"storybook": "10.2.0",
7981
"tailwindcss": "^4.2.2",

apps/code/scripts/screenshot.js

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
const { chromium } = require("playwright");
2+
3+
(async () => {
4+
const browser = await chromium.launch();
5+
const page = await browser.newPage();
6+
7+
// Wait for storybook to be ready
8+
await page.goto(
9+
"http://localhost:6006/?path=/story/actionselector--single-select",
10+
);
11+
await page.waitForTimeout(3000);
12+
13+
// Take screenshot
14+
await page.screenshot({
15+
path: "/tmp/actionselector-after.png",
16+
fullPage: true,
17+
});
18+
19+
console.log("Screenshot saved to /tmp/actionselector-after.png");
20+
21+
await browser.close();
22+
})();

apps/code/src/renderer/features/inbox/components/detail/SignalCard.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -473,13 +473,11 @@ function LlmEvalSignalCard({
473473

474474
function ErrorTrackingSignalCard({
475475
signal,
476-
extra: _,
477476
verified,
478477
codePaths,
479478
dataQueried,
480479
}: {
481480
signal: Signal;
482-
extra: ErrorTrackingExtra;
483481
verified?: boolean;
484482
codePaths?: string[];
485483
dataQueried?: string;
@@ -613,7 +611,6 @@ export function SignalCard({
613611
return (
614612
<ErrorTrackingSignalCard
615613
signal={signal}
616-
extra={extra}
617614
verified={verified}
618615
codePaths={codePaths}
619616
dataQueried={dataQueried}

0 commit comments

Comments
 (0)