feat: persist preferred project by account key

jonathanlab · jonathanlab · commit 8077d8d3bd4e · 2026-03-31T16:19:38.000+02:00
diff --git a/apps/code/src/main/db/migrations/0004_auth_preferences.sql b/apps/code/src/main/db/migrations/0004_auth_preferences.sql
@@ -0,0 +1,9 @@
+CREATE TABLE `auth_preferences` (
+	`account_key` text NOT NULL,
+	`cloud_region` text NOT NULL,
+	`last_selected_project_id` integer,
+	`created_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL,
+	`updated_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL
+);
+--> statement-breakpoint
+CREATE INDEX `auth_preferences_account_region_idx` ON `auth_preferences` (`account_key`,`cloud_region`);
diff --git a/apps/code/src/main/db/migrations/meta/_journal.json b/apps/code/src/main/db/migrations/meta/_journal.json
@@ -29,6 +29,13 @@
       "when": 1774890000000,
       "tag": "0003_fair_whiplash",
       "breakpoints": true
+    },
+    {
+      "idx": 4,
+      "version": "7",
+      "when": 1774891000000,
+      "tag": "0004_auth_preferences",
+      "breakpoints": true
     }
   ]
 }
diff --git a/apps/code/src/main/db/repositories/auth-preference-repository.mock.ts b/apps/code/src/main/db/repositories/auth-preference-repository.mock.ts
@@ -0,0 +1,57 @@
+import type {
+  AuthPreference,
+  IAuthPreferenceRepository,
+  PersistAuthPreferenceInput,
+} from "./auth-preference-repository";
+
+export interface MockAuthPreferenceRepository
+  extends IAuthPreferenceRepository {
+  _preferences: AuthPreference[];
+}
+
+export function createMockAuthPreferenceRepository(): MockAuthPreferenceRepository {
+  let preferences: AuthPreference[] = [];
+
+  const clone = (value: AuthPreference): AuthPreference => ({ ...value });
+
+  return {
+    get _preferences() {
+      return preferences.map(clone);
+    },
+    set _preferences(value) {
+      preferences = value.map(clone);
+    },
+    get: (accountKey, cloudRegion) => {
+      const preference = preferences.find(
+        (entry) =>
+          entry.accountKey === accountKey && entry.cloudRegion === cloudRegion,
+      );
+      return preference ? clone(preference) : null;
+    },
+    save: (input: PersistAuthPreferenceInput) => {
+      const timestamp = new Date().toISOString();
+      const existingIndex = preferences.findIndex(
+        (entry) =>
+          entry.accountKey === input.accountKey &&
+          entry.cloudRegion === input.cloudRegion,
+      );
+
+      const row: AuthPreference = {
+        accountKey: input.accountKey,
+        cloudRegion: input.cloudRegion,
+        lastSelectedProjectId: input.lastSelectedProjectId,
+        createdAt:
+          existingIndex >= 0 ? preferences[existingIndex].createdAt : timestamp,
+        updatedAt: timestamp,
+      };
+
+      if (existingIndex >= 0) {
+        preferences[existingIndex] = row;
+      } else {
+        preferences.push(row);
+      }
+
+      return clone(row);
+    },
+  };
+}
diff --git a/apps/code/src/main/db/repositories/auth-preference-repository.ts b/apps/code/src/main/db/repositories/auth-preference-repository.ts
@@ -0,0 +1,89 @@
+import { and, eq } from "drizzle-orm";
+import { inject, injectable } from "inversify";
+import { MAIN_TOKENS } from "../../di/tokens";
+import { authPreferences } from "../schema";
+import type { DatabaseService } from "../service";
+
+export type AuthPreference = typeof authPreferences.$inferSelect;
+export type NewAuthPreference = typeof authPreferences.$inferInsert;
+
+export interface PersistAuthPreferenceInput {
+  accountKey: string;
+  cloudRegion: "us" | "eu" | "dev";
+  lastSelectedProjectId: number | null;
+}
+
+export interface IAuthPreferenceRepository {
+  get(
+    accountKey: string,
+    cloudRegion: "us" | "eu" | "dev",
+  ): AuthPreference | null;
+  save(input: PersistAuthPreferenceInput): AuthPreference;
+}
+
+const now = () => new Date().toISOString();
+
+@injectable()
+export class AuthPreferenceRepository implements IAuthPreferenceRepository {
+  constructor(
+    @inject(MAIN_TOKENS.DatabaseService)
+    private readonly databaseService: DatabaseService,
+  ) {}
+
+  private get db() {
+    return this.databaseService.db;
+  }
+
+  get(
+    accountKey: string,
+    cloudRegion: "us" | "eu" | "dev",
+  ): AuthPreference | null {
+    return (
+      this.db
+        .select()
+        .from(authPreferences)
+        .where(
+          and(
+            eq(authPreferences.accountKey, accountKey),
+            eq(authPreferences.cloudRegion, cloudRegion),
+          ),
+        )
+        .limit(1)
+        .get() ?? null
+    );
+  }
+
+  save(input: PersistAuthPreferenceInput): AuthPreference {
+    const timestamp = now();
+    const existing = this.get(input.accountKey, input.cloudRegion);
+
+    const row: NewAuthPreference = {
+      accountKey: input.accountKey,
+      cloudRegion: input.cloudRegion,
+      lastSelectedProjectId: input.lastSelectedProjectId,
+      createdAt: existing?.createdAt ?? timestamp,
+      updatedAt: timestamp,
+    };
+
+    if (existing) {
+      this.db
+        .update(authPreferences)
+        .set(row)
+        .where(
+          and(
+            eq(authPreferences.accountKey, input.accountKey),
+            eq(authPreferences.cloudRegion, input.cloudRegion),
+          ),
+        )
+        .run();
+    } else {
+      this.db.insert(authPreferences).values(row).run();
+    }
+
+    const saved = this.get(input.accountKey, input.cloudRegion);
+    if (!saved) {
+      throw new Error("Failed to persist auth preference");
+    }
+    return saved;
+  }
+}
diff --git a/apps/code/src/main/db/schema.ts b/apps/code/src/main/db/schema.ts
@@ -86,3 +86,20 @@ export const authSessions = sqliteTable("auth_sessions", {
   createdAt: createdAt(),
   updatedAt: updatedAt(),
 });
+
+export const authPreferences = sqliteTable(
+  "auth_preferences",
+  {
+    accountKey: text().notNull(),
+    cloudRegion: text({ enum: ["us", "eu", "dev"] }).notNull(),
+    lastSelectedProjectId: integer(),
+    createdAt: createdAt(),
+    updatedAt: updatedAt(),
+  },
+  (t) => [
+    index("auth_preferences_account_region_idx").on(
+      t.accountKey,
+      t.cloudRegion,
+    ),
+  ],
+);
diff --git a/apps/code/src/main/di/container.ts b/apps/code/src/main/di/container.ts
@@ -2,6 +2,7 @@ import "reflect-metadata";
 
 import { Container } from "inversify";
 import { ArchiveRepository } from "../db/repositories/archive-repository";
+import { AuthPreferenceRepository } from "../db/repositories/auth-preference-repository";
 import { AuthSessionRepository } from "../db/repositories/auth-session-repository";
 import { RepositoryRepository } from "../db/repositories/repository-repository";
 import { SuspensionRepositoryImpl } from "../db/repositories/suspension-repository";
@@ -52,6 +53,9 @@ export const container = new Container({
 });
 
 container.bind(MAIN_TOKENS.DatabaseService).to(DatabaseService);
+container
+  .bind(MAIN_TOKENS.AuthPreferenceRepository)
+  .to(AuthPreferenceRepository);
 container.bind(MAIN_TOKENS.AuthSessionRepository).to(AuthSessionRepository);
 container.bind(MAIN_TOKENS.RepositoryRepository).to(RepositoryRepository);
 container.bind(MAIN_TOKENS.WorkspaceRepository).to(WorkspaceRepository);
diff --git a/apps/code/src/main/di/tokens.ts b/apps/code/src/main/di/tokens.ts
@@ -9,6 +9,7 @@ export const MAIN_TOKENS = Object.freeze({
   SettingsStore: Symbol.for("Main.SettingsStore"),
 
   // Database
+  AuthPreferenceRepository: Symbol.for("Main.AuthPreferenceRepository"),
   DatabaseService: Symbol.for("Main.DatabaseService"),
   AuthSessionRepository: Symbol.for("Main.AuthSessionRepository"),
   RepositoryRepository: Symbol.for("Main.RepositoryRepository"),
diff --git a/apps/code/src/main/services/auth/service.test.ts b/apps/code/src/main/services/auth/service.test.ts
@@ -1,5 +1,6 @@
 import { OAUTH_SCOPE_VERSION } from "@shared/constants/oauth";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { createMockAuthPreferenceRepository } from "../../db/repositories/auth-preference-repository.mock";
 import { createMockAuthSessionRepository } from "../../db/repositories/auth-session-repository.mock";
 import { decrypt, encrypt } from "../../utils/encryption";
 import type { ConnectivityService } from "../connectivity/service";
@@ -18,6 +19,7 @@ vi.mock("../../utils/logger.js", () => ({
 }));
 
 describe("AuthService", () => {
+  const preferenceRepository = createMockAuthPreferenceRepository();
   const repository = createMockAuthSessionRepository();
   const oauthService = {
     refreshToken: vi.fn(),
@@ -31,16 +33,43 @@ describe("AuthService", () => {
   let service: AuthService;
 
   beforeEach(() => {
+    preferenceRepository._preferences = [];
     repository.clearCurrent();
     vi.clearAllMocks();
-    service = new AuthService(repository, oauthService, connectivityService);
+    service = new AuthService(
+      preferenceRepository,
+      repository,
+      oauthService,
+      connectivityService,
+    );
   });
 
   afterEach(async () => {
     vi.unstubAllGlobals();
     await service.logout();
   });
 
+  const stubAuthFetch = (accountKey = "user-1") => {
+    vi.stubGlobal(
+      "fetch",
+      vi.fn(async (input: string | Request) => {
+        const url = typeof input === "string" ? input : input.url;
+
+        if (url.includes("/api/users/@me/")) {
+          return {
+            ok: true,
+            json: vi.fn().mockResolvedValue({ uuid: accountKey }),
+          } as unknown as Response;
+        }
+
+        return {
+          ok: true,
+          json: vi.fn().mockResolvedValue({ has_access: true }),
+        } as unknown as Response;
+      }) as typeof fetch,
+    );
+  };
+
   it("bootstraps to anonymous when there is no stored session", async () => {
     await service.initialize();
 
@@ -99,12 +128,7 @@ describe("AuthService", () => {
       },
     });
 
-    vi.stubGlobal(
-      "fetch",
-      vi.fn().mockResolvedValue({
-        json: vi.fn().mockResolvedValue({ has_access: true }),
-      }) as unknown as typeof fetch,
-    );
+    stubAuthFetch();
 
     await service.initialize();
 
@@ -151,12 +175,7 @@ describe("AuthService", () => {
         scoped_organizations: ["org-1"],
       },
     });
-    vi.stubGlobal(
-      "fetch",
-      vi.fn().mockResolvedValue({
-        json: vi.fn().mockResolvedValue({ has_access: true }),
-      }) as unknown as typeof fetch,
-    );
+    stubAuthFetch();
 
     await service.login("us");
 
@@ -211,12 +230,7 @@ describe("AuthService", () => {
       },
     });
 
-    vi.stubGlobal(
-      "fetch",
-      vi.fn().mockResolvedValue({
-        json: vi.fn().mockResolvedValue({ has_access: true }),
-      }) as unknown as typeof fetch,
-    );
+    stubAuthFetch();
 
     await service.login("us");
     await service.selectProject(84);
@@ -237,4 +251,66 @@ describe("AuthService", () => {
       availableProjectIds: [42, 84],
     });
   });
+
+  it("restores the selected project after app restart while logged out", async () => {
+    vi.mocked(oauthService.startFlow)
+      .mockResolvedValueOnce({
+        success: true,
+        data: {
+          access_token: "initial-access-token",
+          refresh_token: "initial-refresh-token",
+          expires_in: 3600,
+          token_type: "Bearer",
+          scope: "",
+          scoped_teams: [42, 84],
+          scoped_organizations: ["org-1"],
+        },
+      })
+      .mockResolvedValueOnce({
+        success: true,
+        data: {
+          access_token: "second-access-token",
+          refresh_token: "second-refresh-token",
+          expires_in: 3600,
+          token_type: "Bearer",
+          scope: "",
+          scoped_teams: [42, 84],
+          scoped_organizations: ["org-1"],
+        },
+      });
+    vi.mocked(oauthService.refreshToken).mockResolvedValue({
+      success: true,
+      data: {
+        access_token: "refreshed-access-token",
+        refresh_token: "refreshed-refresh-token",
+        expires_in: 3600,
+        token_type: "Bearer",
+        scope: "",
+        scoped_teams: [42, 84],
+        scoped_organizations: ["org-1"],
+      },
+    });
+
+    stubAuthFetch();
+
+    await service.login("us");
+    await service.selectProject(84);
+    await service.logout();
+
+    service = new AuthService(
+      preferenceRepository,
+      repository,
+      oauthService,
+      connectivityService,
+    );
+
+    await service.login("us");
+
+    expect(service.getState()).toMatchObject({
+      status: "authenticated",
+      cloudRegion: "us",
+      projectId: 84,
+      availableProjectIds: [42, 84],
+    });
+  });
 });
diff --git a/apps/code/src/main/services/auth/service.ts b/apps/code/src/main/services/auth/service.ts

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,13 @@`
`29`	`29`	`"when": 1774890000000,`
`30`	`30`	`"tag": "0003_fair_whiplash",`
`31`	`31`	`"breakpoints": true`
	`32`	`+ },`
	`33`	`+ {`
	`34`	`+ "idx": 4,`
	`35`	`+ "version": "7",`
	`36`	`+ "when": 1774891000000,`
	`37`	`+ "tag": "0004_auth_preferences",`
	`38`	`+ "breakpoints": true`
`32`	`39`	`}`
`33`	`40`	`]`
`34`	`41`	`}`