review fixes

Author: charlesvien

apps/twig/src/renderer/features/sessions/service/service.ts

@@ -63,7 +63,7 @@ interface AuthCredentials {
   client: ReturnType<typeof useAuthStore.getState>["client"];
 }
 
-interface ConnectParams {
+export interface ConnectParams {
   task: Task;
   repoPath: string;
   initialPrompt?: ContentBlock[];
@@ -361,7 +361,7 @@ export class SessionService {
 
         // Restore persisted config options to server in parallel
         if (persistedConfigOptions) {
-          await Promise.allSettled(
+          await Promise.all(
             persistedConfigOptions.map((opt) =>
               trpcVanilla.agent.setConfigOption
                 .mutate({

apps/twig/src/renderer/sagas/task/task-creation.ts

@@ -1,5 +1,8 @@
 import { buildPromptBlocks } from "@features/editor/utils/prompt-builder";
-import { getSessionService } from "@features/sessions/service/service";
+import {
+  type ConnectParams,
+  getSessionService,
+} from "@features/sessions/service/service";
 import { useWorkspaceStore } from "@features/workspace/stores/workspaceStore";
 import { Saga, type SagaLogger } from "@posthog/shared";
 import type { PostHogAPIClient } from "@renderer/api/posthogClient";
@@ -198,19 +201,19 @@ export class TaskCreationSaga extends Saga<
           // Fire-and-forget for both open and create paths.
           // The UI handles "connecting" state with a spinner (TaskLogsPanel),
           // so we don't need to block the saga on the full reconnect chain.
-          getSessionService().connectToTask({
+          const connectParams: ConnectParams = {
             task,
             repoPath: agentCwd ?? "",
-            ...(initialPrompt ? { initialPrompt } : {}),
-            ...(input.executionMode
-              ? { executionMode: input.executionMode }
-              : {}),
-            ...(input.adapter ? { adapter: input.adapter } : {}),
-            ...(input.model ? { model: input.model } : {}),
-            ...(input.reasoningLevel
-              ? { reasoningLevel: input.reasoningLevel }
-              : {}),
-          });
+          };
+          if (initialPrompt) connectParams.initialPrompt = initialPrompt;
+          if (input.executionMode)
+            connectParams.executionMode = input.executionMode;
+          if (input.adapter) connectParams.adapter = input.adapter;
+          if (input.model) connectParams.model = input.model;
+          if (input.reasoningLevel)
+            connectParams.reasoningLevel = input.reasoningLevel;
+
+          getSessionService().connectToTask(connectParams);
           return { taskId: task.id };
         },
         rollback: async ({ taskId }) => {

packages/agent/src/adapters/claude/claude-agent.ts

@@ -195,9 +195,7 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
     ]);
 
     session.modelId = modelOptions.currentModelId;
-
-    // Fire-and-forget — trySetModel already swallows errors
-    this.trySetModel(q, modelOptions.currentModelId);
+    await this.trySetModel(q, modelOptions.currentModelId);
 
     this.sendAvailableCommandsUpdate(sessionId, slashCommands);
 

packages/agent/src/adapters/claude/session/options.ts

@@ -1,5 +1,6 @@
 import { spawn } from "node:child_process";
 import * as fs from "node:fs";
+import * as os from "node:os";
 import * as path from "node:path";
 import type {
   McpServerConfig,
@@ -235,5 +236,16 @@ export function buildSessionOptions(params: BuildOptionsParams): Options {
     options.additionalDirectories = params.additionalDirectories;
   }
 
+  clearStatsigCache();
   return options;
 }
+
+function clearStatsigCache(): void {
+  const statsigPath = path.join(
+    process.env.CLAUDE_CONFIG_DIR || path.join(os.homedir(), ".claude"),
+    "statsig",
+  );
+  fs.rm(statsigPath, { recursive: true, force: true }, () => {
+    // Best-effort, ignore errors
+  });
+}