work

charlesvien · charlesvien · commit 5b0273358c83 · 2026-03-25T17:28:33.000Z
diff --git a/apps/code/src/main/services/agent/schemas.ts b/apps/code/src/main/services/agent/schemas.ts
@@ -82,7 +82,7 @@ const sessionConfigSelectGroupSchema = z
   })
   .passthrough();
 
-export const sessionConfigOptionSchema = z
+const sessionConfigSelectSchema = z
   .object({
     id: z.string(),
     name: z.string(),
@@ -97,6 +97,23 @@ export const sessionConfigOptionSchema = z
   })
   .passthrough();
 
+const sessionConfigBooleanSchema = z
+  .object({
+    id: z.string(),
+    name: z.string(),
+    type: z.literal("boolean"),
+    currentValue: z.boolean(),
+    category: z.string().nullish(),
+    description: z.string().nullish(),
+    _meta: z.record(z.string(), z.unknown()).nullish(),
+  })
+  .passthrough();
+
+export const sessionConfigOptionSchema = z.union([
+  sessionConfigSelectSchema,
+  sessionConfigBooleanSchema,
+]);
+
 export type SessionConfigOption = z.infer<typeof sessionConfigOptionSchema>;
 
 export const sessionResponseSchema = z.object({
diff --git a/apps/code/src/main/services/agent/service.ts b/apps/code/src/main/services/agent/service.ts
@@ -1022,7 +1022,10 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       const updatedModeOption = session.configOptions?.find(
         (opt) => opt.category === "mode",
       );
-      if (updatedModeOption) {
+      if (
+        updatedModeOption &&
+        typeof updatedModeOption.currentValue === "string"
+      ) {
         session.config.permissionMode = updatedModeOption.currentValue;
       }
 
diff --git a/apps/code/src/renderer/features/message-editor/components/AttachmentMenu.tsx b/apps/code/src/renderer/features/message-editor/components/AttachmentMenu.tsx
@@ -147,7 +147,10 @@ export function AttachmentMenu({
             </div>
           ) : (
             <div className="issue-picker">
-              <IssuePicker repoPath={repoPath!} onSelect={handleIssueSelect} />
+              <IssuePicker
+                repoPath={repoPath ?? ""}
+                onSelect={handleIssueSelect}
+              />
             </div>
           )}
         </Popover.Content>
diff --git a/apps/code/src/renderer/features/message-editor/components/ModeIndicatorInput.tsx b/apps/code/src/renderer/features/message-editor/components/ModeIndicatorInput.tsx
@@ -2,6 +2,7 @@ import type {
   SessionConfigOption,
   SessionConfigSelectGroup,
   SessionConfigSelectOption,
+  SessionConfigSelectOptions,
 } from "@agentclientprotocol/sdk";
 import {
   Circle,
@@ -60,7 +61,7 @@ interface ModeIndicatorInputProps {
 }
 
 function flattenOptions(
-  options: SessionConfigOption["options"],
+  options: SessionConfigSelectOptions,
 ): SessionConfigSelectOption[] {
   if (options.length === 0) return [];
   if ("group" in options[0]) {
@@ -75,7 +76,7 @@ export function ModeIndicatorInput({
   modeOption,
   onCycleMode,
 }: ModeIndicatorInputProps) {
-  if (!modeOption) return null;
+  if (!modeOption || modeOption.type !== "select") return null;
 
   const id = modeOption.currentValue;
 
diff --git a/apps/code/src/renderer/features/onboarding/components/TutorialStep.tsx b/apps/code/src/renderer/features/onboarding/components/TutorialStep.tsx
@@ -109,7 +109,8 @@ export function TutorialStep({ onComplete, onBack }: TutorialStepProps) {
   const currentExecutionMode =
     getCurrentModeFromConfigOptions(modeOption ? [modeOption] : undefined) ??
     "plan";
-  const currentReasoningLevel = thoughtOption?.currentValue;
+  const currentReasoningLevel =
+    thoughtOption?.type === "select" ? thoughtOption.currentValue : undefined;
 
   // Task creation — use whatever model the user picked
   const { isCreatingTask, canSubmit, handleSubmit } = useTaskCreation({
diff --git a/apps/code/src/renderer/features/sessions/components/ModelSelector.tsx b/apps/code/src/renderer/features/sessions/components/ModelSelector.tsx
@@ -24,26 +24,33 @@ export function ModelSelector({
   const session = useSessionForTask(taskId);
   const modelOption = useModelConfigOptionForTask(taskId);
 
-  const options = modelOption ? flattenSelectOptions(modelOption.options) : [];
+  const selectOption = modelOption?.type === "select" ? modelOption : undefined;
+  const options = selectOption
+    ? flattenSelectOptions(selectOption.options)
+    : [];
   const groupedOptions = useMemo(() => {
-    if (!modelOption || modelOption.options.length === 0) return [];
-    if ("group" in modelOption.options[0]) {
-      return modelOption.options as SessionConfigSelectGroup[];
+    if (!selectOption || selectOption.options.length === 0) return [];
+    if ("group" in selectOption.options[0]) {
+      return selectOption.options as SessionConfigSelectGroup[];
     }
     return [];
-  }, [modelOption]);
+  }, [selectOption]);
 
-  if (!modelOption || options.length === 0) return null;
+  if (!selectOption || options.length === 0) return null;
 
   const handleChange = (value: string) => {
     onModelChange?.(value);
 
     if (taskId && session?.status === "connected") {
-      getSessionService().setSessionConfigOption(taskId, modelOption.id, value);
+      getSessionService().setSessionConfigOption(
+        taskId,
+        selectOption.id,
+        value,
+      );
     }
   };
 
-  const currentValue = modelOption.currentValue;
+  const currentValue = selectOption.currentValue;
   const currentLabel =
     options.find((opt) => opt.value === currentValue)?.name ?? currentValue;
 
diff --git a/apps/code/src/renderer/features/sessions/components/ReasoningLevelSelector.tsx b/apps/code/src/renderer/features/sessions/components/ReasoningLevelSelector.tsx
@@ -20,7 +20,7 @@ export function ReasoningLevelSelector({
   const thoughtOption = useThoughtLevelConfigOptionForTask(taskId);
   const adapter = useAdapterForTask(taskId);
 
-  if (!thoughtOption) {
+  if (!thoughtOption || thoughtOption.type !== "select") {
     return null;
   }
 
diff --git a/apps/code/src/renderer/features/sessions/components/UnifiedModelSelector.tsx b/apps/code/src/renderer/features/sessions/components/UnifiedModelSelector.tsx
@@ -50,16 +50,19 @@ export function UnifiedModelSelector({
   const session = useSessionForTask(taskId);
   const modelOption = useModelConfigOptionForTask(taskId);
 
-  const options = modelOption ? flattenSelectOptions(modelOption.options) : [];
+  const selectOption = modelOption?.type === "select" ? modelOption : undefined;
+  const options = selectOption
+    ? flattenSelectOptions(selectOption.options)
+    : [];
   const groupedOptions = useMemo(() => {
-    if (!modelOption || modelOption.options.length === 0) return [];
-    if ("group" in modelOption.options[0]) {
-      return modelOption.options as SessionConfigSelectGroup[];
+    if (!selectOption || selectOption.options.length === 0) return [];
+    if ("group" in selectOption.options[0]) {
+      return selectOption.options as SessionConfigSelectGroup[];
     }
     return [];
-  }, [modelOption]);
+  }, [selectOption]);
 
-  const currentValue = modelOption?.currentValue;
+  const currentValue = selectOption?.currentValue;
   const currentLabel =
     options.find((opt) => opt.value === currentValue)?.name ?? currentValue;
 
diff --git a/apps/code/src/renderer/features/sessions/service/service.ts b/apps/code/src/renderer/features/sessions/service/service.ts
@@ -355,10 +355,9 @@ export class SessionService {
     this.subscribeToChannel(taskRunId);
 
     try {
-      const persistedMode = getConfigOptionByCategory(
-        persistedConfigOptions,
-        "mode",
-      )?.currentValue;
+      const modeOpt = getConfigOptionByCategory(persistedConfigOptions, "mode");
+      const persistedMode =
+        modeOpt?.type === "select" ? modeOpt.currentValue : undefined;
 
       trpcClient.workspace.verify
         .query({ taskId })
@@ -429,7 +428,7 @@ export class SessionService {
                 .mutate({
                   sessionId: taskRunId,
                   configId: opt.id,
-                  value: opt.currentValue,
+                  value: String(opt.currentValue),
                 })
                 .catch((error) => {
                   log.warn(
@@ -1636,7 +1635,9 @@ export class SessionService {
 
     // Optimistic update
     const updatedOptions = configOptions.map((opt) =>
-      opt.id === configId ? { ...opt, currentValue: value } : opt,
+      opt.id === configId
+        ? ({ ...opt, currentValue: value } as SessionConfigOption)
+        : opt,
     );
     sessionStoreSetters.updateSession(session.taskRunId, {
       configOptions: updatedOptions,
@@ -1652,15 +1653,17 @@ export class SessionService {
     } catch (error) {
       // Rollback on error
       const rolledBackOptions = configOptions.map((opt) =>
-        opt.id === configId ? { ...opt, currentValue: previousValue } : opt,
+        opt.id === configId
+          ? ({ ...opt, currentValue: previousValue } as SessionConfigOption)
+          : opt,
       );
       sessionStoreSetters.updateSession(session.taskRunId, {
         configOptions: rolledBackOptions,
       });
       updatePersistedConfigOptionValue(
         session.taskRunId,
         configId,
-        previousValue,
+        String(previousValue),
       );
       log.error("Failed to set session config option", {
         taskId,
@@ -1697,7 +1700,7 @@ export class SessionService {
       track(ANALYTICS_EVENTS.SESSION_CONFIG_CHANGED, {
         task_id: taskId,
         category,
-        from_value: configOption.currentValue,
+        from_value: String(configOption.currentValue),
         to_value: value,
       });
     }
diff --git a/apps/code/src/renderer/features/sessions/stores/sessionConfigStore.ts b/apps/code/src/renderer/features/sessions/stores/sessionConfigStore.ts
@@ -49,7 +49,9 @@ export const useSessionConfigStore = create<SessionConfigStore>()(
           if (!existing) return state;
 
           const updated = existing.map((opt) =>
-            opt.id === configId ? { ...opt, currentValue: value } : opt,
+            opt.id === configId
+              ? ({ ...opt, currentValue: value } as SessionConfigOption)
+              : opt,
           );
 
           return {
diff --git a/apps/code/src/renderer/features/sessions/stores/sessionStore.ts b/apps/code/src/renderer/features/sessions/stores/sessionStore.ts
@@ -120,8 +120,10 @@ export function mergeConfigOptions(
   return live.map((liveOpt) => {
     const persistedOpt = persistedMap.get(liveOpt.id);
     if (persistedOpt) {
-      // Use persisted currentValue if available
-      return { ...liveOpt, currentValue: persistedOpt.currentValue };
+      return {
+        ...liveOpt,
+        currentValue: persistedOpt.currentValue,
+      } as SessionConfigOption;
     }
     return liveOpt;
   });
@@ -145,7 +147,7 @@ export function cycleModeOption(
   modeOption: SessionConfigOption | undefined,
   allowBypassPermissions: boolean,
 ): string | undefined {
-  if (!modeOption) return undefined;
+  if (!modeOption || modeOption.type !== "select") return undefined;
 
   const allOptions = flattenSelectOptions(modeOption.options);
   const filteredOptions = allowBypassPermissions
diff --git a/apps/code/src/renderer/features/task-detail/components/TaskInput.tsx b/apps/code/src/renderer/features/task-detail/components/TaskInput.tsx
@@ -140,13 +140,15 @@ export function TaskInput() {
 
   // Get current values from preview session config options for task creation.
   // Defaults ensure values are always passed even before the preview session loads.
-  const currentModel = modelOption?.currentValue;
+  const currentModel =
+    modelOption?.type === "select" ? modelOption.currentValue : undefined;
   const modeFallback =
     defaultInitialTaskMode === "last_used" ? lastUsedInitialTaskMode : "plan";
   const currentExecutionMode =
     getCurrentModeFromConfigOptions(modeOption ? [modeOption] : undefined) ??
     modeFallback;
-  const currentReasoningLevel = thoughtOption?.currentValue;
+  const currentReasoningLevel =
+    thoughtOption?.type === "select" ? thoughtOption.currentValue : undefined;
 
   const branchForTaskCreation =
     effectiveWorkspaceMode === "worktree" || effectiveWorkspaceMode === "cloud"
diff --git a/apps/code/src/vite-env.d.ts b/apps/code/src/vite-env.d.ts
@@ -13,9 +13,6 @@ interface ImportMetaEnv {
   readonly VITE_POSTHOG_UI_HOST?: string;
 }
 
-// This interface is used by TypeScript to type-check `import.meta.env` in Vite.
-// It appears unused in this file, but it is intentionally kept for global augmentation.
-// biome-ignore lint: noUnusedVariables
 interface ImportMeta {
   readonly env: ImportMetaEnv;
 }
diff --git a/packages/agent/src/adapters/claude/claude-agent.ts b/packages/agent/src/adapters/claude/claude-agent.ts
@@ -631,7 +631,11 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
       "options" in option && Array.isArray(option.options)
         ? (option.options as Array<Record<string, unknown>>).flatMap((o) =>
             "options" in o && Array.isArray(o.options)
-              ? (o.options as { value: string; name?: string; description?: string }[])
+              ? (o.options as {
+                  value: string;
+                  name?: string;
+                  description?: string;
+                }[])
               : [o as { value: string; name?: string; description?: string }],
           )
         : [];
@@ -992,13 +996,17 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
       currentModelId: this.session.modelId ?? DEFAULT_MODEL,
       availableModels:
         modelOptions && "options" in modelOptions
-          ? (modelOptions.options as Array<{ value: string; name: string; description?: string }>).map(
-              (opt) => ({
-                modelId: opt.value,
-                name: opt.name,
-                description: opt.description,
-              }),
-            )
+          ? (
+              modelOptions.options as Array<{
+                value: string;
+                name: string;
+                description?: string;
+              }>
+            ).map((opt) => ({
+              modelId: opt.value,
+              name: opt.name,
+              description: opt.description,
+            }))
           : [],
     };
 
diff --git a/packages/agent/src/adapters/claude/session/models.ts b/packages/agent/src/adapters/claude/session/models.ts
@@ -67,9 +67,10 @@ export function getEffortOptions(modelId: string): EffortOption[] | null {
 
 const MODEL_CONTEXT_HINT_PATTERN = /\[(\d+m)\]$/i;
 
-function tokenizeModelPreference(
-  model: string,
-): { tokens: string[]; contextHint?: string } {
+function tokenizeModelPreference(model: string): {
+  tokens: string[];
+  contextHint?: string;
+} {
   const lower = model.trim().toLowerCase();
   const contextHint = lower
     .match(MODEL_CONTEXT_HINT_PATTERN)?.[1]

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export function ReasoningLevelSelector({`
`20`	`20`	`const thoughtOption = useThoughtLevelConfigOptionForTask(taskId);`
`21`	`21`	`const adapter = useAdapterForTask(taskId);`
`22`	`22`
`23`		`- if (!thoughtOption) {`
	`23`	`+ if (!thoughtOption \|\| thoughtOption.type !== "select") {`
`24`	`24`	`return null;`
`25`	`25`	`}`
`26`	`26`