feat: UI polish and fixes (#952)

Author: charlesvien

.env.example

@@ -10,7 +10,3 @@ APPLE_CODESIGN_KEYCHAIN_PASSWORD="xxx"
 VITE_POSTHOG_API_KEY=xxx
 VITE_POSTHOG_API_HOST=xxx
 VITE_POSTHOG_UI_HOST=xxx
-
-# PostHog Survey IDs (optional)
-VITE_POSTHOG_BUG_SURVEY_ID=
-VITE_POSTHOG_FEEDBACK_SURVEY_ID=

apps/twig/src/main/services/updates/schemas.ts

@@ -35,8 +35,12 @@ export type UpdatesStatusPayload = {
   error?: string;
 };
 
+export type UpdateReadyPayload = {
+  version: string | null;
+};
+
 export interface UpdatesEvents {
-  [UpdatesEvent.Ready]: true;
+  [UpdatesEvent.Ready]: UpdateReadyPayload;
   [UpdatesEvent.Status]: UpdatesStatusPayload;
   [UpdatesEvent.CheckFromMenu]: true;
 }

apps/twig/src/main/services/updates/service.test.ts

@@ -451,7 +451,7 @@ describe("UpdatesService", () => {
         downloadedHandler({}, "Release notes here", "v2.0.0");
       }
 
-      expect(readyHandler).toHaveBeenCalledWith(true);
+      expect(readyHandler).toHaveBeenCalledWith({ version: "v2.0.0" });
     });
 
     it("handles error event and emits status with error", () => {

apps/twig/src/main/services/updates/service.ts

@@ -237,7 +237,7 @@ export class UpdatesService extends TypedEventEmitter<UpdatesEvents> {
       log.info("Notifying user that update is ready", {
         downloadedVersion: this.downloadedVersion,
       });
-      this.emit(UpdatesEvent.Ready, true);
+      this.emit(UpdatesEvent.Ready, { version: this.downloadedVersion });
       this.pendingNotification = false;
     }
   }

apps/twig/src/renderer/components/CampfireToggle.tsx

@@ -5,6 +5,7 @@ import {
   getShortcutsByCategory,
   type ShortcutCategory,
 } from "@renderer/constants/keyboard-shortcuts";
+import { isMac } from "@utils/platform";
 import { useMemo } from "react";
 
 interface KeyboardShortcutsSheetProps {
@@ -134,8 +135,6 @@ export function KeyboardShortcutsList() {
 
 function SingleShortcutKeys({ keys }: { keys: string }) {
   const formatted = formatHotkey(keys);
-  const isMac =
-    typeof navigator !== "undefined" && /Mac/.test(navigator.platform);
 
   if (isMac) {
     return (