review fixes

Author: charlesvien

apps/twig/src/main/services/agent/service.ts

@@ -435,6 +435,7 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       adapter,
       additionalDirectories,
       permissionMode,
+      customInstructions,
     } = config;
 
     // Preview sessions don't need a real repo — use a temp directory
@@ -533,7 +534,7 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
         }
         const systemPrompt = this.buildSystemPrompt(
           credentials,
-          config.customInstructions,
+          customInstructions,
         );
         const resumeResponse = await connection.extMethod(
           "_posthog/session/resume",
@@ -567,7 +568,7 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       } else {
         const systemPrompt = this.buildSystemPrompt(
           credentials,
-          config.customInstructions,
+          customInstructions,
         );
         const newSessionResponse = await connection.newSession({
           cwd: repoPath,

apps/twig/src/renderer/features/settings/components/sections/PersonalizationSettings.tsx

@@ -24,19 +24,20 @@ export function PersonalizationSettings() {
 
   const saveInstructions = useCallback(
     (value: string) => {
-      const trimmed = value.slice(0, MAX_INSTRUCTIONS_LENGTH);
-      setCustomInstructions(trimmed);
+      const current = useSettingsStore.getState().customInstructions;
+      if (value === current) return;
+      setCustomInstructions(value);
       track(ANALYTICS_EVENTS.SETTING_CHANGED, {
         setting_name: "custom_instructions",
-        new_value: trimmed.length > 0,
+        new_value: value.length > 0,
       });
     },
     [setCustomInstructions],
   );
 
   const handleInstructionsChange = useCallback(
     (e: React.ChangeEvent<HTMLTextAreaElement>) => {
-      const value = e.target.value.slice(0, MAX_INSTRUCTIONS_LENGTH);
+      const value = e.target.value;
       setLocalInstructions(value);
 
       if (debounceRef.current) {
@@ -80,6 +81,7 @@ export function PersonalizationSettings() {
         value={localInstructions}
         onChange={handleInstructionsChange}
         onBlur={handleInstructionsBlur}
+        maxLength={MAX_INSTRUCTIONS_LENGTH}
         placeholder="e.g. Always write tests for new code. Prefer functional patterns."
         rows={6}
         size="1"