Revert "Dev tool: force invalid sdkSessionId to test error handling"

This reverts commit 6bde65c.

Author: charlesvien

apps/twig/src/main/index.ts

@@ -271,20 +271,6 @@ function createWindow(): void {
                 });
               },
             },
-            {
-              label: "Force invalid SDK session on next reconnect",
-              click: () => {
-                container
-                  .get<AgentService>(MAIN_TOKENS.AgentService)
-                  .setForceInvalidSdkSessionId(true);
-                dialog.showMessageBox({
-                  type: "info",
-                  title: "Flag Set",
-                  message:
-                    "Next session reconnect will use an invalid sdkSessionId.\n\nNavigate away and back to a task to trigger the error.",
-                });
-              },
-            },
           ],
         },
       ],

apps/twig/src/main/services/agent/service.ts

@@ -232,31 +232,6 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
     return count;
   }
 
-  /**
-   * Flag to force invalid sdkSessionId on next reconnect (dev tool for testing error handling).
-   */
-  private forceInvalidSdkSessionId = false;
-
-  /**
-   * Enable forcing an invalid sdkSessionId on the next reconnect.
-   * This triggers the "No conversation found" error for testing.
-   */
-  public setForceInvalidSdkSessionId(enabled: boolean): void {
-    this.forceInvalidSdkSessionId = enabled;
-    log.info("Force invalid sdkSessionId", { enabled });
-  }
-
-  /**
-   * Check and consume the forceInvalidSdkSessionId flag.
-   */
-  private consumeForceInvalidSdkSessionId(): boolean {
-    if (this.forceInvalidSdkSessionId) {
-      this.forceInvalidSdkSessionId = false;
-      return true;
-    }
-    return false;
-  }
-
   /**
    * Respond to a pending permission request from the UI.
    * This resolves the promise that the agent is waiting on.
@@ -436,44 +411,22 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       const mcpServers = this.buildMcpServers(credentials);
 
       if (isReconnect) {
-        // Dev tool: force invalid sdkSessionId to test error handling
-        const effectiveSdkSessionId = this.consumeForceInvalidSdkSessionId()
-          ? "00000000-0000-0000-0000-000000000000"
-          : sdkSessionId;
-
-        if (effectiveSdkSessionId !== sdkSessionId) {
-          log.warn("Using forced invalid sdkSessionId for testing", {
-            original: sdkSessionId,
-            forced: effectiveSdkSessionId,
-          });
-        }
-
-        try {
-          await connection.extMethod("_posthog/session/resume", {
-            sessionId: taskRunId,
-            cwd: repoPath,
-            mcpServers,
-            _meta: {
-              ...(logUrl && {
-                persistence: { taskId, runId: taskRunId, logUrl },
-              }),
-              ...(effectiveSdkSessionId && {
-                sdkSessionId: effectiveSdkSessionId,
-              }),
-              ...(additionalDirectories?.length && {
-                claudeCode: {
-                  options: { additionalDirectories },
-                },
-              }),
-            },
-          });
-        } catch (resumeError) {
-          log.error("Failed to resume session via extMethod", {
-            taskRunId,
-            error: resumeError,
-          });
-          throw resumeError;
-        }
+        await connection.extMethod("_posthog/session/resume", {
+          sessionId: taskRunId,
+          cwd: repoPath,
+          mcpServers,
+          _meta: {
+            ...(logUrl && {
+              persistence: { taskId, runId: taskRunId, logUrl },
+            }),
+            ...(sdkSessionId && { sdkSessionId }),
+            ...(additionalDirectories?.length && {
+              claudeCode: {
+                options: { additionalDirectories },
+              },
+            }),
+          },
+        });
       } else {
         await connection.newSession({
           cwd: repoPath,