Desync when attack move on a building that can't be targeted

[Coronia]

Description

this issue is confirmed to be introduced by #2095

when using attack move command to target a building, if the selected objects cannot target this building (either by armor versus, Iron Curtain or such), a desync will happen

Phobos Version

all develop nightly since https://github.com/Phobos-developers/Phobos/actions/runs/21818616748/artifacts/5429244581

Conditions to reproduce

No response

INI code

Steps to reproduce

1. run a multiplayer game
2. build units that can't target building (f.ex. Terror Drone)
3. select them and attack move on a building

Expected behaviour

no desync

Actual behaviour

desync happens as long as the command is given

Additional context

Checklist

• The issue happens on the latest official version of Phobos and wasn't fixed yet.
• I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
• I added a very descriptive title to this issue.
• I used the GitHub search and read the issue list to find a similar issue and didn't find it.
• I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

[Coronia]

update: when the desync happens, there's sometime a visible position mismatched for different players. So this might be the direct reason of it

If there's no proper solution in the nearest future, maybe we should evaluate the impact of disabling this commit and reverting it temporarily.

[TaranDahl]

there's sometime a visible position mismatched for different players

Your screenshot should have nothing to do with this, right?

[TaranDahl]

I have no idea about the reason for desync. That code looks fine to me.

[Coronia]

there's sometime a visible position mismatched for different players

Your screenshot should have nothing to do with this, right?

it is, it's the same game under different players' perspective. As you can see the position of these Terror Drones are clearly mismatched

[TaranDahl]

Then why are their colors different? And both of you players can mass select them?🤔
Also, how do they manage to have such a large difference in position? According to my understanding, the game takes the Location into account when calculating the CRC, and the game should crash on the first frame when the positions are out of sync.

[Coronia]

my bad, the pic is from 2 games. Updated the one above, and here's another

[TaranDahl]

Can you record a screen to confirm when the positions started to be out of sync?
I can't understand why the positions are so different.
As I understand it, they can move in different directions for at most 1 frame, and then the game will detect desync and crash in the next frame.

[Refailure]

These are the perspectives of both sides in the same test,It is clearly visible that the number and positions of the moving units are different.

[Coronia]

update: the above behavior will only happen if this is the first command that's given to the units. Once you make another command previously, it won't be out of sync when attack move to a building that can't be targeted

[fagonghaiwo]

Im not sure, and another problem
when units attack move a can't target building, they return back

update: the above behavior will only happen if this is the first command that's given to the units. Once you make another command previously, it won't be out of sync when attack move to a building that can't be targeted

[Coronia]

The problematic commit has been reverted