default search path contains `~` or FitBuilder.autoloadFits() should break early

[jcalbert]

OSPRuntime.getDefaultSearchPaths() should not include ~ or FitBuilder.autoloadFits() should break early if xml files do not have `

The issue

Absent the preference autoload_search_paths, OSP includes the user home directory as a default search path.

Within the FitBuilder constructor, the function FitBuilder.autoloadFits() tries to read all .xml files in all search paths. This is problematic, especially if one has, say, a 1.6GB file of Arxiv.org metadata called ~/arxiv-meta.xml .

I think that ~ shouldn't be a search path in the first place. Either way, I think that in
osp/src/org/opensourcephysics/controls/XMLControlElement.java
the function readObject should contain a check. After :

osp/src/org/opensourcephysics/controls/XMLControlElement.java

Lines 1397 to 1410 in d809dbe

	private XMLControlElement readObject(XMLControlElement control, String xml) throws IOException {
	control.clearValues();
	// set class name
	xml = xml.substring(xml.indexOf("class=")+7); //$NON-NLS-1$
	String className = xml.substring(0, xml.indexOf("\"")); //$NON-NLS-1$
	// workaround for media package name change
	int i = className.lastIndexOf("."); //$NON-NLS-1$
	if(i>-1) {
	String packageName = className.substring(0, i);
	if(packageName.endsWith("org.opensourcephysics.media")) { //$NON-NLS-1$
	className = packageName+".core"+className.substring(i); //$NON-NLS-1$
	}
	}
	control.className = className;

the function should assert packageName.startsWith("org.opensourcephysics").

[dobrown]

Thanks for your comments, J.  I don't want to remove ~ from the default search paths because some users do currently save fit functions there. I agree it should not be reading entire xml files which is what it appears to do now in the XMLControlElement.readInput method. So your 1.6GB file took forever to read?  I've added code to the XMLControlElement.readInput method that aborts after 10 lines if no recognizable osp element is found. This should fix the problem, right?  (The XMLControlElement.readObject method is not the right place to check since the package name can be anything and be correct.) I'll upload the code tomorrow. Cheers! Doug

…

On 9/9/2017 4:21 PM, J. wrote: |OSPRuntime.getDefaultSearchPaths()| should not include |~| /or/ |FitBuilder.autoloadFits()| should break early if xml files do not have ` The issue Absent the preference |autoload_search_paths|, OSP includes the user home directory as a default search path. Within the |FitBuilder| constructor, the function |FitBuilder.autoloadFits()| tries to read all |.xml| files in all search paths. This is problematic, especially if one has, say, a 1.6GB file of Arxiv.org metadata called |~/arxiv-meta.xml|. I think that |~| shouldn't be a search path in the first place. Either way, I think that in |osp/src/org/opensourcephysics/controls/XMLControlElement.java| the function |readObject| should contain a check. After : https://github.com/OpenSourcePhysics/osp/blob/d809dbe37e4b628cff462f7e9e78d1c667350bb3/src/org/opensourcephysics/controls/XMLControlElement.java#L1397-L1410 the function should assert |packageName.startsWith("org.opensourcephysics")|. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC6AlO6HBdo0OPl4jiGg1I_ejva2ZgTqks5sgx13gaJpZM4PSJjm>.

-- You can't control the wind, but you can adjust your sails --Yiddish proverb