Status calculation is wrong in Bitwig.midiOut

[a8t]

Sorry, this isn't an issue, more of a question.

On this line:

loopstrument/src/Bitwig.ts

Line 39 in a65e668

const status = type << (4 + channel);

Can you explain adding channel here? Doesn't it shift the type bits too far?

According to the Linnstrument midi docs, CC should be 1011cccc where c is the channel. To me, this should be const status = type << 4 | channel);, where the << shifts 4 spaces left and | channel flips the appropriate bits to set the channel.

But... it seems your code works.

What do you think?

[a8t]

Sorry, I see why it's not breaking now. Channel is always 0 in the codebase :D

[OliverLSanz]

Hey, sorry for the late answer. I've forgot about this and just remembered it now that I received the "issue closed" mail.

You are right, this should be const status = type << 4 | channel);. I reopen the issue so I fix it when I have time to come back to this project.

If you have more questions or suggestions, feel free to drop them here or by email to oliverlsanz@gmail.com