Skip to content

Bugfix: Replacing version catalog dependencies references#23

Merged
kdroidFilter merged 1 commit into
NucleusFramework:mainfrom
tuuhin:bugfix/dependency-resolution
May 14, 2026
Merged

Bugfix: Replacing version catalog dependencies references#23
kdroidFilter merged 1 commit into
NucleusFramework:mainfrom
tuuhin:bugfix/dependency-resolution

Conversation

@tuuhin
Copy link
Copy Markdown
Contributor

@tuuhin tuuhin commented May 14, 2026

🚀 Description

As version catalog is not published along side with a plugin into maven. While using the plugin on a different project , it cannot include references for kotlinx-coroutines, it can though build if the version-catalog for dependencies are written the same.

Fix

Dependencies kotlinx-coroutines with version references with catalog if one is found otherwise using 1.11.0. Same for the embedded-kotlin using the project kotlin version

🧪 How Has This Been Tested?

  • Run examples
  • Run Benchmark test

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

As version catalog is not published with a plugin into maven,cannot include references for kotlinx-coroutines dependencies
hardcoded dependencies and included a version fallback
Removed VersionCatalog.kt extensions
@tuuhin
Copy link
Copy Markdown
Contributor Author

tuuhin commented May 14, 2026

Checked running the module locally via mavenLocal
Working now !!

@kdroidFilter kdroidFilter merged commit b2b4018 into NucleusFramework:main May 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants