Unresolved Comments from Wind Layout Feature-Adds

[elenya-grant]

Unresolved Comments from Wind Layout Feature-Adds

This issue includes some unresolved feedback and comments from PR #429, #431, #433, and #435. This issue will get updated as reviews for these PRs are completed.

Unresolved feedback from PR #429

• [/] consistent use of whitespace (in progress)
• doc string descriptions should be treated like sentences for punctuation and casing because their end format will show as that, rather than the basic list-style we typically see.
• in hopp/simulation/technologies/layout/wind_layout.py it might be easier to get the rotor diameter as a variable given how long the retrieval call is
• hopp/simulation/technologies/layout/wind_layout_tools.py in subtract_turbine_exclusion_zone: Would it not be more realistic to extend a row/string of turbines than to add a new row if the constraint is not on the cable capacities? Originally posted by @RHammond2 in Intermediate: update to wind layout and floris functions (1/2) #429 (comment)
• hopp/tests/test_layout.py add high level tests for all the layout options (boundarygrid, grid, custom, basicgrid). Also included in Issue Feature request: Expand tests for wind layout methods #434
• investigate negative npvs in tests/hopp/test_hybrid.py for floris test. Also included in Issue Bug report: Check negative NPVs with Floris #437
• check that all TODOs and NOTEs are resolved or put into an issue in hopp/simulation/technologies/layout/wind_layout.py

Unresolved feedback from PR ##431

• in hopp/tests/test_layout.py in test_wind_basic_grid_layout_floris_default: it might be more straightforward to compare the two lists outright by using the assert line as-is, just without the indexing.

Unresolved feedback from PR #433

• [ ]

Remaining To-dos for PR #435

• add tests for write_turbine_to_floris_file()
• add tests for write_floris_layout_to_file()
• integrate writing turbine files into WindPlant and floris.py
• add comments to new tests.
• general clean up of doc strings and comments.
• add test for updating turbine model after floris has been initialized.