|
| 1 | +OSCILOS is being developed for research. Please [join us](http://www.oscilos.com/)!. |
| 2 | + |
| 3 | +## Git and Pull requests |
| 4 | +* Contributions are welcome. For outside users, they can be submitted with GitHub pull request, and will be reviewed and accepted by the team. The project uses the Fork & Pull model; for more details see [here](https://help.github.com/articles/using-pull-requests). |
| 5 | +* Internal developers have write access to the branches, and can merge changes themselves. They do not need to make Pull requests. |
| 6 | +* The project uses the [GitFlow branching model](http://nvie.com/posts/a-successful-git-branching-model/). As such please make a new branch for every feature you are working on. |
| 7 | +* Internal developers should merge Bugfixes and Hotfixes to `master-private` and `develop`. |
| 8 | +* After a release is made to `master-private`, or a Bugfix/Hotfix is implemented, changes in `master-private` should be merged in the public repo. `master` branch. |
| 9 | +* The latest changes available to users outside of MorgansLab are in the public repo. `master` branch. To have access to newer bug fixes or become a collaborator, contact the repo. admin. |
| 10 | +* Make sure your commit messages are clear. The first line should be a summary of the commit, following lines should contain details about the mentioned changes. |
| 11 | +* Please avoid using re-basing and fast forward merges. |
| 12 | + |
| 13 | +## Coding style and version numbering |
| 14 | +* Use a lot of comments; more is better than not enough. |
| 15 | +* Indent your code using the Matlab automated indent feature. |
| 16 | +* When incrementing the version number, please stick to the [Semantic Versioning Standards](http://semver.org/) |
| 17 | + |
| 18 | +## Documentation |
| 19 | +* The documentation can be found in the [docs](docs) folder. |
| 20 | + |
| 21 | +## Logging issues and fixing issues |
| 22 | +* Please log any issues you find [here](https://github.com/MorgansLab/OSCILOS-Long-1-3/issues), and don't forget to say what version of Matlab you are using, and what OS. |
| 23 | +* Label your issue as a `bug`, `enhancement` etc. |
| 24 | +* Developers working on an issue should assign themselves the issue before starting any work. |
| 25 | +* Corrections for `bug` issues should be done using GitFlow Hotfix or Bugfix, or in a release branch. |
| 26 | +* When committing to correct an issue, use the wording `Fixes #1` or `Resolves #1` or `Closes #1`. Doing this will automatically [close issue Number 1, and link to the relevant commit](https://help.github.com/articles/closing-issues-via-commit-messages/) |
| 27 | +* Use the template below when logging issues: |
| 28 | + |
| 29 | +```` |
| 30 | +*Matlab Version : r2014a* |
| 31 | +*OS : Windows 8.1* |
| 32 | +*Commit: 86f0a46d3e01461926622151eb9fff689c677321* |
| 33 | +
|
| 34 | +## Observed behaviour |
| 35 | +When selecting a temperature ratio across the flame of 1 (not a plausible configuration, but hey) the plotting shows error |
| 36 | +
|
| 37 | +### Error message |
| 38 | +
|
| 39 | +\`\`\`\` |
| 40 | +Error using set |
| 41 | +Bad property value found. |
| 42 | +Object Name: axes |
| 43 | +Property Name: 'YLim' |
| 44 | +Value must be a 2 element vector. |
| 45 | +
|
| 46 | +Error in GUI_INI_TP>Fcn_GUI_INI_TP_PLOT (line 1250) |
| 47 | + set(hAxes1,'ylim',[ymin ymax]) |
| 48 | +
|
| 49 | +Error in GUI_INI_TP>pb_Plot_Callback (line 480) |
| 50 | +Fcn_GUI_INI_TP_PLOT(hObject) |
| 51 | +
|
| 52 | +Error in gui_mainfcn (line 95) |
| 53 | + feval(varargin{:}); |
| 54 | +
|
| 55 | +Error in GUI_INI_TP (line 42) |
| 56 | + gui_mainfcn(gui_State, varargin{:}); |
| 57 | +
|
| 58 | +Error in |
| 59 | +@(hObject,eventdata)GUI_INI_TP('pb_Plot_Callback',hObject,eventdata,guidata(hObject)) |
| 60 | +
|
| 61 | + |
| 62 | +Error using waitfor |
| 63 | +Error while evaluating uicontrol Callback |
| 64 | +\`\`\`\` |
| 65 | +
|
| 66 | +## Expected behaviour |
| 67 | +Ylim should be adjusted when the plot is a horizontal line |
| 68 | +```` |
0 commit comments