Can't edit or update yaml sometimes

[mdavis-xyz]

Symptoms

Sometimes when I try to change the number of replicas (either with kubectl apply -f ./ or kubectl edit deployment bono) I get an error:

$ k edit deployment ellis
A copy of your changes has been stored to "/tmp/kubectl-edit-nf7qp.yaml"
error: map: map[] does not contain declared merge key: name

Impact

I have to delete the deployment, then recreate it with the new number of recplicas

Release and environment

Using PR #88

Steps to reproduce

1. Deploy CW, no secret for registry authentication

      imagePullSecrets:
      - name: ~
   

2. kubectl edit deployment ellis

3. change the number of replicas

Cause

I'm pretty sure that the empty imagePullSecrets value I wrote in PR #88 is not as valid as I thought. It deploys fine, but has this merging issue. See this post

So I need to update PR #88 to make it not add any imagePullSecrets when there's no registry authentication required. I'll fix this some time this week.

For now, if anyone runs into this issue, just delete the following lines from your yaml files:

      imagePullSecrets:
      - name: ~