phase36(display-engine): polish row UX and dynamic state boundary#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase36 expands the Modern DisplayEngine row-polish branch from the initial FormModel row accent slice into a coherent DisplayEngine UX/data-boundary batch.
This keeps edk2 FormBrowser as the owner of HII/IFR/ConfigAccess semantics and keeps Modern DisplayEngine focused on rendering already-materialized state.
UX / rendering
LIVE VIEWLIVE REFRESHUNSAVED CHANGESREBOOT REQUIREDreserved stateMODAL VIEWDynamic data / config boundary
Files
Library/ModernUiCustomizedDisplayLib/CustomizedDisplayLibInternal.cLibrary/ModernUiEngineLib/ModernUiEngineLib.cDocs/DisplayEngineDynamicDataFlow.mdDocs/DisplayEngineDynamicDataFlow.zh-CN.mdTests/Smoke/smoke_validate.pyCHANGELOG.mdValidation
python3 Tests/Smoke/smoke_validate.pygit diff --checkTARGET=RELEASE MODERN_SETUP_DISPLAY_ENGINE=modern MODERN_SETUP_REPLACE_UIAPP=1 Scripts/build-ovmf-x64.shScripts/xarch-validate.sh --all --mode dry-runCapture evidence root:
Captured images:
Visual sanity:
Boundary notes
This PR intentionally does not add:
SetVariableRouteConfig/ExtractConfigHiiSetBrowserDataConfigAccessREBOOT REQUIREDis a reserved display state only. It is not inferred from generic unsaved state until a real platform/FormBrowser source is wired.