phase35(display-engine): add native-modern visual validation workflow#31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这是干什么了?
Phase35 建立 DisplayEngine 的 native-vs-modern FormBrowser 截图验证路径。它不是继续改视觉细节,而是先把 A/B 证据链固定下来,后续 Phase36/row polish 才能用同一套 OVMF X64 工作流对比 native DisplayEngine 和 ModernDisplayEngine。
摘要
Scripts/capture-displayengine-ovmf-x64.sh:--mode dry-run|generate-only|build|captureMODERN_SETUP_DISPLAY_ENGINE=native和modern驱动既有 OVMF overlay/build/capture 脚本${TMPDIR:-/tmp}/modernsetup-qemu/displayengine-ovmf-x64overlays/native、overlays/modern、firmware/native、firmware/modern、native/、modern/SENDKEY_SEQUENCE=esc,ret,进入 OVMFEFI Firmware SetupFormBrowser surfaceTests/Manual/DisplayEngineOvmfX64Visual.md:说明证据级别、手动 review checklist、已知限制。边界
ModernUiHiiBridgeLib。/tmp。验证
bash -n Scripts/capture-displayengine-ovmf-x64.shPASSScripts/capture-displayengine-ovmf-x64.sh --mode dry-runPASSCAPTURE_OUT_DIR=/tmp/modernsetup-phase35-generate Scripts/capture-displayengine-ovmf-x64.sh --mode generate-onlyPASSMdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.infModernSetupPkg/Universal/ModernDisplayEngineDxe/ModernDisplayEngineDxe.infCAPTURE_OUT_DIR=/tmp/modernsetup-phase35-build TARGET=RELEASE MODERN_SETUP_REPLACE_UIAPP=0 Scripts/capture-displayengine-ovmf-x64.sh --mode buildPASSOVMF_CODE.fdsnapshotsCAPTURE_OUT_DIR=/tmp/modernsetup-phase35-capture2 TARGET=RELEASE MODERN_SETUP_REPLACE_UIAPP=0 BOOT_WAIT_SECONDS=6 Scripts/capture-displayengine-ovmf-x64.sh --mode capturePASS.ppmand.pngscreendumpspython3 Tests/Smoke/smoke_validate.pyPASSScripts/xarch-validate.sh --all --mode dry-runPASSgit diff --checkPASS后续
Phase36 可以基于这个 A/B capture path 做具体 FormBrowser row visual polish,并把每次视觉变化配套 native-vs-modern screenshots。