phase34(display-engine): harden row rendering state model#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这是干什么了?
Phase33 只是加了私有 FormModel 中间层;Phase34 开始让 DisplayEngine 的 row surface 真正消费这个模型。
这不是完整视觉重写,也不是 HiiBridge 上位。它做的是把 FormBrowser 已经算好的 form/statement 状态统一归类成 Modern UI row role,让后续 row rendering polish 不再散落在
DisplayOneMenu()的 ad-hoc 判断里。摘要
ModernDisplayFormModelrow state:highlighted/selected、disabled/locked、read-only、changed、invalid、modal、page changed。ModernDisplayDrawStatementRow()现在接收FormData + Statement,内部通过 FormModel 映射到ModernUiRowRole。DisplayOneMenu()移除本地IsActionRow/IsSubtitleRow分散判断,交给 CustomizedDisplayLib 私有模型。边界
ModernUiHiiBridgeLib。验证
python3 Tests/Smoke/smoke_validate.pyPASSScripts/xarch-validate.sh --all --mode dry-runPASSgit diff --checkPASSTARGET=RELEASE MODERN_SETUP_DISPLAY_ENGINE=modern MODERN_SETUP_REPLACE_UIAPP=1 Scripts/build-ovmf-x64.shPASS后续