Skip to content

phase29(app): apply DashboardDensity to Dashboard layout#22

Merged
MarsDoge merged 2 commits into
mainfrom
phase29/dashboard-density-layout
May 22, 2026
Merged

phase29(app): apply DashboardDensity to Dashboard layout#22
MarsDoge merged 2 commits into
mainfrom
phase29/dashboard-density-layout

Conversation

@MarsDoge
Copy link
Copy Markdown
Owner

Summary

  • Makes the app-owned DashboardDensity preference drive the ModernSetupApp Dashboard layout.
  • Keeps Comfortable as the existing spacious layout and makes Compact reduce the top summary area plus quick-card spacing.
  • Routes Dashboard keyboard navigation through the same density-aware grid used by rendering, preventing visual/selection geometry drift.
  • Adds a Phase29 smoke guard for the density-aware layout contract and no HII/ConfigAccess/SetVariable regression.

Validation

  • PASS python3 Tests/Smoke/smoke_validate.py
  • PASS git diff --check main..HEAD
  • PASS ARCH=X64 Scripts/build-modern-app.sh
  • PASS WORKSPACE=/home/qdy/ModernSetupPkg/External/edk2 ARCH=LOONGARCH64 GCC_LOONGARCH64_PREFIX=loongarch64-linux-gnu- JOBS=12 Scripts/build-modern-app.sh
  • PASS Claude Code final diff review
  • PASS QEMU OVMF X64 screenshot capture: Dashboard Compact layout, no #PF/ASSERT/crash observed

Screenshot

  • Telegram message_id: 549
  • Local capture: /tmp/modernsetup-qemu/phase29-dashboard-compact.png

@MarsDoge MarsDoge merged commit a1bc7c2 into main May 22, 2026
1 check passed
@MarsDoge MarsDoge deleted the phase29/dashboard-density-layout branch May 22, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant