Skip to content

Commit 1b81ce7

Browse files
Guard clauses prior to event listeners that may not be present
1 parent e5adb8e commit 1b81ce7

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

app/javascript/filters.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ function initFilterToggle() {
33
var filter_toggle = document.getElementById('filter-toggle');
44
var filter_panel = document.getElementById('filter-container');
55
var filter_categories = document.getElementsByClassName('filter-category');
6+
7+
// No need for event listeners if filters aren't present.
8+
if (!filter_toggle || !filter_panel) {
9+
return;
10+
}
11+
612
filter_toggle.addEventListener('click', event => {
713
filter_panel.classList.toggle('hidden-md');
814
filter_toggle.classList.toggle('expanded');

app/javascript/search_form.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ if (Array.from(allPanels).includes(geoboxPanel && geodistancePanel)) {
6868
togglePanelState(geodistancePanel);
6969
});
7070

71-
document.getElementById('advanced-summary').addEventListener('click', () => {
71+
document.getElementById('advanced-summary')?.addEventListener('click', () => {
7272
togglePanelState(advancedPanel);
7373
});
7474
} else {
75-
document.getElementById('advanced-summary').addEventListener('click', () => {
75+
document.getElementById('advanced-summary')?.addEventListener('click', () => {
7676
togglePanelState(advancedPanel);
7777
});
7878
}

0 commit comments

Comments
 (0)