[repo-monitor] Medium: proxies HashMap in FetcherConfig declared but never applied

[Liohtml]

Summary

FetcherConfig has a proxies: HashMap<String, String> field that is never read or applied to the HTTP client. Users who configure per-protocol proxies will get no proxying at all with no error.

Location

• File: src/fetchers/config.rs
• Line(s): 14

Severity

Medium

Details

The proxy: Option<String> field is applied (single proxy), but proxies: HashMap<String, String> has no builder method and is never read in client.rs. Any user who sets config.proxies expecting per-protocol routing will silently get no proxying.

Suggested Fix

Either remove proxies if unimplemented:

// remove from FetcherConfig

Or implement it:

for (scheme, proxy_url) in &config.proxies {
    // apply per-scheme proxy routing
}

---

Automated finding by repo-monitor

[Liohtml]

Analysis

Confirmed. src/fetchers/config.rs:14: pub proxies: HashMap<String, String> exists on FetcherConfig and is initialized in Default. But src/fetchers/client.rs only consults config.proxy (the single-URL field). The proxies HashMap is never read.

This is the same class of bug as RUSTJobSpy's proxy issue — a public API that accepts proxy configuration and silently ignores it.

The right path depends on what you want proxies to mean:

Option A — Per-protocol proxies (like curl's --proxy map): {"http": "http://proxy:8080", "https": "http://proxy:8080"}. This is what the field name suggests. Implementation:

// In client.rs, when building reqwest::Client:
for (scheme, proxy_url) in &config.proxies {
    match scheme.as_str() {
        "http" => builder = builder.proxy(reqwest::Proxy::http(proxy_url)?),
        "https" => builder = builder.proxy(reqwest::Proxy::https(proxy_url)?),
        "all" | "*" => builder = builder.proxy(reqwest::Proxy::all(proxy_url)?),
        _ => tracing::warn!("Unknown proxy scheme: {scheme}"),
    }
}

Option B — Remove proxies, keep only proxy: If ProxyRotator (the per-request rotation logic) is how users are meant to rotate proxies, then FetcherConfig.proxies is redundant. Remove it and document that proxy rotation uses ProxyRotator.

I'd clarify the intended use case before implementing either option. The field name proxies is ambiguous between "per-protocol map" and "rotation pool."

Effort: 15 min to remove the dead field, or 45 min to implement per-protocol proxy routing.