Skip to content

fix: make PYTHONPATH test assertion repo-name agnostic #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simongonzalezdc merged 2 commits into from
May 27, 2026
Merged

fix: make PYTHONPATH test assertion repo-name agnostic #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb5fca1
fix: make PYTHONPATH test assertion repo-name agnostic
simongonzalezdc May 27, 2026
e9fa64e
fix: use os.pathsep in PYTHONPATH test assertion
simongonzalezdc May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/test_cli_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,13 @@ def fake_run(cmd, **kwargs):
assert db_builder_calls, "db.builder was never invoked"
env = db_builder_calls[0]["env"]
assert "PYTHONPATH" in env
assert "archaeology" in env["PYTHONPATH"] or "DEV-ARCH" in env["PYTHONPATH"]
# PYTHONPATH is set to the package root (Path(__file__).parent.parent)
# which varies by checkout name — verify it's an absolute path containing
# the archaeology package directory, not a hardcoded repo name.
pp = env["PYTHONPATH"]
assert os.path.isabs(pp.split(os.pathsep)[0]), (
f"PYTHONPATH should start with an absolute path, got: {pp}"
)


# ── analyze (unknown vector) ──────────────────────────────────────────────────
Expand Down
Loading