Skip to content

Install local package in archaeology workflow#36

Merged
simongonzalezdc merged 1 commit into
mainfrom
fix/archaeology-install-local-package
May 24, 2026
Merged

Install local package in archaeology workflow#36
simongonzalezdc merged 1 commit into
mainfrom
fix/archaeology-install-local-package

Conversation

@simongonzalezdc
Copy link
Copy Markdown
Member

@simongonzalezdc simongonzalezdc commented May 24, 2026

Summary

  • changes the archaeology workflow install step from pip install devarch-framework to pip install -e .
  • moves the archaeology job to the repo-required blacksmith-2vcpu-ubuntu-2404 runner label
  • declares that custom runner label in .github/actionlint.yaml so local workflow lint remains explicit

Why

After #35, the scheduled workflow got past the old actions/setup-python cache failure. A targeted manual dispatch on main then exposed the next blocker: the package is not published to PyPI as devarch-framework, so the workflow failed during install before DevArch could run.

Installing the checked-out repository matches this repo's normal CI path and keeps the scheduled archaeology report self-contained.

Fixes #34.

Verification

  • actionlint .github/workflows/archaeology.yml
  • git diff --check
  • temporary venv: pip install -e . then devarch --help
  • PR CI run 26354238374 passed: lint plus Linux/macOS/Windows Python 3.10/3.11/3.12 matrix
  • failing confirmation run before this PR: https://github.com/KyaniteLabs/devarch-framework/actions/runs/26354075200 passed Set up Python and failed at Install DevArch with No matching distribution found for devarch-framework

Empower Orchestrator checklist

  • I checked whether this PR reveals a repeatable task or recurring agent failure.
  • If it does, I either shipped the smallest durable improvement or documented why not.
  • Any automation or durable system change included the scale/severity/reversibility/predictability blast-radius check.
  • Workers/subagents stayed inside their assigned scope and verification evidence is included before completion claims.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c823c7ba-deaf-47cc-8db4-8b7703c06f6f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d55663 and c548eda.

📒 Files selected for processing (2)
  • .github/actionlint.yaml
  • .github/workflows/archaeology.yml

📝 Walkthrough

Walkthrough

The PR updates the archaeology workflow to run on the blacksmith-2vcpu-ubuntu-2404 runner and changes the "Install DevArch" step to install the repository in editable mode (pip install -e .) so subsequent archaeology steps use the checked-out source.

Changes

CI Workflow Configuration

Layer / File(s) Summary
Runner label and actionlint mapping
.github/actionlint.yaml, .github/workflows/archaeology.yml
The archaeology job's runs-on label is changed to blacksmith-2vcpu-ubuntu-2404, and actionlint config adds a self-hosted-runner.labels entry for the same runner label.
Install DevArch in editable mode
.github/workflows/archaeology.yml
The "Install DevArch" step command is changed from pip install devarch-framework to pip install -e ., installing the repository in editable mode for downstream archaeology steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a clear summary, rationale, and verification steps, but does not include the required Empower Orchestrator checklist sections from the template. Add the Empower Orchestrator checklist from the template to ensure compliance with repository standards.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and specifically describes the main change: installing a local package (via pip install -e .) instead of a published package in the archaeology workflow.
Linked Issues check ✅ Passed The PR directly addresses issue #34 by fixing the DevArch Archaeology Report workflow to use pip install -e . instead of the unavailable PyPI package, matching the acceptance criteria.
Out of Scope Changes check ✅ Passed All changes are narrowly scoped to fixing the archaeology workflow install step and updating actionlint configuration, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/archaeology-install-local-package

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/archaeology.yml (1)

25-25: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use blacksmith-2vcpu-ubuntu-2404 runner instead of ubuntu-latest.

The workflow uses ubuntu-latest but the coding guideline requires all CI runs to use blacksmith-2vcpu-ubuntu-2404 runners.

🔧 Proposed fix
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404

As per coding guidelines: All CI runs must use blacksmith-2vcpu-ubuntu-2404 runners.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/archaeology.yml at line 25, Replace the runs-on value in
the workflow's job definition: locate the runs-on: ubuntu-latest entry and
change it to runs-on: blacksmith-2vcpu-ubuntu-2404 so the CI uses the mandated
runner; ensure spacing and YAML indentation for the runs-on key remains
consistent with the rest of the job definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/archaeology.yml:
- Line 25: Replace the runs-on value in the workflow's job definition: locate
the runs-on: ubuntu-latest entry and change it to runs-on:
blacksmith-2vcpu-ubuntu-2404 so the CI uses the mandated runner; ensure spacing
and YAML indentation for the runs-on key remains consistent with the rest of the
job definition.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a7a551f4-83c2-4480-869d-a0c9f2fb03cd

📥 Commits

Reviewing files that changed from the base of the PR and between c4ebdf1 and 1d55663.

📒 Files selected for processing (1)
  • .github/workflows/archaeology.yml

The scheduled/manual report lane cannot depend on a non-published PyPI package, and it must use the repo-mandated Blacksmith runner label. Declare the custom runner to actionlint so the runner contract stays visible to local verification.

Constraint: devarch-framework is not published on PyPI and AGENTS.md requires blacksmith-2vcpu-ubuntu-2404 for CI.

Rejected: pip install devarch-framework | fails while package is unpublished.

Rejected: leave ubuntu-latest | violates repo CI runner contract and CodeRabbit review.

Confidence: high

Scope-risk: narrow

Directive: Keep this workflow installing the checked-out repository unless publishing is added deliberately.

Tested: actionlint .github/workflows/archaeology.yml; git diff --check; temporary venv pip install -e . and devarch --help.

Not-tested: branch CI after final review-addressing commit, pending GitHub rerun.
@simongonzalezdc simongonzalezdc force-pushed the fix/archaeology-install-local-package branch from 1d55663 to c548eda Compare May 24, 2026 06:40
@simongonzalezdc simongonzalezdc merged commit 9638ae6 into main May 24, 2026
12 checks passed
@simongonzalezdc simongonzalezdc deleted the fix/archaeology-install-local-package branch May 24, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pipeline][HIGH] DevArch Archaeology Report fails on default branch

1 participant