Install local package in archaeology workflow#36
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates the archaeology workflow to run on the ChangesCI Workflow Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/archaeology.yml (1)
25-25:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUse blacksmith-2vcpu-ubuntu-2404 runner instead of ubuntu-latest.
The workflow uses
ubuntu-latestbut the coding guideline requires all CI runs to useblacksmith-2vcpu-ubuntu-2404runners.🔧 Proposed fix
- runs-on: ubuntu-latest + runs-on: blacksmith-2vcpu-ubuntu-2404As per coding guidelines: All CI runs must use blacksmith-2vcpu-ubuntu-2404 runners.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/archaeology.yml at line 25, Replace the runs-on value in the workflow's job definition: locate the runs-on: ubuntu-latest entry and change it to runs-on: blacksmith-2vcpu-ubuntu-2404 so the CI uses the mandated runner; ensure spacing and YAML indentation for the runs-on key remains consistent with the rest of the job definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/archaeology.yml:
- Line 25: Replace the runs-on value in the workflow's job definition: locate
the runs-on: ubuntu-latest entry and change it to runs-on:
blacksmith-2vcpu-ubuntu-2404 so the CI uses the mandated runner; ensure spacing
and YAML indentation for the runs-on key remains consistent with the rest of the
job definition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a7a551f4-83c2-4480-869d-a0c9f2fb03cd
📒 Files selected for processing (1)
.github/workflows/archaeology.yml
The scheduled/manual report lane cannot depend on a non-published PyPI package, and it must use the repo-mandated Blacksmith runner label. Declare the custom runner to actionlint so the runner contract stays visible to local verification. Constraint: devarch-framework is not published on PyPI and AGENTS.md requires blacksmith-2vcpu-ubuntu-2404 for CI. Rejected: pip install devarch-framework | fails while package is unpublished. Rejected: leave ubuntu-latest | violates repo CI runner contract and CodeRabbit review. Confidence: high Scope-risk: narrow Directive: Keep this workflow installing the checked-out repository unless publishing is added deliberately. Tested: actionlint .github/workflows/archaeology.yml; git diff --check; temporary venv pip install -e . and devarch --help. Not-tested: branch CI after final review-addressing commit, pending GitHub rerun.
1d55663 to
c548eda
Compare
Summary
pip install devarch-frameworktopip install -e .blacksmith-2vcpu-ubuntu-2404runner label.github/actionlint.yamlso local workflow lint remains explicitWhy
After #35, the scheduled workflow got past the old
actions/setup-pythoncache failure. A targeted manual dispatch onmainthen exposed the next blocker: the package is not published to PyPI asdevarch-framework, so the workflow failed during install before DevArch could run.Installing the checked-out repository matches this repo's normal CI path and keeps the scheduled archaeology report self-contained.
Fixes #34.
Verification
actionlint .github/workflows/archaeology.ymlgit diff --checkpip install -e .thendevarch --helpSet up Pythonand failed atInstall DevArchwithNo matching distribution found for devarch-frameworkEmpower Orchestrator checklist