From e55252c8d40f73cd138aeab906d40be5f5e6b12c Mon Sep 17 00:00:00 2001 From: Eguzki Astiz Lezaun Date: Sat, 23 May 2026 12:08:41 +0200 Subject: [PATCH 1/2] Added the missing RBAC permission to update finalizers on apikeyrequests Signed-off-by: Eguzki Astiz Lezaun --- config/rbac/role.yaml | 6 ++++++ internal/controller/apikeyapproval_controller.go | 1 + 2 files changed, 7 insertions(+) diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml index 87cfec1..b04a3ba 100644 --- a/config/rbac/role.yaml +++ b/config/rbac/role.yaml @@ -39,6 +39,12 @@ rules: - get - patch - update +- apiGroups: + - devportal.kuadrant.io + resources: + - apikeyrequests/finalizers + verbs: + - update - apiGroups: - devportal.kuadrant.io resources: diff --git a/internal/controller/apikeyapproval_controller.go b/internal/controller/apikeyapproval_controller.go index 4fa33c9..7135f5b 100644 --- a/internal/controller/apikeyapproval_controller.go +++ b/internal/controller/apikeyapproval_controller.go @@ -40,6 +40,7 @@ type APIKeyApprovalReconciler struct { // +kubebuilder:rbac:groups=devportal.kuadrant.io,resources=apikeyapprovals,verbs=get;list;watch;update;patch;delete // +kubebuilder:rbac:groups=devportal.kuadrant.io,resources=apikeyrequests,verbs=get;list;watch +// +kubebuilder:rbac:groups=devportal.kuadrant.io,resources=apikeyrequests/finalizers,verbs=update // Reconcile handles reconciling all APIKeyApprovals in a single call. Any resource event should enqueue the // same reconcile.Request containing this controller name, i.e. "apikeyapproval". This allows multiple resource updates to From 9682856dd9f24638b7441ae50639cee0902ba65a Mon Sep 17 00:00:00 2001 From: Eguzki Astiz Lezaun Date: Sat, 23 May 2026 12:29:58 +0200 Subject: [PATCH 2/2] remove unnecessary noisy error log Signed-off-by: Eguzki Astiz Lezaun --- internal/controller/apikeyapproval_controller.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/controller/apikeyapproval_controller.go b/internal/controller/apikeyapproval_controller.go index 7135f5b..ee11dc6 100644 --- a/internal/controller/apikeyapproval_controller.go +++ b/internal/controller/apikeyapproval_controller.go @@ -125,7 +125,6 @@ func (r *APIKeyApprovalReconciler) reconcileOwnerReference(ctx context.Context, // Update the APIKeyApproval with the owner reference if err := r.Update(ctx, approval); err != nil { - logger.Error(err, "Failed to update APIKeyApproval with owner reference") return err }