strm2oas should issue a warning when reading a lef file twice

[stefanottili]

Once again I got bitten by strm2oas's default behavior of:
"read all lef files where the def is located".
When using --lefdef-lefs, I would expect only the listed lef to be read, especially since there is no other indication.

strm2oas --lefdef-map=sample_tech.map --lefdef-lefs=sample_tech.lef,cell.lef sample_def.def k.oas
ERROR: Duplicate MACRO name: cell (inside MACRO) (line=14, cell=, file=cell.lef)

--lefdef-no-implicit-lef is the magic word here ... And I should have known, I ran into this before.

strm2oas --lefdef-map=sample_tech.map --lefdef-lefs=sample_tech.lef,cell.lef --lefdef-no-implicit-lef sample_def.def k.oas

It would be nice if

a) reading implicit lef's wouldn't be the default behavior or
b) one would be getting a warning when lef files are read twice. Without having to use -d=11

strm2oas -d=11 --lefdef-map=sample_tech.map --lefdef-lefs=sample_tech.lef,cell.lef sample_def.def k.oas
Total: started
Reading LEF/DEF map file test_lefdef/sample_tech.map
Reading sample_tech.lef
Reading LEF/DEF file test_lefdef/sample_tech.lef
Reading cell.lef
Reading LEF/DEF file test_lefdef/cell.lef
Reading test_lefdef/sample_tech.lef
Reading LEF/DEF file test_lefdef/sample_tech.lef
Reading test_lefdef/cell.lef
Reading LEF/DEF file test_lefdef/cell.lef
Total: 0 (user) 0 (sys) 0.000999703 (wall) 54.73M (mem)
ERROR: Duplicate MACRO name: cell (inside MACRO) (line=14, cell=, file=cell.lef)
make: *** [duplicate_debug] Error 1

but even -d=11 wouldn't give a hint that one has to use --lefdef-no-implicit-lef to fix this
test_lefdef.tgz

[klayoutmatthias]

I think, not reading implicit LEF's when a list is the easiest solution.

So if someone has a package with DEF+LEF, they could simply read the DEF and LEFs are read implicitly. If you give a list of LEF files, I'd say this is what you want and implicit LEF scanning does not happen.

Does that make sense?

Matthias

[stefanottili]

That will work, "you get what you specify".
That pretty much makes the "--lefdef-no-implicit-lef" option void, no ?

It still would be nice to get a fat warning when reading a file twice.