Skip to content

feat: add NeoForge client rendering support #373

Open
AdolfoCarneiro wants to merge 5 commits into
Indemnity83:mc/26.1from
AdolfoCarneiro:pr/neoforge-client-rendering
Open

feat: add NeoForge client rendering support #373
AdolfoCarneiro wants to merge 5 commits into
Indemnity83:mc/26.1from
AdolfoCarneiro:pr/neoforge-client-rendering

Conversation

@AdolfoCarneiro
Copy link
Copy Markdown
Contributor

 ## Summary                                                                                                                                                                              
                                                                                                                                                                                         
 Moves shared client renderers into the common client source set and wires the NeoForge client setup, model loader, and block entity renderers.                                          
                                                                                                                                                                                         
 ## Changes                                                                                                                                                                              
                                                                                                                                                                                         
 - Move reusable pipe and automation renderers into `common/src/client`.                                                                                                                 
 - Add shared render model helpers for pipes, markers, quarry, and cables.                                                                                                               
 - Register NeoForge client setup, model loader, and block entity renderers.                                                                                                             
 - Wire cable block models and engine models for NeoForge.                                                                                                                               
 - Keep Fabric rendering behavior aligned with the shared client code.                                                                                                                   
                                                                                                                                                                                         
 ## Notes                                                                                                                                                                                
                                                                                                                                                                                         
 This PR fixes the invisible pipes and quarry drill issue on NeoForge.

@AdolfoCarneiro AdolfoCarneiro marked this pull request as ready for review May 16, 2026 19:59
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@AdolfoCarneiro has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 8 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7fbe98fa-5869-450b-ae1b-8a60fd27b3af

📥 Commits

Reviewing files that changed from the base of the PR and between 9941b54 and a31078c.

📒 Files selected for processing (56)
  • .gitignore
  • common/src/client/java/com/logistics/LogisticsAutomationClientModels.java
  • common/src/client/java/com/logistics/LogisticsPipeClientModels.java
  • common/src/client/java/com/logistics/automation/render/LaserQuarryBlockEntityRenderer.java
  • common/src/client/java/com/logistics/automation/render/LaserQuarryRenderState.java
  • common/src/client/java/com/logistics/automation/render/MarkerBlockEntityRenderer.java
  • common/src/client/java/com/logistics/automation/render/MarkerRenderState.java
  • common/src/client/java/com/logistics/pipe/render/PipeBlockEntityRenderer.java
  • common/src/client/java/com/logistics/pipe/render/PipeRenderState.java
  • common/src/client/java/com/logistics/pipe/render/RenderProfiler.java
  • common/src/client/java/com/logistics/pipe/render/TravelingItemRenderState.java
  • common/src/client/java/com/logistics/power/render/model/CableGeometry.java
  • common/src/main/java/com/logistics/power/cable/CableBlock.java
  • common/src/main/resources/assets/logistics/blockstates/power/copper_cable.json
  • common/src/main/resources/assets/logistics/blockstates/power/ender_cable.json
  • common/src/main/resources/assets/logistics/blockstates/power/gold_cable.json
  • common/src/main/resources/assets/logistics/models/block/power/creative_engine_bellow.json
  • common/src/main/resources/assets/logistics/models/block/power/creative_engine_piston.json
  • common/src/main/resources/assets/logistics/models/block/power/redstone_engine_bellow.json
  • common/src/main/resources/assets/logistics/models/block/power/redstone_engine_piston.json
  • common/src/main/resources/assets/logistics/models/block/power/stirling_engine_bellow.json
  • common/src/main/resources/assets/logistics/models/block/power/stirling_engine_piston.json
  • fabric/src/client/java/com/logistics/LogisticsAutomationClient.java
  • fabric/src/client/java/com/logistics/LogisticsPipeClient.java
  • fabric/src/client/java/com/logistics/power/render/model/CableModel.java
  • fabric/src/main/resources/assets/logistics/blockstates/power/copper_cable.json
  • fabric/src/main/resources/assets/logistics/blockstates/power/ender_cable.json
  • fabric/src/main/resources/assets/logistics/blockstates/power/gold_cable.json
  • neoforge/build.gradle
  • neoforge/src/main/java/com/logistics/neoforge/LogisticsNeoForge.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgeCapabilityRegistration.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgeChestLootModifier.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgeCommandRegistration.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgeCreativeTabSetup.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgeNetworkTickHandler.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgePacketRegistration.java
  • neoforge/src/main/java/com/logistics/neoforge/NeoForgeServerLevelEvents.java
  • neoforge/src/main/java/com/logistics/neoforge/client/NeoForgeClientSetup.java
  • neoforge/src/main/java/com/logistics/neoforge/client/render/EngineRenderState.java
  • neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeCableBlockModelDefinition.java
  • neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeCableModel.java
  • neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeEngineBlockEntityRenderer.java
  • neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeModelLoader.java
  • neoforge/src/main/java/com/logistics/neoforge/energy/NeoForgeEnergyCapabilityLookup.java
  • neoforge/src/main/java/com/logistics/neoforge/energy/NeoForgeEnergyStorage.java
  • neoforge/src/main/java/com/logistics/neoforge/fluids/NeoForgeFluidKey.java
  • neoforge/src/main/java/com/logistics/neoforge/fluids/NeoForgeFluidStorage.java
  • neoforge/src/main/java/com/logistics/neoforge/platform/NeoForgeCreativeTabRegistrar.java
  • neoforge/src/main/java/com/logistics/neoforge/platform/NeoForgePlatformService.java
  • neoforge/src/main/java/com/logistics/neoforge/platform/NeoForgeRegistryAliasHelper.java
  • neoforge/src/main/java/com/logistics/neoforge/storage/NeoForgeItemKey.java
  • neoforge/src/main/java/com/logistics/neoforge/storage/NeoForgeItemStorage.java
  • neoforge/src/main/resources/assets/logistics/blockstates/power/copper_cable.json
  • neoforge/src/main/resources/assets/logistics/blockstates/power/ender_cable.json
  • neoforge/src/main/resources/assets/logistics/blockstates/power/gold_cable.json
  • neoforge/src/test/java/com/logistics/neoforge/ServiceLoaderSmokeTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant