-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcheck.go
More file actions
437 lines (397 loc) · 12.5 KB
/
check.go
File metadata and controls
437 lines (397 loc) · 12.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
package inspect
import (
"context"
"fmt"
"log/slog"
"regexp"
"strings"
"sync"
"time"
"github.com/GrayCodeAI/inspect/internal/check"
"github.com/GrayCodeAI/inspect/internal/crawler"
)
// Regex timeout constants for ReDoS protection.
const (
regexCompileTimeout = 1 * time.Second
regexMatchTimeout = 100 * time.Millisecond
)
// checkRegexComplexity rejects patterns likely to cause ReDoS. Returns an error
// if the pattern contains nested quantifiers (e.g. (a+)+, (a*)*) or excessive
// group nesting.
func checkRegexComplexity(pattern string) error {
const maxDepth = 5
type groupInfo struct {
hasQuantifier bool
}
var groupStack []groupInfo
inQuantifierAfterGroup := false
for i := 0; i < len(pattern); i++ {
ch := pattern[i]
switch ch {
case '(':
if len(groupStack) >= maxDepth {
return fmt.Errorf("regex group nesting depth exceeds maximum %d", maxDepth)
}
groupStack = append(groupStack, groupInfo{})
inQuantifierAfterGroup = false
case ')':
if len(groupStack) == 0 {
inQuantifierAfterGroup = false
continue
}
g := groupStack[len(groupStack)-1]
groupStack = groupStack[:len(groupStack)-1]
// After closing a group, mark that a quantifier after this ')'
// would be a nested quantifier if the group itself contained one.
inQuantifierAfterGroup = g.hasQuantifier
case '*', '+':
// These are quantifiers.
if len(groupStack) > 0 {
groupStack[len(groupStack)-1].hasQuantifier = true
}
if inQuantifierAfterGroup {
return fmt.Errorf("nested quantifier detected near position %d: quantifier after group containing a quantifier (pattern may cause ReDoS)", i)
}
case '?':
// '?' after '(' or '|' is a group modifier, not a quantifier.
// '?' after another quantifier (e.g. '+?') is a non-greedy modifier.
if i > 0 {
prev := pattern[i-1]
if prev != '(' && prev != '|' && prev != '*' && prev != '+' && prev != '?' {
// This '?' is a quantifier (0-or-1).
if len(groupStack) > 0 {
groupStack[len(groupStack)-1].hasQuantifier = true
}
if inQuantifierAfterGroup {
return fmt.Errorf("nested quantifier detected near position %d: quantifier after group containing a quantifier (pattern may cause ReDoS)", i)
}
}
}
inQuantifierAfterGroup = false
case '{':
// '{' starts a counted repetition like {n}, {n,}, {n,m}.
// This is a quantifier.
if len(groupStack) > 0 {
groupStack[len(groupStack)-1].hasQuantifier = true
}
if inQuantifierAfterGroup {
return fmt.Errorf("nested quantifier detected near position %d: quantifier after group containing a quantifier (pattern may cause ReDoS)", i)
}
default:
inQuantifierAfterGroup = false
}
}
return nil
}
// compileWithTimeout compiles a regex pattern with a timeout to protect against
// pathological compilation times. Returns nil and an error if the pattern is
// rejected by the complexity check or if compilation times out.
func compileWithTimeout(pattern string) (*regexp.Regexp, error) {
if err := checkRegexComplexity(pattern); err != nil {
return nil, err
}
type result struct {
re *regexp.Regexp
err error
}
done := make(chan result, 1)
go func() {
re, err := regexp.Compile(pattern)
done <- result{re, err}
}()
select {
case res := <-done:
return res.re, res.err
case <-time.After(regexCompileTimeout):
return nil, fmt.Errorf("regex compilation timed out after %s", regexCompileTimeout)
}
}
// matchWithTimeout runs re.MatchString(s) with a timeout. Returns false if
// the match does not complete in time, protecting against ReDoS at runtime.
func matchWithTimeout(re *regexp.Regexp, s string) bool {
type result struct {
matched bool
}
done := make(chan result, 1)
go func() {
done <- result{matched: re.MatchString(s)}
}()
select {
case res := <-done:
return res.matched
case <-time.After(regexMatchTimeout):
slog.Warn("regex match timed out, skipping", "pattern", re.String(), "timeout", regexMatchTimeout)
return false
}
}
// findWithTimeout runs re.FindString(s) with a timeout. Returns "" if
// the match does not complete in time.
func findWithTimeout(re *regexp.Regexp, s string) string {
type result struct {
match string
}
done := make(chan result, 1)
go func() {
done <- result{match: re.FindString(s)}
}()
select {
case res := <-done:
return res.match
case <-time.After(regexMatchTimeout):
slog.Warn("regex find timed out, skipping", "pattern", re.String(), "timeout", regexMatchTimeout)
return ""
}
}
// Checker is the public interface for custom checks. Implement this to add
// your own audit logic and register it with RegisterCheck.
type Checker interface {
Name() string
Run(ctx context.Context, pages []*Page) []Finding
}
// Page is the public representation of a crawled page, exposed to custom checks.
type Page struct {
URL string
StatusCode int
Headers map[string]string
Body []byte
Links []PageLink
Depth int
ParentURL string
}
// PageLink represents a link found on a page.
type PageLink struct {
Href string
Text string
External bool
}
// RuleCheck defines a declarative check via patterns — no Go code required.
// This is the equivalent of Nuclei templates but for site auditing.
type RuleCheck struct {
RuleName string
RuleSeverity Severity
Description string
// Match conditions (any match triggers a finding)
HeaderMatch map[string]string // header name → regex pattern (match = issue)
HeaderMissing []string // headers that MUST be present
BodyMatch []string // regex patterns in body (match = issue)
BodyMissing []string // regex patterns that MUST be present
URLMatch string // only apply to URLs matching this regex
StatusCodes []int // only apply to these status codes (empty = all)
FixSuggestion string
}
var (
customChecks []Checker
customRules []RuleCheck
customChecksMu sync.RWMutex
)
// RegisterCheck registers a custom check that will run alongside built-in checks.
// Call this before Scan() to include custom logic.
func RegisterCheck(c Checker) {
customChecksMu.Lock()
customChecks = append(customChecks, c)
customChecksMu.Unlock()
}
// RegisterRule registers a declarative rule-based check.
// Rules are simpler than full Checker implementations — just pattern matching.
func RegisterRule(rule RuleCheck) {
customChecksMu.Lock()
customRules = append(customRules, rule)
customChecksMu.Unlock()
}
// ClearCustomChecks removes all registered custom checks and rules.
// Useful in tests.
func ClearCustomChecks() {
customChecksMu.Lock()
customChecks = nil
customRules = nil
customChecksMu.Unlock()
}
// ruleCheckAdapter adapts a RuleCheck into the internal check.Checker interface.
// Regexes are pre-compiled at construction time for performance.
type ruleCheckAdapter struct {
rule RuleCheck
urlRegex *regexp.Regexp
headerRegexs map[string]*regexp.Regexp
bodyRegexs []*regexp.Regexp
bodyMissing []*regexp.Regexp
}
func newRuleCheckAdapter(rule RuleCheck) *ruleCheckAdapter {
a := &ruleCheckAdapter{rule: rule}
if rule.URLMatch != "" {
re, err := compileWithTimeout(rule.URLMatch)
if err != nil {
slog.Error("rule regex compilation failed (ReDoS protection)", "rule", rule.RuleName, "field", "URLMatch", "pattern", rule.URLMatch, "error", err)
}
a.urlRegex = re
}
a.headerRegexs = make(map[string]*regexp.Regexp, len(rule.HeaderMatch))
for header, pattern := range rule.HeaderMatch {
re, err := compileWithTimeout(pattern)
if err != nil {
slog.Error("rule regex compilation failed (ReDoS protection)", "rule", rule.RuleName, "field", "HeaderMatch", "header", header, "pattern", pattern, "error", err)
continue
}
a.headerRegexs[header] = re
}
for _, pattern := range rule.BodyMatch {
re, err := compileWithTimeout(pattern)
if err != nil {
slog.Error("rule regex compilation failed (ReDoS protection)", "rule", rule.RuleName, "field", "BodyMatch", "pattern", pattern, "error", err)
continue
}
a.bodyRegexs = append(a.bodyRegexs, re)
}
for _, pattern := range rule.BodyMissing {
re, err := compileWithTimeout(pattern)
if err != nil {
slog.Error("rule regex compilation failed (ReDoS protection)", "rule", rule.RuleName, "field", "BodyMissing", "pattern", pattern, "error", err)
continue
}
a.bodyMissing = append(a.bodyMissing, re)
}
return a
}
func (r *ruleCheckAdapter) Name() string { return r.rule.RuleName }
func (r *ruleCheckAdapter) Run(ctx context.Context, pages []*crawler.Page) []check.Finding {
var findings []check.Finding
for _, page := range pages {
if page.Error != nil {
continue
}
if len(r.rule.StatusCodes) > 0 && !intIn(page.StatusCode, r.rule.StatusCodes) {
continue
}
if r.urlRegex != nil && !matchWithTimeout(r.urlRegex, page.URL) {
continue
}
// Header missing checks
for _, h := range r.rule.HeaderMissing {
if page.Headers.Get(h) == "" {
findings = append(findings, check.Finding{
Severity: check.Severity(r.rule.RuleSeverity),
URL: page.URL,
Message: r.rule.Description + ": missing header " + h,
Fix: r.rule.FixSuggestion,
})
}
}
// Header match checks (regex match = bad)
for header, re := range r.headerRegexs {
val := page.Headers.Get(header)
if val == "" {
continue
}
if matchWithTimeout(re, val) {
findings = append(findings, check.Finding{
Severity: check.Severity(r.rule.RuleSeverity),
URL: page.URL,
Message: r.rule.Description,
Evidence: header + ": " + val,
Fix: r.rule.FixSuggestion,
})
}
}
body := string(page.Body)
// Body match checks (regex match = bad)
for _, re := range r.bodyRegexs {
if loc := findWithTimeout(re, body); loc != "" {
findings = append(findings, check.Finding{
Severity: check.Severity(r.rule.RuleSeverity),
URL: page.URL,
Message: r.rule.Description,
Evidence: truncateEvidence(loc, 100),
Fix: r.rule.FixSuggestion,
})
break
}
}
// Body missing checks (pattern should be present but isn't)
for _, re := range r.bodyMissing {
if !matchWithTimeout(re, body) {
findings = append(findings, check.Finding{
Severity: check.Severity(r.rule.RuleSeverity),
URL: page.URL,
Message: r.rule.Description + ": expected pattern not found",
Fix: r.rule.FixSuggestion,
})
}
}
}
return findings
}
// customCheckAdapter wraps a public Checker for internal use.
type customCheckAdapter struct {
checker Checker
}
func (a *customCheckAdapter) Name() string { return a.checker.Name() }
func (a *customCheckAdapter) Run(ctx context.Context, pages []*crawler.Page) []check.Finding {
publicPages := make([]*Page, len(pages))
for i, p := range pages {
headers := make(map[string]string)
for k := range p.Headers {
headers[k] = p.Headers.Get(k)
}
links := make([]PageLink, len(p.Links))
for j, l := range p.Links {
links[j] = PageLink{Href: l.Href, Text: l.Text, External: l.External}
}
publicPages[i] = &Page{
URL: p.URL,
StatusCode: p.StatusCode,
Headers: headers,
Body: p.Body,
Links: links,
Depth: p.Depth,
ParentURL: p.ParentURL,
}
}
findings := a.checker.Run(ctx, publicPages)
internal := make([]check.Finding, len(findings))
for i, f := range findings {
internal[i] = check.Finding{
Severity: check.Severity(f.Severity),
URL: f.URL,
Element: f.Element,
Message: f.Message,
Fix: f.Fix,
Evidence: f.Evidence,
}
}
return internal
}
// getCustomInternalChecks converts public Checker and RuleCheck slices into
// internal check.Checker adapters. This accepts explicit slices so that
// per-Scanner custom checks can be passed in without relying on global state.
func getCustomInternalChecks(checks []Checker, rules []RuleCheck) []check.Checker {
var result []check.Checker
for _, c := range checks {
result = append(result, &customCheckAdapter{checker: c})
}
for _, r := range rules {
result = append(result, newRuleCheckAdapter(r))
}
return result
}
// getGlobalCustomInternalChecks returns checks registered via the global
// RegisterCheck/RegisterRule functions. Kept for backward compatibility.
func getGlobalCustomInternalChecks() []check.Checker {
customChecksMu.RLock()
defer customChecksMu.RUnlock()
return getCustomInternalChecks(customChecks, customRules)
}
func intIn(n int, list []int) bool {
for _, x := range list {
if n == x {
return true
}
}
return false
}
func truncateEvidence(s string, max int) string {
s = strings.ReplaceAll(s, "\n", " ")
runes := []rune(s)
if len(runes) <= max {
return s
}
return string(runes[:max]) + "..."
}