Upgrade navigation to version 5.x

[mauriguz]

Right now the project uses a mix of v4 and v5 for navigation, we want to unify all navigation to version 5.x
https://reactnavigation.org/docs/upgrading-from-4.x/

• Install @react-navigation/native & @react-navigation/stack
• Uninstall react-navigation & react-navigation-stack
• Align all @react-navigation packages in the project to v5
• Replace createAppContainer with NavigationContainer
• Replace onNavigationStateChange with onStateChange
• Native crash: Cannot find types in react-navigation/native

[justinhartman]

Hey guys, I've started to take a stab at this and committed some changes in a feature branch of mine. You can view the diff between master and my changes here.

As an overview, my changes include:

• Unified navigation on React Navigation v5 by adding @react-navigation/native and @react-navigation/stack while updating @react-navigation/core in package dependencies.
• Update the custom stack navigator to import and instantiate StackRouter, replacing the legacy SwitchRouter usage to align with React Navigation v5 APIs.
• Update the application router to build routes via StackRouter, enabling compatibility with React Navigation v5 across top-level navigation flows.
• Replaced deprecated createAppContainer usage with NavigationContainer and migrated to the onStateChange callback in application routers.
• Modernised native face-verification routing by wrapping stack navigators in NavigationContainer and handling analytics setup in a lazy-loaded container.
• Remove Flow libdefs for react-navigation v3/v4.
• Add a Jest mock for @react-navigation/native so tests receive a lightweight NavigationContainer without triggering version conflicts, simplifying the React Navigation v4 → v5 transition in the test environment.
• Rework dashboard snapshot test to use a mocked stack navigator that wraps the component in a lightweight navigator context, removing the previous reliance on createSwitchNavigator.
• Add reusable createStackNavigator stub in the shared test utilities, injecting mock navigation functions so screens under test receive a navigation prop without pulling in external navigation packages.

---

I am having and have had issues with running tests to get this to a point where I know this works. Here's an overview of the testing I've tried (and failed)...

How Has This Been Tested?

I ran a yarn test:setup along with yarn test:web and in fact tried most test commands in the project prior to making any code changes. I've had very little success in getting most of the test to run successfully even before I touched any code. I even ran a simple yarn test but that took hours and I eventually gave up. All the files I touched had a failing test for every single one of them so I don't know how else to test this when they all failed to begin with.

I'm sure the failing tests on master are a result of something I've got misconfigured but I've tried to isolate the testing based on the affected components I changed. In particular, these have been tested on both branches:

• src/components/appNavigation/__tests__/AppNavigation.jsx
• src/components/dashboard/__tests__/Dashboard.jsx
• src/components/signin/__tests__/SigninInfo.jsx
• src/components/signup/__tests__/EmailConfirmation.jsx
• src/components/signup/__tests__/MaginLinkInfo.jsx
• src/components/signup/__tests__/SmsForm.jsx

The following are changed in the test suite but untestable in isolation due to the testPathIgnorePatterns so I'm not too phased about this:

• src/components/auth/__tests__/__util__/index.jsx
• src/components/backupWallet/__tests__/__util__/index.jsx
• src/components/dashboard/__tests__/__util__/index.jsx
• src/components/signup/__tests__/__util__/index.jsx

Here's a sample of what I'm getting when running tests on master:

Test of src/components/dashboard/__tests__/Dashboard.js on the master branch...

NODE_OPTIONS="--openssl-legacy-provider" REACT_APP_ENV=test npx jest src/components/dashboard/__tests__/Dashboard.jsx
    Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

       6 | import { i18n } from '@lingui/core'
       7 | import { Helmet } from 'react-helmet'
    >  8 | import { GoodUIi18nProvider, useGoodUILanguage } from '@gooddollar/good-design'
         | ^
       9 |
      10 | import logger from '../lib/logger/js-logger'
      11 | import AsyncStorage from '../lib/utils/asyncStorage'

      at call (node_modules/react/cjs/react.development.js:220:30)
      at printWarning (node_modules/react/cjs/react.development.js:196:5)
      at Object.error [as createElement] (node_modules/react/cjs/react.development.js:2215:7)
      at Object.createElement (node_modules/native-base/lib/commonjs/components/primitives/Icon/Icons/questionIconPath.tsx:6:5)
      at Object.require (node_modules/native-base/lib/commonjs/components/primitives/Icon/SVGIcon.tsx:6:1)
      at Object.require (node_modules/native-base/lib/commonjs/components/primitives/Icon/Icon.tsx:4:1)
      at Object.require (node_modules/native-base/lib/commonjs/components/primitives/Icon/index.tsx:1:1)
      at Object.require (node_modules/native-base/lib/commonjs/components/composites/IconButton/index.tsx:3:1)
      at Object.require (node_modules/native-base/lib/commonjs/components/composites/index.ts:10:1)
      at Object.require (node_modules/native-base/lib/commonjs/index.tsx:1:1)
      at Object.require (node_modules/@gooddollar/good-design/dist/advanced/web3action/Web3Action.js:31:23)
      at Object.require (node_modules/@gooddollar/good-design/dist/advanced/web3action/index.js:17:14)
      at Object.require (node_modules/@gooddollar/good-design/dist/advanced/index.js:17:14)
      at Object.require (node_modules/@gooddollar/good-design/dist/index.js:17:14)
      at Object.require (src/language/i18n.jsx:8:1)
      at Object.require (src/__tests__/__util__/index.jsx:8:1)
      at Object.require (src/components/dashboard/__tests__/Dashboard.jsx:6:1)
      at call (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
      at Generator.tryCatch (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
      at Generator._invoke [as next] (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)

...SNIP<LOTS OF THESE WARNINGS>...

  console.log
    Initiating Orbis with options:  { useLit: false }

      at new log (node_modules/@orbisclub/orbis-sdk/index.js:107:11)
          at Array.map (<anonymous>)

  console.log
    Ceramic: Connected to node: https://node2.orbis.club/

      at new log (node_modules/@orbisclub/orbis-sdk/index.js:119:14)
          at Array.map (<anonymous>)

  console.error
    No read-only provider could be found { type: 'claim' }

      15 | export default showErrorDialog => {
      16 |   const userStorage = useUserStorage()
    > 17 |   const [expiryDate] = useIdentityExpiryDate(userStorage.wallet.account)
         |                                             ^
      18 |   const authPeriod = expiryDate?.authPeriod?.toNumber() || 360
      19 |   const expiration = moment().add(authPeriod, 'days').format('l')
      20 |

      at error (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:78:17)
      at sdkFactory (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:90:55)
      at initialState (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6657:20)
      at Object.mountState [as useState] (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7242:16)
      at useState (node_modules/react/cjs/react.development.js:1508:21)
      at useSDK (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:90:47)
      at useGetContract (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:53:35)
      at useIdentityExpiryDate (node_modules/@gooddollar/web3sdk-v2/dist/hooks/useIdentityHooks.js:11:46)
      at _default (src/lib/hooks/useDeleteAccountDialog.jsx:17:45)
      at Dashboard (src/components/dashboard/Dashboard.jsx:305:57)
      at Component (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6016:18)
      at renderWithHooks (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8744:13)
      at mountIndeterminateComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9966:16)
      at beginWork$1 (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13800:12)
      at performUnitOfWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13728:5)
      at workLoopSync (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13691:7)
      at renderRootSync (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13404:18)
      at callback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26)
      at eventHandler (node_modules/scheduler/cjs/scheduler.development.js:468:12)
      at Scheduler_runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
      at runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
      at flushSyncCallbackQueueImpl (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
      at flushSyncCallbackQueue (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
      at scheduleUpdateOnFiber (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7133:5)
      at setWalletAndStorage (src/lib/wallet/GoodWalletProvider.jsx:263:9)
      at call (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
      at Generator.tryCatch (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
      at Generator._invoke [as next] (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)

  console.error
    The above error occurred in the <Dashboard> component:
    
        at Dashboard (/Users/justin/Code/GitHub/GoodDAPP/src/components/dashboard/Dashboard.jsx:292:25)
        at WrappedComponent (/Users/justin/Code/GitHub/GoodDAPP/src/lib/styles/index.jsx:35:26)
        at apply (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@callstack/react-theme-provider/src/createWithTheme.js:21:31)
        at withTheme(WrappedComponent)
        at SceneView (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/views/SceneView.js:4:16)
        at div
        at hrefAttrs (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-native-web/dist/cjs/exports/View/index.js:53:25)
        at div
        at hrefAttrs (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-native-web/dist/cjs/exports/View/index.js:53:25)
        at styles (/Users/justin/Code/GitHub/GoodDAPP/src/components/common/view/Blurred/index.web.jsx:8:20)
        at WrappedComponent (/Users/justin/Code/GitHub/GoodDAPP/src/lib/styles/index.jsx:35:26)
        at apply (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@callstack/react-theme-provider/src/createWithTheme.js:21:31)
        at withTheme(WrappedComponent)
        at AppView (/Users/justin/Code/GitHub/GoodDAPP/src/components/appNavigation/stackNavigation.jsx:49:14)
        at Navigator (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/navigators/createNavigator.js:13:33)
        at SceneView (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/views/SceneView.js:4:16)
        at SwitchView (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/views/SwitchView/SwitchView.js:4:16)
        at Navigator (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/navigators/createNavigator.js:13:33)
        at /Users/justin/Code/GitHub/GoodDAPP/src/__tests__/__util__/index.jsx:27:58
        at /Users/justin/Code/GitHub/GoodDAPP/src/__tests__/__util__/index.jsx:27:58
        at children (/Users/justin/Code/GitHub/GoodDAPP/src/lib/wallet/GoodWalletProvider.jsx:443:26)
        at children (/Users/justin/Code/GitHub/GoodDAPP/src/lib/wallet/GoodWalletProvider.jsx:92:38)
        at DialogContextProvider (/Users/justin/Code/GitHub/GoodDAPP/src/lib/dialog/dialogContext.jsx:12:43)
        at GlobalTogglesContextProvider (/Users/justin/Code/GitHub/GoodDAPP/src/lib/contexts/togglesContext.jsx:7:51)
        at children (/Users/justin/Code/GitHub/GoodDAPP/src/__tests__/__util__/index.jsx:10:33)
        at apply (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@callstack/react-theme-provider/src/createThemeProvider.js:14:3)
        at div
        at hrefAttrs (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-native-web/dist/cjs/exports/View/index.js:53:25)
        at PortalHost (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-native-paper/lib/module/components/Portal/PortalHost.tsx:44:64)
        at Provider (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-native-paper/lib/module/core/Provider.tsx:14:16)
        at children (/Users/justin/Code/GitHub/GoodDAPP/src/lib/wallet/GoodWalletProvider.jsx:443:26)
        at children (/Users/justin/Code/GitHub/GoodDAPP/src/lib/wallet/GoodWalletProvider.jsx:92:38)
        at DialogContextProvider (/Users/justin/Code/GitHub/GoodDAPP/src/lib/dialog/dialogContext.jsx:12:43)
        at GlobalTogglesContextProvider (/Users/justin/Code/GitHub/GoodDAPP/src/lib/contexts/togglesContext.jsx:7:51)
        at children (/Users/justin/Code/GitHub/GoodDAPP/src/__tests__/__util__/index.jsx:10:33)
        at AppNavigation (/Users/justin/Code/GitHub/GoodDAPP/src/components/dashboard/__tests__/Dashboard.jsx:16:20)
        at SceneView (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/views/SceneView.js:4:16)
        at SwitchView (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/views/SwitchView/SwitchView.js:4:16)
        at Navigator (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/core/lib/commonjs/navigators/createNavigator.js:13:33)
        at WebApp (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@react-navigation/web/dist/createBrowserApp.js:78:26)
    
    Consider adding an error boundary to your tree to customize error handling behavior.
    Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.

      261 |         }
      262 |
    > 263 |         setWalletAndStorage({
          |         ^
      264 |           goodWallet: wallet,
      265 |           userStorage: storage,
      266 |           celowallet,

      at logCapturedError (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10989:23)
      at logCapturedError (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11022:5)
      at call (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3662:12)
      at callCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3683:9)
      at commitUpdateQueue (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11855:11)
      at commitLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:14443:7)
      at HTMLUnknownElement.apply (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11391:14)
      at HTMLUnknownElement.callTheUserObjectsOperation (node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
      at innerInvokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:350:25)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:286:3)
      at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:233:9)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:104:17)
      at HTMLUnknownElement.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:241:34)
      at Object.dispatchEvent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11440:16)
      at apply (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11499:31)
      at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:14172:9)
      at eventHandler (node_modules/scheduler/cjs/scheduler.development.js:468:12)
      at Scheduler_runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
      at runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:14011:3)
      at commitRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13440:3)
      at callback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26)
      at eventHandler (node_modules/scheduler/cjs/scheduler.development.js:468:12)
      at Scheduler_runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
      at runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
      at flushSyncCallbackQueueImpl (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
      at flushSyncCallbackQueue (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
      at scheduleUpdateOnFiber (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7133:5)
      at setWalletAndStorage (src/lib/wallet/GoodWalletProvider.jsx:263:9)
      at call (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
      at Generator.tryCatch (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
      at Generator._invoke [as next] (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)

  console.error
    { from: 'GoodWalletProvider' } failed initializing wallet and userstorage: Cannot read properties of undefined (reading 'getNetwork') TypeError: Cannot read properties of undefined (reading 'getNetwork')
        at new getNetwork (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/sdk.js:38:14)
        at construct (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/claim/sdk.js:1:14)
        at new _callSuper (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/claim/sdk.js:10:15)
        at sdkFactory (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:84:12)
        at sdkFactory (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:90:55)
        at initialState (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6657:20)
        at Object.mountState [as useState] (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7242:16)
        at useState (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react/cjs/react.development.js:1508:21)
        at useSDK (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:90:47)
        at useGetContract (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:53:35)
        at useIdentityExpiryDate (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@gooddollar/web3sdk-v2/dist/hooks/useIdentityHooks.js:11:46)
        at _default (/Users/justin/Code/GitHub/GoodDAPP/src/lib/hooks/useDeleteAccountDialog.jsx:17:45)
        at Dashboard (/Users/justin/Code/GitHub/GoodDAPP/src/components/dashboard/Dashboard.jsx:305:57)
        at Component (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6016:18)
        at renderWithHooks (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8744:13)
        at mountIndeterminateComponent (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9966:16)
        at beginWork$1 (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13800:12)
        at performUnitOfWork (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13728:5)
        at workLoopSync (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13691:7)
        at renderRootSync (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13404:18)
        at callback (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26)
        at eventHandler (/Users/justin/Code/GitHub/GoodDAPP/node_modules/scheduler/cjs/scheduler.development.js:468:12)
        at Scheduler_runWithPriority (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
        at runWithPriority (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
        at flushSyncCallbackQueueImpl (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
        at flushSyncCallbackQueue (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
        at scheduleUpdateOnFiber (/Users/justin/Code/GitHub/GoodDAPP/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7133:5)
        at setWalletAndStorage (/Users/justin/Code/GitHub/GoodDAPP/src/lib/wallet/GoodWalletProvider.jsx:263:9)
        at call (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
        at Generator.tryCatch (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
        at Generator._invoke [as next] (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
        at asyncGeneratorStep (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
        at asyncGeneratorStep (/Users/justin/Code/GitHub/GoodDAPP/node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)

      73 |   // if log level enabled - print on console
      74 |   if (context.level.value >= logLevel.value) {
    > 75 |     consoleHandler(messages, context)
         |     ^
      76 |   }
      77 | })
      78 |

      at call (node_modules/js-logger/src/logger.js:197:29)
      at invokeConsoleMethod (node_modules/js-logger/src/logger.js:248:5)
      at consoleHandler (src/lib/logger/js-logger.js:75:5)
      at ContextualLogger.logHandler [as invoke] (node_modules/js-logger/src/logger.js:118:5)
      at ContextualLogger.invoke (node_modules/js-logger/src/logger.js:100:9)
      at ContextualLogger.apply (src/lib/logger/js-logger.js:57:13)
      at error (src/lib/wallet/GoodWalletProvider.jsx:273:13)
      at call (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
      at Generator.tryCatch (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
      at Generator._invoke [as next] (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)

 FAIL  src/components/dashboard/__tests__/Dashboard.jsx (36.112 s)
  Dashboard
    ✕ matches snapshot (6559 ms)

  ● Dashboard › matches snapshot

    TypeError: Cannot read properties of undefined (reading 'getNetwork')

      15 | export default showErrorDialog => {
      16 |   const userStorage = useUserStorage()
    > 17 |   const [expiryDate] = useIdentityExpiryDate(userStorage.wallet.account)
         |                                             ^
      18 |   const authPeriod = expiryDate?.authPeriod?.toNumber() || 360
      19 |   const expiration = moment().add(authPeriod, 'days').format('l')
      20 |

      at new getNetwork (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/sdk.js:38:14)
      at construct (node_modules/@gooddollar/web3sdk-v2/dist/sdk/claim/sdk.js:1:14)
      at new _callSuper (node_modules/@gooddollar/web3sdk-v2/dist/sdk/claim/sdk.js:10:15)
      at sdkFactory (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:84:12)
      at sdkFactory (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:90:55)
      at initialState (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6657:20)
      at Object.mountState [as useState] (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7242:16)
      at useState (node_modules/react/cjs/react.development.js:1508:21)
      at useSDK (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:90:47)
      at useGetContract (node_modules/@gooddollar/web3sdk-v2/dist/sdk/base/react.js:53:35)
      at useIdentityExpiryDate (node_modules/@gooddollar/web3sdk-v2/dist/hooks/useIdentityHooks.js:11:46)
      at _default (src/lib/hooks/useDeleteAccountDialog.jsx:17:45)
      at Dashboard (src/components/dashboard/Dashboard.jsx:305:57)
      at Component (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6016:18)
      at renderWithHooks (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8744:13)
      at mountIndeterminateComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9966:16)
      at beginWork$1 (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13800:12)
      at performUnitOfWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13728:5)
      at workLoopSync (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13691:7)
      at renderRootSync (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13404:18)
      at callback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26)
      at eventHandler (node_modules/scheduler/cjs/scheduler.development.js:468:12)
      at Scheduler_runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
      at runWithPriority (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
      at flushSyncCallbackQueueImpl (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
      at flushSyncCallbackQueue (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
      at scheduleUpdateOnFiber (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7133:5)
      at setWalletAndStorage (src/lib/wallet/GoodWalletProvider.jsx:263:9)
      at call (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
      at Generator.tryCatch (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
      at Generator._invoke [as next] (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)

  ● Dashboard › matches snapshot

    expect(received).toMatchSnapshot()

    Snapshot name: `Dashboard matches snapshot 1`

    Snapshot: <...>
    Received: null

      36 |     await renderer.act(async () => (component = renderer.create(<WebRouter />)))
      37 |     const tree = component.toJSON()
    > 38 |     expect(tree).toMatchSnapshot()
         |                  ^
      39 |   })
      40 | })
      41 |

      at toMatchSnapshot (src/components/dashboard/__tests__/Dashboard.jsx:38:18)
      at call (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
      at Generator.tryCatch (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
      at Generator._invoke [as next] (node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)

 › 1 snapshot failed.
Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `npm run npx -- -u` to update them.

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   1 failed, 1 total
Time:        39.203 s, estimated 85 s
Ran all test suites matching /src\/components\/dashboard\/__tests__\/Dashboard.jsx/i.

I can see post my changes that the same issues exist but I also see snapshots are failing. My questions are thus:

1. What do I need to do to get the master to run successful tests? What am I missing?
2. I am unsure how *.jsx.snap snapshot files are generated. Can you advise me on how I can generate these so I know my tests on the changes will use any updated snapshots?

I'm happy to rework anything based on the fact these tests feel near impossible for me to simulate correctly so feel free to guide me on what I need to do.

Finally, if you think I'm going in completely the wrong direction with the code changes - let me know so I can change direction.

Thanks for the help.

[L03TJ3]

@justinhartman Hey there.
How did you end up on our repository, and started looking into issues here? you come through scoutgame?

Sorry for the time you have spent on this.
Our wallet is sunset and no longer takes new submissions, and users are redirected to the new GoodWallet (different, closed-source repository at this moment).
our blog page you can read more about the sunset of wallet: https://gooddollar.notion.site/Meet-the-New-GoodWallet-Smarter-Faster-Built-for-the-Future-Here-s-What-You-Need-to-Know-1f1f258232f0802e9198ebd0d68af39c

[justinhartman]

@justinhartman Hey there.
How did you end up on our repository, and started looking into issues here? you come through scoutgame?

Sorry for the time you have spent on this.
Our wallet is sunset and no longer takes new submissions, and users are redirected to the new GoodWallet (different, closed-source repository at this moment).
our blog page you can read more about the sunset of wallet: https://gooddollar.notion.site/Meet-the-New-GoodWallet-Smarter-Faster-Built-for-the-Future-Here-s-What-You-Need-to-Know-1f1f258232f0802e9198ebd0d68af39c

Oh right, OK I didn't realise this. I thought the code base for this felt a little stale. I got into GoodWallet from the Superfluid website. They linked out to the attached website that has this repo as the 2nd most popular project.

Since I'm a GoodWallet user I thought the combo made sense for me so that's why I jumped on board.

Thanks for letting me know @L03TJ3