Skip to content

Commit ac84468

Browse files
committed
fix: cleanup public api of platform-server
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap() Parse5Adapter is an implementation detail not a public API
1 parent 387a90e commit ac84468

7 files changed

Lines changed: 89 additions & 131 deletions

File tree

modules/@angular/platform-server/core_private.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import {__core_private__ as r, __core_private_types__ as t} from '@angular/core';
22

3-
export type NoOpAnimationPlayer = t.NoOpAnimationPlayer;
4-
export var NoOpAnimationPlayer: typeof t.NoOpAnimationPlayer = r.NoOpAnimationPlayer;
5-
export type AnimationPlayer = t.AnimationPlayer;
6-
export var AnimationPlayer: typeof t.AnimationPlayer = r.AnimationPlayer;
3+
export var reflector: typeof t.reflector = r.reflector;
4+
export var ReflectionCapabilities: typeof t.ReflectionCapabilities = r.ReflectionCapabilities;
5+
export var wtfInit: typeof t.wtfInit = r.wtfInit;
76
export type NoOpAnimationDriver = t.NoOpAnimationDriver;
87
export var NoOpAnimationDriver: typeof t.NoOpAnimationDriver = r.NoOpAnimationDriver;
98
export type AnimationDriver = t.AnimationDriver;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
// TODO: vsavkin add SERVER_PROVIDERS and SERVER_APP_PROVIDERS
1+
// TODO: vsavkin add SERVER_PROVIDERS and SERVER_APPLICATION_PROVIDERS
22
export 'package:angular2/src/platform/server/html_adapter.dart';
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: vsavkin add SERVER_PROVIDERS and SERVER_APP_PROVIDERS
2-
export {Parse5DomAdapter} from './src/parse5_adapter';
1+
export {SERVER_APPLICATION_PROVIDERS, SERVER_PLATFORM_PROVIDERS, serverBootstrap} from './src/server';
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
import {PlatformLocation} from '@angular/common';
2+
import {ComponentRef, OpaqueToken, PLATFORM_COMMON_PROVIDERS, PLATFORM_INITIALIZER, PlatformRef, ReflectiveInjector, Type, assertPlatform, coreLoadAndBootstrap, createPlatform, getPlatform} from '@angular/core';
3+
import {BROWSER_APP_COMPILER_PROVIDERS, BROWSER_APP_PROVIDERS, BrowserPlatformLocation} from '@angular/platform-browser';
4+
5+
import {ReflectionCapabilities, reflector, wtfInit} from '../core_private';
6+
7+
import {Parse5DomAdapter} from './parse5_adapter';
8+
9+
const SERVER_PLATFORM_MARKER = new OpaqueToken('ServerPlatformMarker');
10+
11+
/**
12+
* A set of providers to initialize the Angular platform in a server.
13+
*
14+
* Used automatically by `serverBootstrap`, or can be passed to {@link platform}.
15+
*/
16+
export const SERVER_PLATFORM_PROVIDERS: Array<any /*Type | Provider | any[]*/> = [
17+
{provide: SERVER_PLATFORM_MARKER, useValue: true}, PLATFORM_COMMON_PROVIDERS,
18+
{provide: PLATFORM_INITIALIZER, useValue: initParse5Adapter, multi: true},
19+
{provide: PlatformLocation, useClass: BrowserPlatformLocation}
20+
];
21+
22+
export const SERVER_APPLICATION_PROVIDERS: Array<any> =
23+
[BROWSER_APP_PROVIDERS, BROWSER_APP_COMPILER_PROVIDERS];
24+
25+
function initParse5Adapter() {
26+
Parse5DomAdapter.makeCurrent();
27+
wtfInit();
28+
}
29+
30+
31+
export function serverPlatform(): PlatformRef {
32+
if (!getPlatform()) {
33+
createPlatform(ReflectiveInjector.resolveAndCreate(SERVER_PLATFORM_PROVIDERS));
34+
}
35+
return assertPlatform(SERVER_PLATFORM_MARKER);
36+
}
37+
38+
39+
export function serverBootstrap(
40+
appComponentType: Type,
41+
customProviders?: Array<any /*Type | Provider | any[]*/>): Promise<ComponentRef<any>> {
42+
reflector.reflectionCapabilities = new ReflectionCapabilities();
43+
let providers = [SERVER_APPLICATION_PROVIDERS, customProviders || []];
44+
var appInjector = ReflectiveInjector.resolveAndCreate(providers, serverPlatform().injector);
45+
return coreLoadAndBootstrap(appComponentType, appInjector);
46+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
import {Component, disposePlatform} from '@angular/core';
2+
import {afterEach, async, beforeEach, ddescribe, describe, expect, iit, inject, it, xdescribe, xit} from '@angular/core/testing';
3+
import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter';
4+
import {serverBootstrap} from '@angular/platform-server';
5+
6+
import {Parse5DomAdapter} from '../src/parse5_adapter';
7+
8+
function writeBody(html: string): any {
9+
var dom = getDOM();
10+
var doc = dom.defaultDoc();
11+
var body = dom.querySelector(doc, 'body');
12+
dom.setInnerHTML(body, html);
13+
return body;
14+
}
15+
16+
export function main() {
17+
if (getDOM().supportsDOMEvents()) return; // NODE only
18+
19+
describe('platform-server integration', () => {
20+
21+
afterEach(() => disposePlatform());
22+
23+
it('should bootstrap', async(() => {
24+
var body = writeBody('<app></app>');
25+
serverBootstrap(MyServerApp).then(() => {
26+
expect(getDOM().getText(body)).toEqual('Works!');
27+
});
28+
}));
29+
});
30+
}
31+
32+
@Component({selector: 'app', template: `Works!`})
33+
class MyServerApp {
34+
}

modules/@angular/platform-server/testing/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {APPLICATION_COMMON_PROVIDERS, APP_ID, NgZone, PLATFORM_COMMON_PROVIDERS,
55
import {BrowserDetection, DOMTestComponentRenderer} from '@angular/platform-browser/testing';
66

77
import {AnimationDriver, NoOpAnimationDriver} from '../core_private';
8-
import {Parse5DomAdapter} from '../index';
8+
import {Parse5DomAdapter} from '../src/parse5_adapter';
99

1010
import {DOCUMENT, BROWSER_SANITIZATION_PROVIDERS, EventManager, EVENT_MANAGER_PLUGINS, ELEMENT_PROBE_PROVIDERS, DomEventsPlugin,} from '@angular/platform-browser';
1111
import {getDOM, DomRootRenderer, DomRootRenderer_, DomSharedStylesHost, SharedStylesHost} from '../platform_browser_private';

tools/public_api_guard/public_api_spec.ts

Lines changed: 3 additions & 123 deletions
Original file line numberDiff line numberDiff line change
@@ -1655,129 +1655,9 @@ const PLATFORM_BROWSER_TESTING_E2E = [
16551655
];
16561656

16571657
const PLATFORM_SERVER = [
1658-
'Parse5DomAdapter',
1659-
'Parse5DomAdapter.addClass(element:any, className:string):any',
1660-
'Parse5DomAdapter.adoptNode(node:any):any',
1661-
'Parse5DomAdapter.animate(element:any, keyframes:any[], options:any):any',
1662-
'Parse5DomAdapter.appendChild(el:any, node:any):any',
1663-
'Parse5DomAdapter.attributeMap(element:any):Map<string, string>',
1664-
'Parse5DomAdapter.attrToPropMap:any',
1665-
'Parse5DomAdapter.cancelAnimationFrame(id:number):any',
1666-
'Parse5DomAdapter.childNodes(el:any):Node[]',
1667-
'Parse5DomAdapter.childNodesAsList(el:any):any[]',
1668-
'Parse5DomAdapter.classList(element:any):string[]',
1669-
'Parse5DomAdapter.clearNodes(el:any):any',
1670-
'Parse5DomAdapter.clone(node:Node):Node',
1671-
'Parse5DomAdapter.content(node:any):string',
1672-
'Parse5DomAdapter.createComment(text:string):Comment',
1673-
'Parse5DomAdapter.createElement(tagName:any):HTMLElement',
1674-
'Parse5DomAdapter.createElementNS(ns:any, tagName:any):HTMLElement',
1675-
'Parse5DomAdapter.createEvent(eventType:string):Event',
1676-
'Parse5DomAdapter.createHtmlDocument():Document',
1677-
'Parse5DomAdapter.createMouseEvent(eventType:any):Event',
1678-
'Parse5DomAdapter.createScriptTag(attrName:string, attrValue:string):HTMLElement',
1679-
'Parse5DomAdapter.createShadowRoot(el:any):HTMLElement',
1680-
'Parse5DomAdapter.createStyleElement(css:string):HTMLStyleElement',
1681-
'Parse5DomAdapter.createTemplate(html:any):HTMLElement',
1682-
'Parse5DomAdapter.createTextNode(text:string):Text',
1683-
'Parse5DomAdapter.defaultDoc():Document',
1684-
'Parse5DomAdapter.dispatchEvent(el:any, evt:any):any',
1685-
'Parse5DomAdapter.elementMatches(node:any, selector:string, matcher:any=null):boolean',
1686-
'Parse5DomAdapter.firstChild(el:any):Node',
1687-
'Parse5DomAdapter.getAnimationPrefix():string',
1688-
'Parse5DomAdapter.getAttribute(element:any, attribute:string):string',
1689-
'Parse5DomAdapter.getAttributeNS(element:any, ns:string, attribute:string):string',
1690-
'Parse5DomAdapter.getBaseHref():string',
1691-
'Parse5DomAdapter.getBoundingClientRect(el:any):any',
1692-
'Parse5DomAdapter.getChecked(el:any):boolean',
1693-
'Parse5DomAdapter.getComputedStyle(el:any):any',
1694-
'Parse5DomAdapter.getCookie(name:string):string',
1695-
'Parse5DomAdapter.getData(el:any, name:string):string',
1696-
'Parse5DomAdapter.getDistributedNodes(el:any):Node[]',
1697-
'Parse5DomAdapter.getElementsByClassName(element:any, name:string):HTMLElement[]',
1698-
'Parse5DomAdapter.getElementsByTagName(element:any, name:string):HTMLElement[]',
1699-
'Parse5DomAdapter.getEventKey(event:any):string',
1700-
'Parse5DomAdapter.getGlobalEventTarget(target:string):any',
1701-
'Parse5DomAdapter.getHistory():History',
1702-
'Parse5DomAdapter.getHost(el:any):string',
1703-
'Parse5DomAdapter.getHref(el:any):string',
1704-
'Parse5DomAdapter.getInnerHTML(el:any):string',
1705-
'Parse5DomAdapter.getLocation():Location',
1706-
'Parse5DomAdapter.getOuterHTML(el:any):string',
1707-
'Parse5DomAdapter.getProperty(el:any, name:string):any',
1708-
'Parse5DomAdapter.getShadowRoot(el:any):Element',
1709-
'Parse5DomAdapter.getStyle(element:any, styleName:string):string',
1710-
'Parse5DomAdapter.getTemplateContent(el:any):Node',
1711-
'Parse5DomAdapter.getText(el:any, isRecursive?:boolean):string',
1712-
'Parse5DomAdapter.getTitle():string',
1713-
'Parse5DomAdapter.getTransitionEnd():string',
1714-
'Parse5DomAdapter.getUserAgent():string',
1715-
'Parse5DomAdapter.getValue(el:any):string',
1716-
'Parse5DomAdapter.getXHR():Type',
1717-
'Parse5DomAdapter.hasAttribute(element:any, attribute:string):boolean',
1718-
'Parse5DomAdapter.hasAttributeNS(element:any, ns:string, attribute:string):boolean',
1719-
'Parse5DomAdapter.hasClass(element:any, className:string):boolean',
1720-
'Parse5DomAdapter.hasProperty(element:any, name:string):boolean',
1721-
'Parse5DomAdapter.hasShadowRoot(node:any):boolean',
1722-
'Parse5DomAdapter.hasStyle(element:any, styleName:string, styleValue:string=null):boolean',
1723-
'Parse5DomAdapter.importIntoDoc(node:any):any',
1724-
'Parse5DomAdapter.insertAfter(el:any, node:any):any',
1725-
'Parse5DomAdapter.insertAllBefore(el:any, nodes:any):any',
1726-
'Parse5DomAdapter.insertBefore(el:any, node:any):any',
1727-
'Parse5DomAdapter.invoke(el:Element, methodName:string, args:any[]):any',
1728-
'Parse5DomAdapter.isCommentNode(node:any):boolean',
1729-
'Parse5DomAdapter.isElementNode(node:any):boolean',
1730-
'Parse5DomAdapter.isPrevented(evt:any):boolean',
1731-
'Parse5DomAdapter.isShadowRoot(node:any):boolean',
1732-
'Parse5DomAdapter.isTemplateElement(el:any):boolean',
1733-
'Parse5DomAdapter.isTextNode(node:any):boolean',
1734-
'Parse5DomAdapter.log(error:any):any',
1735-
'Parse5DomAdapter.logError(error:any):any',
1736-
'Parse5DomAdapter.logGroup(error:any):any',
1737-
'Parse5DomAdapter.logGroupEnd():any',
1738-
'Parse5DomAdapter.makeCurrent():any',
1739-
'Parse5DomAdapter.nextSibling(el:any):Node',
1740-
'Parse5DomAdapter.nodeName(node:any):string',
1741-
'Parse5DomAdapter.nodeValue(node:any):string',
1742-
'Parse5DomAdapter.on(el:any, evt:any, listener:any):any',
1743-
'Parse5DomAdapter.onAndCancel(el:any, evt:any, listener:any):Function',
1744-
'Parse5DomAdapter.parentElement(el:any):Node',
1745-
'Parse5DomAdapter.parse(templateHtml:string):any',
1746-
'Parse5DomAdapter.performanceNow():number',
1747-
'Parse5DomAdapter.preventDefault(evt:any):any',
1748-
'Parse5DomAdapter.query(selector:any):any',
1749-
'Parse5DomAdapter.querySelector(el:any, selector:string):any',
1750-
'Parse5DomAdapter.querySelectorAll(el:any, selector:string):any[]',
1751-
'Parse5DomAdapter.remove(el:any):HTMLElement',
1752-
'Parse5DomAdapter.removeAttribute(element:any, attribute:string):any',
1753-
'Parse5DomAdapter.removeAttributeNS(element:any, ns:string, name:string):any',
1754-
'Parse5DomAdapter.removeChild(el:any, node:any):any',
1755-
'Parse5DomAdapter.removeClass(element:any, className:string):any',
1756-
'Parse5DomAdapter.removeStyle(element:any, styleName:string):any',
1757-
'Parse5DomAdapter.replaceChild(el:any, newNode:any, oldNode:any):any',
1758-
'Parse5DomAdapter.requestAnimationFrame(callback:any):number',
1759-
'Parse5DomAdapter.resetBaseElement():void',
1760-
'Parse5DomAdapter.resolveAndSetHref(el:any, baseUrl:string, href:string):any',
1761-
'Parse5DomAdapter.setAttribute(element:any, attribute:string, value:string):any',
1762-
'Parse5DomAdapter.setAttributeNS(element:any, ns:string, attribute:string, value:string):any',
1763-
'Parse5DomAdapter.setChecked(el:any, value:boolean):any',
1764-
'Parse5DomAdapter.setCookie(name:string, value:string):any',
1765-
'Parse5DomAdapter.setData(el:any, name:string, value:string):any',
1766-
'Parse5DomAdapter.setGlobalVar(path:string, value:any):any',
1767-
'Parse5DomAdapter.setInnerHTML(el:any, value:any):any',
1768-
'Parse5DomAdapter.setProperty(el:any, name:string, value:any):any',
1769-
'Parse5DomAdapter.setStyle(element:any, styleName:string, styleValue:string):any',
1770-
'Parse5DomAdapter.setText(el:any, value:string):any',
1771-
'Parse5DomAdapter.setTitle(newTitle:string):any',
1772-
'Parse5DomAdapter.setValue(el:any, value:string):any',
1773-
'Parse5DomAdapter.supportsAnimation():boolean',
1774-
'Parse5DomAdapter.supportsCookies():boolean',
1775-
'Parse5DomAdapter.supportsDOMEvents():boolean',
1776-
'Parse5DomAdapter.supportsNativeShadowDOM():boolean',
1777-
'Parse5DomAdapter.supportsWebAnimation():boolean',
1778-
'Parse5DomAdapter.tagName(element:any):string',
1779-
'Parse5DomAdapter.templateAwareRoot(el:any):any',
1780-
'Parse5DomAdapter.type(node:any):string',
1658+
'const SERVER_APPLICATION_PROVIDERS:Array<any>',
1659+
'const SERVER_PLATFORM_PROVIDERS:Array<any>',
1660+
'serverBootstrap(appComponentType:Type, customProviders?:Array<any>):Promise<ComponentRef<any>>',
17811661
];
17821662

17831663
const PLATFORM_SERVER_TESTING = [

0 commit comments

Comments
 (0)